From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0021A052A; Thu, 26 Nov 2020 12:49:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB371C93E; Thu, 26 Nov 2020 12:49:01 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 93ABBC93C for ; Thu, 26 Nov 2020 12:48:58 +0100 (CET) IronPort-SDR: elzENqvCgZhFLJNotwFLZtgDIwK2R+eWqBOAA6/vctHQTV/yRT8CfolVnUFo4vY0fmg/9kV2W3 j1lWDSHZlUvA== X-IronPort-AV: E=McAfee;i="6000,8403,9816"; a="152108910" X-IronPort-AV: E=Sophos;i="5.78,372,1599548400"; d="scan'208";a="152108910" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Nov 2020 03:48:43 -0800 IronPort-SDR: oPb1NyjhgbOaXciSu7Jdl3hyl5ybEH+pxOPEEYdcDhyPJ/SY6x4yQ7cFMDIPtfaihVzgH3vXsJ GkGBFvVgiYcQ== X-IronPort-AV: E=Sophos;i="5.78,371,1599548400"; d="scan'208";a="479329225" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.21.198]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 26 Nov 2020 03:48:42 -0800 Date: Thu, 26 Nov 2020 11:48:38 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org Message-ID: <20201126114838.GC1340@bricha3-MOBL.ger.corp.intel.com> References: <20200906033846.24686-1-stephen@networkplumber.org> <20200924175347.13619-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2] doc/devbind: remove references to igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 14, 2020 at 05:43:29PM +0100, Ferruh Yigit wrote: > On 9/24/2020 6:53 PM, Stephen Hemminger wrote: > > We should be encouraging the use of vfio_pci for developers, not telling > > them to use igb_uio. > > > > Signed-off-by: Stephen Hemminger > > --- > > v2 -- drop change about filename > > > > doc/guides/tools/devbind.rst | 18 +++++++++--------- > > 1 file changed, 9 insertions(+), 9 deletions(-) > > > > diff --git a/doc/guides/tools/devbind.rst b/doc/guides/tools/devbind.rst > > index a2910e103aab..5dcaf8c207dd 100644 > > --- a/doc/guides/tools/devbind.rst > > +++ b/doc/guides/tools/devbind.rst > > @@ -30,11 +30,11 @@ OPTIONS > > Print the current status of all known network interfaces. > > For each device, it displays the PCI domain, bus, slot and function, > > along with a text description of the device. Depending upon whether the > > - device is being used by a kernel driver, the ``igb_uio`` driver, or no > > + device is being used by a kernel driver, the ``vfio_pci`` driver, or no > > driver, other relevant information will be displayed: > > - the Linux interface name e.g. ``if=eth0`` > > - - the driver being used e.g. ``drv=igb_uio`` > > - - any suitable drivers not currently using that device e.g. ``unused=igb_uio`` > > + - the driver being used e.g. ``drv=vfio_pci`` > > + - any suitable drivers not currently using that device e.g. ``unused=vfio_pci`` > > NOTE: if this flag is passed along with a bind/unbind option, the > > status display will always occur after the other operations have taken > > place. > > @@ -80,9 +80,9 @@ To display current device status:: > > dpdk-devbind --status > > -To bind eth1 from the current driver and move to use igb_uio:: > > +To bind eth1 from the current driver and move to use vfio_pci:: > > - dpdk-devbind --bind=igb_uio eth1 > > + dpdk-devbind --bind=vfio_pci eth1 > > Module name is 'vfio_pci' but driver name is 'vfio-pci', for this document I > guess all instances should be 'vfio-pci'. > Yes, I believe all instances of vfio_pci should be replaced with the "-"ed version. With that change: Acked-by: Bruce Richardson