From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CBCCBA052A; Sat, 28 Nov 2020 22:11:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 96CC4C902; Sat, 28 Nov 2020 22:11:37 +0100 (CET) Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 613C7C8CC; Sat, 28 Nov 2020 22:11:35 +0100 (CET) Received: by mail-lf1-f67.google.com with SMTP id u19so12495068lfr.7; Sat, 28 Nov 2020 13:11:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ly+bHG7pZ76gaJ38o/YoKZFVwXwuEfoJh8OWGJ9QG1Y=; b=ryaE3py8ijP8G23eCdC0wbMnsJ3NM5gr8gQqhLEc15UdYj3dDScwgJil4xMtJHQ4/B abQUSbcQxTLPMB0Or6hluyt3mAfFN/6grqUC+9dwpq49OCSm++zxUImtXYQl+tr+RP5Q 7n6O8VNyRhq69NzQhAiiTbgVnCMtTzJ7h3xcyL3Ta3dPajPKQI7y1gxPv+2bqF9HC/dg akues22TQOD/pHdnoT6oJkFyqqZ8fEBpKGecHjWnImEZrX2pI70PtJjYDM1xw1Un9BAU NRd3nK92jaaRW5+HNeRrPW3qi/7rbNJGpA0a3iteUs826k5rLTySjrJ7LQ9SK2GYr4O7 k9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ly+bHG7pZ76gaJ38o/YoKZFVwXwuEfoJh8OWGJ9QG1Y=; b=cm3ZhU1DHMX+vR501iC/pabxFxH30DLSvH6hJJnjDxoKHqpi0F0YSU04lpOyjeATMF 8EQCfKSgRCv6QGk2SBIl9TZRwCTuQODX9XtWQO5fQFpvTI+58QxvOEQPoJ+ArqVnCxd/ PbDGRZk3ndSUuQWvY7GnZOg63yONTOrofsC6iIZYCHUsTQVlqxx6RNbDVNwcKRo7TBY3 5dBHABghOXe/lWsB6HVbCTp5ShyVEat6uQZ5kpo+BOrGOQLE/B/+Dow2jARzoWmSfp4i fijH2joZoX2m0bMs0ESI7HLyqVuV1UrXB8/R+EikhzhnNWKrGZNQov6I3FC4kbPElwv0 mJjw== X-Gm-Message-State: AOAM531SvnaU+LUBUkVJjBMz7ECo24B7HOM33Mw7ELuqWMSjJktnAD4L VXjUiqgztVTIub0KqaqIjHg= X-Google-Smtp-Source: ABdhPJyZC6JLpXw4HQLxJZzHjwMjhFyKzCz9yoYffhFiLRLv91f+zYp+k6S+jHtaEVcDsZtdvRU/CA== X-Received: by 2002:ac2:4da1:: with SMTP id h1mr6460486lfe.412.1606597894961; Sat, 28 Nov 2020 13:11:34 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id c17sm1471022ljn.10.2020.11.28.13.11.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Nov 2020 13:11:34 -0800 (PST) Date: Sun, 29 Nov 2020 00:11:32 +0300 From: Dmitry Kozlyuk To: Nick Connolly Cc: Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, David Marchand , stable@dpdk.org Message-ID: <20201129001132.2a387aab@sovereign> In-Reply-To: <20201127120711.15703-1-nick.connolly@mayadata.io> References: <20201127120711.15703-1-nick.connolly@mayadata.io> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal/windows: vfprintf build warning with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 27 Nov 2020 12:07:11 +0000, Nick Connolly wrote: > [...] > +#ifdef __clang__ > +#pragma clang diagnostic push > +#pragma clang diagnostic ignored "-Wformat-nonliteral" > +#endif > [...] How about a more safe approach? diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c index d5ff721e0..ebcd3474e 100644 --- a/lib/librte_eal/windows/eal_lcore.c +++ b/lib/librte_eal/windows/eal_lcore.c @@ -37,6 +37,7 @@ struct cpu_map { static struct cpu_map cpu_map = { 0 }; /* eal_create_cpu_map() is called before logging is initialized */ +__rte_format_printf(1, 2) static void log_early(const char *format, ...) {