DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 5/5] f_u32: fix compiler gcc-10 compiler warning
Date: Sun, 29 Nov 2020 09:54:37 -0800	[thread overview]
Message-ID: <20201129175437.15346-6-stephen@networkplumber.org> (raw)
In-Reply-To: <20201129175437.15346-1-stephen@networkplumber.org>

With gcc-10 it complains about array subscript error.

f_u32.c: In function ‘u32_parse_opt’:
f_u32.c:1113:24: warning: array subscript 0 is outside the bounds of an interior zero-length array ‘struct tc_u32_key[0]’ [-Wzero-length-bounds]
 1113 |    hash = sel2.sel.keys[0].val & sel2.sel.keys[0].mask;
      |           ~~~~~~~~~~~~~^~~
In file included from tc_util.h:11,
                 from f_u32.c:26:
../include/uapi/linux/pkt_cls.h:253:20: note: while referencing ‘keys’
  253 |  struct tc_u32_key keys[0];

This is because the keys are actually allocated in the second element
of the parent structure.

Simplest way to address the warning is to assign directly to the keys
in the containing structure.

This has always been in iproute2 (pre-git) so no Fixes.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
 tc/f_u32.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/f_u32.c b/tc/f_u32.c
index e0a322d5a11c..2ed5254a40d5 100644
--- a/tc/f_u32.c
+++ b/tc/f_u32.c
@@ -1110,7 +1110,7 @@ static int u32_parse_opt(struct filter_util *qu, char *handle,
-			hash = sel2.sel.keys[0].val & sel2.sel.keys[0].mask;
+			hash = sel2.keys[0].val & sel2.keys[0].mask;
 			hash ^= hash >> 16;
 			hash ^= hash >> 8;
 			htid = ((hash % divisor) << 12) | (htid & 0xFFF00000);

  parent reply	other threads:[~2020-11-29 17:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-29 17:54 [dpdk-dev] [PATCH iproute2 0/5] fix warnings from gcc-10 Stephen Hemminger
2020-11-29 17:54 ` [dpdk-dev] [PATCH 1/5] devlink: fix unitialized warning Stephen Hemminger
2020-11-29 17:54 ` [dpdk-dev] [PATCH 2/5] bridge: fix string length warning Stephen Hemminger
2020-11-29 17:54 ` [dpdk-dev] [PATCH 3/5] tc: fix compiler warnings in ip6 pedit Stephen Hemminger
2020-11-29 17:54 ` [dpdk-dev] [PATCH 4/5] misc: fix compiler warning in ifstat and nstat Stephen Hemminger
2020-11-29 17:54 ` Stephen Hemminger [this message]
2020-11-30  0:17 ` [dpdk-dev] [PATCH iproute2 0/5] fix warnings from gcc-10 Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129175437.15346-6-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).