DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] windows: build warnings with clang
Date: Sun, 29 Nov 2020 18:38:52 +0300
Message-ID: <20201129183852.44ce7e38@sovereign> (raw)
In-Reply-To: <20201127113623.26707-1-nick.connolly@mayadata.io>

On Fri, 27 Nov 2020 11:36:23 +0000, Nick Connolly wrote:
> Compiling with Clang (11.0, --buildtype=debug) for Windows
> produces deprecated warnings related to secure crt functions.

Please explain what these warnings mean and why disabling them is OK.
FWIW, I examined present warnings and found no useful ones. Also,
--buildtype=debug is not necessary to trigger these warnings.

Proposed wording (feel free to adjust):

	Microsoft CRT defines Windows-specific secure alternatives to
	standard library functions and triggers warnings when "insecure"
	functions are used [1]. However, calling code already has all
	necessary checks around those functions, so these warnings are not
	useful for DPDK. MinGW provides its own CRT without this issue.

[1]:
https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160

> Disable this by defining -D_CRT_SECURE_NO_WARNINGS.
> 
> It is unclear exactly which commit this fixes.  It is probably a
> consequence of building more libraries for Windows.

Tip: Unless you want to make this paragraph part of the commit, you can write
such notices below "---" line, like version info.

> 
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> ---
>  config/meson.build | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/config/meson.build b/config/meson.build
> index c02802c18..a3154e29c 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -279,6 +279,11 @@ if is_windows
>  		add_project_arguments('-D__USE_MINGW_ANSI_STDIO', language: 'c')
>  	endif
>  
> +	# Disable secure CRT deprecated warnings for clang
> +	if cc.get_id() == 'clang'
> +		add_project_arguments('-D_CRT_SECURE_NO_WARNINGS', language: 'c')
> +	endif
> +
>  	add_project_link_arguments('-lws2_32', language: 'c')
>  
>  	# Contrary to docs, VirtualAlloc2() is exported by mincore.lib


  reply	other threads:[~2020-11-29 15:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 11:36 Nick Connolly
2020-11-29 15:38 ` Dmitry Kozlyuk [this message]
2020-11-29 16:00 ` [dpdk-dev] [PATCH v2] " Nick Connolly
2020-12-03  0:02   ` Dmitry Kozlyuk
2020-12-07 20:34     ` Thomas Monjalon
2020-12-09  9:30       ` Nick Connolly
2020-12-05  0:46   ` Kadam, Pallavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201129183852.44ce7e38@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nick.connolly@mayadata.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git