From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE1D6A04DB; Mon, 30 Nov 2020 17:44:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 610DC4C99; Mon, 30 Nov 2020 17:44:09 +0100 (CET) Received: from mail-pj1-f67.google.com (mail-pj1-f67.google.com [209.85.216.67]) by dpdk.org (Postfix) with ESMTP id 473C537AF for ; Mon, 30 Nov 2020 17:44:06 +0100 (CET) Received: by mail-pj1-f67.google.com with SMTP id v1so1684222pjr.2 for ; Mon, 30 Nov 2020 08:44:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o5spbIcqcv2/rzpjvn2+TE1tQoS1RZrtFBgsVN6Q9aA=; b=GQ3fJULyGNu94Pf7IvE80yS3TwGmWdVMXRFu84P+mMAuEf8i51IopXMCZx+YewHR/H HUQgTFrZ0wZq+AWZ1Ys6MNtm2Zjc8eEo1CAFASK2zSyow0VS8dQ1aeJ8zxx1ZdTsQyrt nqeLN4VvupdiQKmOw4bSRcKYqu/czqA1HfvUidJhaLtsYKqZ6Mbv9wue5E4CVMYqFMpG RqjnMP2bY/WzyQ1dTpJ+Sxf+mzolt+7yHEFFbMejZ7KiMrA//G576ptY3tHSXluq8p4K jOkpGLRVQ+o5+gcGnssS+A2XVmMmJ7/8XCW1ifPcW4p56reRhUB1K5RNHKIw+IFVkm5y AoQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o5spbIcqcv2/rzpjvn2+TE1tQoS1RZrtFBgsVN6Q9aA=; b=gGCEgFW/iFH9q8NhAS+sVEhjmahpaERoUk/ggjIOYdipiUOeYX1EOqKTujXwQT434+ x42ynRpcn7rCu177vw8d76i4Gy8UqtdKi4+TOFJqt7gxZTuPyst0uqLd6c7Fe+Aca3t4 1MAxGG7laYJwonW4utmHBY+h4fFvjqq6b9DTa+cOPCdzB4mN5eanKCez12GJ0OzIJ4P0 W0Nur7qQFn3kq3/ggvszOtQ96ullZfSJVKqRVNGdruVerQFQti4pWNbfbVOc/WzkPmbc 3DTfSkXbyYn+LBxvHjnE8kWy1DJ49ynv4VLn/a8qNatDfaFOPnNT3dLZNUyj/oBsJ+9R YmfQ== X-Gm-Message-State: AOAM532e5E8nB2+N2BcCUfZyc6KjpppER2g03hYxdKPUnDjDhbqgQTX0 qKGJ8oxwuzSrjnn84IpRzjXG6Q== X-Google-Smtp-Source: ABdhPJxvAU+S+sMlv3Ao0iuE9XLPF48MM6inwHIKI9ruhL0sDZ/Bm4NW/whUZJ2sU1ReL2SRNN+H1g== X-Received: by 2002:a17:90b:1886:: with SMTP id mn6mr18487652pjb.31.1606754644344; Mon, 30 Nov 2020 08:44:04 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id b4sm6815069pju.33.2020.11.30.08.44.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 08:44:04 -0800 (PST) Date: Mon, 30 Nov 2020 08:43:48 -0800 From: Stephen Hemminger To: Sarosh Arif Cc: sthemmin@microsoft.com, dev@dpdk.org Message-ID: <20201130084348.3b950879@hermes.local> In-Reply-To: <20201130124533.23341-1-sarosh.arif@emumba.com> References: <20201130124533.23341-1-sarosh.arif@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] usertools: show an error message if unable to reserve requested hugepages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 30 Nov 2020 17:45:33 +0500 Sarosh Arif wrote: > Sometimes the system is unable to reserve the requested hugepages because > enough space is not available in the RAM. In that case, currently the > script displays no error message hence the user can be under the delusion > that the hugepages he requested are all successfully reserved. This patch > displays an error message if the pages reserved are different from the > requested pages and shows the actual pages reserved. > > Signed-off-by: Sarosh Arif This is ok, but this code was written to go through python lint cleanly. This patch introduces new warnings: usertools/dpdk-hugepages.py:239:4: W0601: Global variable 'args' undefined at the module level (global-variable-undefined) usertools/dpdk-hugepages.py:239:4: C0103: Constant name "args" doesn't conform to UPPER_CASE naming style (invalid-name)