From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61A8CA04DB; Tue, 1 Dec 2020 10:38:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03F80C980; Tue, 1 Dec 2020 10:38:09 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6FA80C954 for ; Tue, 1 Dec 2020 10:38:06 +0100 (CET) IronPort-SDR: Ci60dxAX8ODK56Y/SrOITS4bolqcpkAQeYWnPd9WSn0g6Z40e/6uKxgNp+09z4d+c1IrxkbB2J YeYOR5ykvo1g== X-IronPort-AV: E=McAfee;i="6000,8403,9821"; a="152051747" X-IronPort-AV: E=Sophos;i="5.78,384,1599548400"; d="scan'208";a="152051747" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 01:38:01 -0800 IronPort-SDR: zyjx6VIIPM/nx7nJFKCJdm7pakk+HhZ6RINJ9oRBhD99rYgw7DWuyjYx4osVvb5UTFO8H9HsQJ FqfAaGh0Bf3Q== X-IronPort-AV: E=Sophos;i="5.78,384,1599548400"; d="scan'208";a="538952982" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.22.211]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 01 Dec 2020 01:37:58 -0800 Date: Tue, 1 Dec 2020 09:37:55 +0000 From: Bruce Richardson To: Hideyuki Yamashita Cc: dpdk-dev Message-ID: <20201201091653.GA1257@bricha3-MOBL.ger.corp.intel.com> References: <20201201094035.EC0A.17218CA3@ntt-tx.co.jp_1> <20201201140126.EC13.17218CA3@ntt-tx.co.jp_1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201201140126.EC13.17218CA3@ntt-tx.co.jp_1> Subject: Re: [dpdk-dev] Basic question about where to write config for optional feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Dec 01, 2020 at 02:01:26PM +0900, Hideyuki Yamashita wrote: > Hello, > > I am planning to propose patch for > optional feature. > > Question: > Where should I write compile switch for > optional features? > > I was planning to add flag to enable > optional festures into config/common_base > like following: > > +# > +# Compile the api statistics library > +# > +CONFIG_RTE_LIBRTE_APISTATS=n > > But make build system was gone. > I know that meson system is there instead of make. > We are really trying to move away from build-time config. Instead, please look to make this a runtime option. Thanks, /Bruce