DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dev@dpdk.org, David Marchand <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang
Date: Thu, 3 Dec 2020 03:02:15 +0300	[thread overview]
Message-ID: <20201203030215.0e7c6fce@sovereign> (raw)
In-Reply-To: <20201129160024.879-1-nick.connolly@mayadata.io>

On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote:
> Microsoft CRT defines Windows-specific secure alternatives to
> standard library functions and triggers warnings when "insecure"
> functions are used [1]. However, calling code already has all
> necessary checks around those functions, so these warnings are not
> useful for DPDK. MinGW provides its own CRT without this issue.
> [1]:
> https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160
> Disable this by defining -D_CRT_SECURE_NO_WARNINGS.
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> ---
> v2:
> * Adjust commit wording as per Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> Note: It is unclear exactly which commit this fixes.  It is probably a
> consequence of building more libraries for Windows.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

  reply	other threads:[~2020-12-03  0:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 11:36 [dpdk-dev] [PATCH] " Nick Connolly
2020-11-29 15:38 ` Dmitry Kozlyuk
2020-11-29 16:00 ` [dpdk-dev] [PATCH v2] " Nick Connolly
2020-12-03  0:02   ` Dmitry Kozlyuk [this message]
2020-12-07 20:34     ` Thomas Monjalon
2020-12-09  9:30       ` Nick Connolly
2021-12-12 12:06         ` Xueming(Steven) Li
2020-12-05  0:46   ` Kadam, Pallavi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203030215.0e7c6fce@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=nick.connolly@mayadata.io \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).