From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 532ABA09DF; Thu, 3 Dec 2020 01:02:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8BEDEC9C2; Thu, 3 Dec 2020 01:02:19 +0100 (CET) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by dpdk.org (Postfix) with ESMTP id ADCD8C9BE for ; Thu, 3 Dec 2020 01:02:17 +0100 (CET) Received: by mail-lf1-f66.google.com with SMTP id d20so56223lfe.11 for ; Wed, 02 Dec 2020 16:02:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vQcNX5bin4MpSL3LOofTSashL9eRINlxEQrsjgkkzXI=; b=YSrMD+6cXq+j8fGkXs+rM+6zwAfVukiqh03z36TmqrYT5LXrv12nrAu0QJK7uT4h4Z vJ0+kDyGgkN0NN1/OTcGvVUNTViSFX1jgi4KR3XP4I34a+ydrt9hdG8U9qd+NuBtb0zW 7Cs6AvkBsRNhfk9J7OGwEkJFYmJ0Y+dz/9HtuMFUK5X/jrAhF0fXPa+rAjr+U3JPf5wR THYxDyxM4ArFNVQCCAPJGwt/tekEhE8/vZEMOkrnjYsE7Qzgjgx1VFkWS0AWEzddUi/n HKTzHKlR/983TlSMnKCeGuveKXJh5rC65GhgH6aZtQ9CdygQ2RdE1Zo64cuONy1ohwxF 0L5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vQcNX5bin4MpSL3LOofTSashL9eRINlxEQrsjgkkzXI=; b=kptQ3lm/lAkQ35wMztK2TrusBXvmeaW++tbrKKcd1LJx2WzyaBiHVENoS2I1a3g2uE MB4WFP9Ogjuarkg89YiVEF2JWeZBao646LnvWXxMvbKpE1SONmkBYu40Y8XUsVrt3cr+ JOb6cYXP6wh5UeF4IoRBSe+jYbZrcmO+5aXV9lFJn83bztNbTMrw2VSlVc/k3tc4+nnU ylGtXqdr6+K9Zo2PnD4qlVpcgGqeAsho8k8OpEbZNv156ssSuWyMohy2sOBrnpEFsMLW 2srG7zikPg+HWgyalquHYMlDcIr+UOsCy8RNCXP3P+7nYNIsBjlCgp509nH+f4FaTVom G6iw== X-Gm-Message-State: AOAM532qx7+B+Yg+w/qoewpToxt6U0dusLkzolp+Sbe1c+9WpA0f4Mkz RqHUesYpQHSsq66GYDbLojo= X-Google-Smtp-Source: ABdhPJzAQ3lk5qn2zekYaLRpHGhVOp4Jra08/Vun8GDdj+VpvtbAJS3P2vf+BUIVgM33X1LAiRH3Fw== X-Received: by 2002:a19:ac9:: with SMTP id 192mr213594lfk.342.1606953737317; Wed, 02 Dec 2020 16:02:17 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id v4sm51225lji.114.2020.12.02.16.02.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 16:02:16 -0800 (PST) Date: Thu, 3 Dec 2020 03:02:15 +0300 From: Dmitry Kozlyuk To: Nick Connolly Cc: Bruce Richardson , dev@dpdk.org, David Marchand Message-ID: <20201203030215.0e7c6fce@sovereign> In-Reply-To: <20201129160024.879-1-nick.connolly@mayadata.io> References: <20201127113623.26707-1-nick.connolly@mayadata.io> <20201129160024.879-1-nick.connolly@mayadata.io> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] windows: build warnings with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, 29 Nov 2020 16:00:24 +0000, Nick Connolly wrote: > Microsoft CRT defines Windows-specific secure alternatives to > standard library functions and triggers warnings when "insecure" > functions are used [1]. However, calling code already has all > necessary checks around those functions, so these warnings are not > useful for DPDK. MinGW provides its own CRT without this issue. > > [1]: > https://docs.microsoft.com/en-us/cpp/c-runtime-library/security-features-in-the-crt?view=msvc-160 > > Disable this by defining -D_CRT_SECURE_NO_WARNINGS. > > Signed-off-by: Nick Connolly > --- > v2: > * Adjust commit wording as per Dmitry Kozlyuk > > Note: It is unclear exactly which commit this fixes. It is probably a > consequence of building more libraries for Windows. Acked-by: Dmitry Kozlyuk