From: George Prekas <prekageo@amazon.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: <dev@dpdk.org>, George Prekas <prekageo@amazon.com>
Subject: [dpdk-dev] [PATCH] app/testpmd: fix IP checksum calculation
Date: Thu, 3 Dec 2020 07:59:54 -0600 [thread overview]
Message-ID: <20201203135954.1127-1-prekageo@amazon.com> (raw)
Insert a compiler barrier to make sure that the IP checksum calculation
happens after setting all the fields of the IP header.
Signed-off-by: George Prekas <prekageo@amazon.com>
---
app/test-pmd/flowgen.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/flowgen.c b/app/test-pmd/flowgen.c
index acf3e2460..893b4b0b8 100644
--- a/app/test-pmd/flowgen.c
+++ b/app/test-pmd/flowgen.c
@@ -150,6 +150,7 @@ pkt_burst_flow_gen(struct fwd_stream *fs)
next_flow);
ip_hdr->total_length = RTE_CPU_TO_BE_16(pkt_size -
sizeof(*eth_hdr));
+ rte_compiler_barrier();
ip_hdr->hdr_checksum = ip_sum((unaligned_uint16_t *)ip_hdr,
sizeof(*ip_hdr));
--
2.17.1
next reply other threads:[~2020-12-03 14:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 13:59 George Prekas [this message]
2020-12-03 16:08 ` Stephen Hemminger
2020-12-03 16:35 ` George Prekas
2020-12-03 18:33 ` Stephen Hemminger
2020-12-04 8:59 ` Ferruh Yigit
2020-12-05 5:47 ` George Prekas
2020-12-05 5:42 ` [dpdk-dev] [PATCH v2] " George Prekas
2021-01-05 16:26 ` George Prekas
2021-01-06 18:02 ` Ferruh Yigit
2021-01-07 5:25 ` Stephen Hemminger
2021-01-07 5:39 ` George Prekas
2021-01-07 11:32 ` Ferruh Yigit
2021-01-07 13:06 ` Ferruh Yigit
2021-01-07 14:20 ` George Prekas
2021-01-07 15:22 ` Ferruh Yigit
2021-01-07 20:45 ` George Prekas
2021-01-07 15:50 ` Stephen Hemminger
2021-01-07 15:59 ` Ferruh Yigit
2021-01-07 16:29 ` Stephen Hemminger
2021-01-07 20:42 ` [dpdk-dev] [PATCH v3] " George Prekas
2021-01-18 15:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203135954.1127-1-prekageo@amazon.com \
--to=prekageo@amazon.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).