From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3AC5A09E3; Fri, 4 Dec 2020 23:31:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 471C334F3; Fri, 4 Dec 2020 23:31:33 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D41C3322C for ; Fri, 4 Dec 2020 23:31:31 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id t8so4744704pfg.8 for ; Fri, 04 Dec 2020 14:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gMtwlvnmXX4AWR5OxBpPOudijVIVR39MV+aXV9ZtMGQ=; b=k+fSPUEVgXMIPm8zMDPoAs1kiXCX7Gb3vdxAW+yuS5Bw0No1dOvgSA3zhBPSaokNMH CM7Gi1VgNlSV9A7TbiD/UYK+s/GPmWQdRpRFDxY+ATg7xNDX6N9adrLC0xkBdS1a2lMu 2SF5k82JMTHERV2ksbEhC/DOhL2pDXXJPja8bq0DCGjtxYL3RB2EmQXkpZnJjyYHmZbH d0CZ1SXiRwAEZFJn8UJ0MMXubxF5VtQyzToKsMK8nLkjJ1QAb+UCrEUV/HI7wg8h3ZER aonQl9RCaEPy6vhQip7eZ+LOpIv9FEgDAgNaD80piT+ucKE0ZuXfLRZobNteaoPr38b1 5n0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gMtwlvnmXX4AWR5OxBpPOudijVIVR39MV+aXV9ZtMGQ=; b=Oz041xawu9LNlb4H+XycO6DAo+ysPecd1hXUUoR6dlJ4H6YpdATCAANdISqeyusDK3 CUJG0RNHE0TlBJYO3b4d7B+L4fi1tmXRt32aG2RPVTra5taTArKRCGHjeaeHFmqvKAsC GnsF6ePFgS1gB2HB5W1zMtUI/fwr7x9sI/JhDtC9vbEXuJySrxmNsP4E5DddoQSbiDNL VAheE4bYrifhMLC8jU8hisZ6r7MB5xV709pLXdz501SBU3hOzMNb8KFBldB5xKUnCcfZ yDzkRV9ETBHZ4uRKXU7wLEZBWnS3f+9dfXlvM0yha0qDG2gIg+49DTotvaZcPsNXS5iw MnCQ== X-Gm-Message-State: AOAM5318Dw355xKEdh0V7Z4KNFVDkXhcNhJd3wPijp970V4YQ4izrM+l ugb43BHaTzJW6DyaIU7qcbwHjQ== X-Google-Smtp-Source: ABdhPJwE3G9y9ia/ReF91DNSqCARQIBF1FsTZgORm/PhvkuMTcXQAoNF2PgVMo1r8lu06+rmyh/yAQ== X-Received: by 2002:a63:5126:: with SMTP id f38mr9112192pgb.11.1607121089603; Fri, 04 Dec 2020 14:31:29 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id gj15sm3117426pjb.9.2020.12.04.14.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 14:31:28 -0800 (PST) Date: Fri, 4 Dec 2020 14:31:20 -0800 From: Stephen Hemminger To: Ed Czeck Cc: dev@dpdk.org, ferruh.yigit@intel.com, thomas@monjalon.net, shepard.siegel@atomicrules.com, john.miller@atomicrules.com Message-ID: <20201204143120.5c488d36@hermes.local> In-Reply-To: <20201204202745.24675-1-ed.czeck@atomicrules.com> References: <20201204202745.24675-1-ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ark: export ark timestamp dynfield offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 4 Dec 2020 15:27:45 -0500 Ed Czeck wrote: > Access to mbuf dynfields in application code requires variable > export through header and dynamic library. > > Fixes: a926951a606f ("net/ark: switch Rx timestamp to dynamic mbuf field") > Cc: thomas@monjalon.net > > Signed-off-by: Ed Czeck Not happy with having offsets exposed from driver. Expopsing weird offsets for their special fields is worse than the old model. Why not use standardized field name and have the application lookup that? There is an API already for that.