From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E212A09E3; Fri, 4 Dec 2020 21:19:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0B5DC9EE; Fri, 4 Dec 2020 21:17:48 +0100 (CET) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 039FCC9EE for ; Fri, 4 Dec 2020 21:17:47 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id y10so2297383plr.10 for ; Fri, 04 Dec 2020 12:17:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=qmxIh6cdNdLLa2XdNRfpBmQWwzN+8fOiAnW4//T+ShM=; b=iyREqoT0bdyotRKsYXf5mSnPCs9peRJu7AtiZi+nvRqqHxIoeCdOZBYFzFOOkr+kxR FKpNpM0M53IyCQsoo1/vD3uYoZVoz4Ug63UDvOtgZgZXViAYSal4vQ7QNUIkt1qG1ZNU h1NdIhSuHSNRFAuBJmzfH0IFIajOMC7FZ9wE7t7FiLS6jFmAHAWvgkxT6AuDNFIjz+U1 Fu/dBjD9cfJKXqkOaZjE4DO/beEOXmY5WXN/BzmTzS5+veWQK3LedL+vaQq35iLx+KOD Am8js4HdyZm0eZDlx6W1YHpPYuf80G4udKrh5SnZplWkQfJCk38TPSeK8JXvovBArvpJ QZTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=qmxIh6cdNdLLa2XdNRfpBmQWwzN+8fOiAnW4//T+ShM=; b=gLN5beMEyPFkmsnXslq9gv/TvxL52wG0SkTXmOLHSo5tot8tPdw5Ah6wIzYGQf5Mb5 J7xXaC6O2dCgkfd29PFgq1+rtELkheiluiKLl30ALO3fm6WYXoHzMDfc3/B6tXZKUY7j o1ZR6vcHFH/4qt3WIr/OmwiWHHuo8ULs/HpQVaxzKuV2oqP5jIZO8bTSjmqu2DXOpDHv m9L9jGvWSCTIQ+uPqS9se8eobgB/ohgg9Cbodqid1SLc6uFPxNTLbINtdFfprw/hmjlK /M4/r4INhBmID9cTuzCZO71S2Cvom0ihQ7PbbRIfiOtWAkwW/7i07htXm83gKd/Ji9OS KT5g== X-Gm-Message-State: AOAM530AtWVtIvpjSd88UbLrI9Zp1iS5bcyCyS1lK9wFGKTnKN+Zi3FI RtvoBWZfYMyiSSHismuPFQVRncUZ6wxUfw== X-Google-Smtp-Source: ABdhPJwH3P7stvxS/1XL3EvPLWCX54R/B7cfK1dG6VZ5WONTkt7/4mnMyAldJdBQwh74eSWPj5rWEw== X-Received: by 2002:a17:902:8698:b029:da:1d7a:f5ef with SMTP id g24-20020a1709028698b02900da1d7af5efmr5133529plo.67.1607113065996; Fri, 04 Dec 2020 12:17:45 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id z20sm2911805pjq.16.2020.12.04.12.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Dec 2020 12:17:45 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Fri, 4 Dec 2020 12:16:43 -0800 Message-Id: <20201204201646.51746-7-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201204201646.51746-1-aboyer@pensando.io> References: <20201204201646.51746-1-aboyer@pensando.io> In-Reply-To: <20201203203418.15064-1-aboyer@pensando.io> References: <20201203203418.15064-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH v3 6/9] net/ionic: convert 'deferred' boolean to a flag bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index bc15d75fd..2e33fb8d9 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1590,7 +1590,7 @@ ionic_lif_start(struct ionic_lif *lif) for (i = 0; i < lif->nrxqcqs; i++) { struct ionic_qcq *rxq = lif->rxqcqs[i]; - if (!rxq->deferred_start) { + if (!(rxq->flags & IONIC_QCQ_F_DEFERRED)) { err = ionic_dev_rx_queue_start(lif->eth_dev, i); if (err) @@ -1600,7 +1600,7 @@ ionic_lif_start(struct ionic_lif *lif) for (i = 0; i < lif->ntxqcqs; i++) { struct ionic_qcq *txq = lif->txqcqs[i]; - if (!txq->deferred_start) { + if (!(txq->flags & IONIC_QCQ_F_DEFERRED)) { err = ionic_dev_tx_queue_start(lif->eth_dev, i); if (err) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h index 4e091719f..8e2b42443 100644 --- a/drivers/net/ionic/ionic_lif.h +++ b/drivers/net/ionic/ionic_lif.h @@ -50,6 +50,7 @@ struct ionic_rx_stats { #define IONIC_QCQ_F_SG BIT(1) #define IONIC_QCQ_F_INTR BIT(2) #define IONIC_QCQ_F_NOTIFYQ BIT(3) +#define IONIC_QCQ_F_DEFERRED BIT(4) /* Queue / Completion Queue */ struct ionic_qcq { @@ -68,7 +69,6 @@ struct ionic_qcq { uint32_t total_size; uint32_t flags; struct ionic_intr_info intr; - bool deferred_start; }; #define IONIC_Q_TO_QCQ(q) container_of(q, struct ionic_qcq, q) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 2592f5cab..b953aff49 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -64,7 +64,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->nb_desc = q->num_descs; qinfo->conf.offloads = txq->offloads; - qinfo->conf.tx_deferred_start = txq->deferred_start; + qinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED; } static inline void __rte_cold @@ -196,7 +196,8 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id, } /* Do not start queue with rte_eth_dev_start() */ - txq->deferred_start = tx_conf->tx_deferred_start; + if (tx_conf->tx_deferred_start) + txq->flags |= IONIC_QCQ_F_DEFERRED; txq->offloads = offloads; @@ -605,7 +606,7 @@ ionic_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->mp = rxq->mb_pool; qinfo->scattered_rx = dev->data->scattered_rx; qinfo->nb_desc = q->num_descs; - qinfo->conf.rx_deferred_start = rxq->deferred_start; + qinfo->conf.rx_deferred_start = rxq->flags & IONIC_QCQ_F_DEFERRED; qinfo->conf.offloads = rxq->offloads; } @@ -703,7 +704,8 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev, */ /* Do not start queue with rte_eth_dev_start() */ - rxq->deferred_start = rx_conf->rx_deferred_start; + if (rx_conf->rx_deferred_start) + rxq->flags |= IONIC_QCQ_F_DEFERRED; rxq->offloads = offloads; -- 2.17.1