From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C8490A09E4;
	Sat,  5 Dec 2020 06:43:08 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 300932E81;
	Sat,  5 Dec 2020 06:43:07 +0100 (CET)
Received: from smtp-fw-9102.amazon.com (smtp-fw-9102.amazon.com
 [207.171.184.29]) by dpdk.org (Postfix) with ESMTP id 4A9542C6E
 for <dev@dpdk.org>; Sat,  5 Dec 2020 06:43:06 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;
 t=1607146987; x=1638682987;
 h=from:to:cc:subject:date:message-id:in-reply-to:
 references:mime-version;
 bh=x/GVLiMoAGfAhUzWttstnFKM4KoWvWAlW88MmWeYc8k=;
 b=Gg0g8RiNIhPmw8lgugbKMwEIi688uyjghbCl/HjijgHa39pmQBaUjaUO
 nBbILDP59/0TuYaexKAJTMa0wvew6e54Ty0spIrZuGgAE7+V2LPuup613
 dgNrm3JLyb3DAMstTsOAL2Eev3yl7Zxfk735bG1cfcuUmxNZn1Xdzb4MO U=;
X-IronPort-AV: E=Sophos;i="5.78,394,1599523200"; d="scan'208";a="101942338"
Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO
 email-inbound-relay-1e-c7f73527.us-east-1.amazon.com) ([10.47.23.38])
 by smtp-border-fw-out-9102.sea19.amazon.com with ESMTP;
 05 Dec 2020 05:42:58 +0000
Received: from EX13MTAUWB001.ant.amazon.com
 (iad12-ws-svc-p26-lb9-vlan3.iad.amazon.com [10.40.163.38])
 by email-inbound-relay-1e-c7f73527.us-east-1.amazon.com (Postfix) with ESMTPS
 id 269C5E195A; Sat,  5 Dec 2020 05:42:55 +0000 (UTC)
Received: from EX13D12UWC001.ant.amazon.com (10.43.162.78) by
 EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS)
 id 15.0.1497.2; Sat, 5 Dec 2020 05:42:55 +0000
Received: from AUS-1800118119.amazon.com (10.43.161.102) by
 EX13D12UWC001.ant.amazon.com (10.43.162.78) with Microsoft SMTP Server (TLS)
 id 15.0.1497.2; Sat, 5 Dec 2020 05:42:54 +0000
From: George Prekas <prekageo@amazon.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>
CC: <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>, "Ferruh
 Yigit" <ferruh.yigit@intel.com>, George Prekas <prekageo@amazon.com>
Date: Fri, 4 Dec 2020 23:42:38 -0600
Message-ID: <20201205054238.12469-1-prekageo@amazon.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201203135954.1127-1-prekageo@amazon.com>
References: <20201203135954.1127-1-prekageo@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [10.43.161.102]
X-ClientProxiedBy: EX13D40UWC004.ant.amazon.com (10.43.162.175) To
 EX13D12UWC001.ant.amazon.com (10.43.162.78)
Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix IP checksum calculation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Strict-aliasing rules are violated by cast to uint16_t* in flowgen.c
and the calculated IP checksum is wrong on GCC 9 and GCC 10.

Signed-off-by: George Prekas <prekageo@amazon.com>
---
v2:
* Instead of a compiler barrier, use a compiler flag.
---
 app/test-pmd/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build
index 7e9c7bdd6..5d24e807f 100644
--- a/app/test-pmd/meson.build
+++ b/app/test-pmd/meson.build
@@ -4,6 +4,7 @@
 # override default name to drop the hyphen
 name = 'testpmd'
 cflags += '-Wno-deprecated-declarations'
+cflags += '-fno-strict-aliasing'
 sources = files('5tswap.c',
 	'cmdline.c',
 	'cmdline_flow.c',
-- 
2.17.1