From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 093C9A04E6; Mon, 7 Dec 2020 18:33:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A913CC8CC; Mon, 7 Dec 2020 18:33:37 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 33449CF3 for ; Mon, 7 Dec 2020 18:33:36 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DA7A15C0246; Mon, 7 Dec 2020 12:33:34 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 07 Dec 2020 12:33:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; s=fm2; bh=xdTprw8kxN00kKO46rnVtsIavd IEKRErcLhiHGqnS3g=; b=QgrrEt3IXw0m41AjbCqYLn4E3ydaTPq9UC9F6rjH+u bL4mW+85Xl1R24YyyEFzrRHFwpho1ZPkzHjNxFuciAkgHcf2DdidjV2PSS7CUlCq x3dJEn9CqlkmWi4vSuBaqxM6YLl0/k6G8dl6wyY9d3o4L5Wm88zOpL3h/a6Ldh+p zRty5BDjdj34+Bf3lHrXcRadJcaJaADkwyytIFmv2A2fTVWiGz9hrmIE6MfMhceo cdl4yLoINQKjqb/7kkjWU3bZoIWlIMJwN1PLljEljx4VTVQpB6qH/FWKB5WReStW LJcu6apH6Q/PRIrCdp9pm5zIc1UukwLwh8W3XhmHI2sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :message-id:mime-version:subject:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=xdTprw8kxN00kKO46 rnVtsIavdIEKRErcLhiHGqnS3g=; b=WbthiQ7sKAFGdMG7VaMq5BtRyDr5eBndP NdPygiEW4WSoKd47su/ucvl5hlNYRSwggXRJxEIna5ykpJKiwrmN5qg0CcZlL5+P bb0UfgPrFMoRO+1NMFXc9yhy9kbnK99nsZfa2QsflMjaFa1KpR2R8mFt4stw048d xWwRNsugMDsnmzgGjEOBhQ1Q5zLoMvaZjB/oM2hzH1EbW6g/kiRQoH9dRB9u/vCo euGN5zGdkm2lNoJhBGk8E5o6XPtKiaLCjKjFZ6QWO6WJe0Sqg2efsAK23CuzXUs4 y2KHHoUZCZwTe71Ph04ckn+SzDCAhTcL5PNQYb1IJoKVXOxbNISGA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejgedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdelvdduhedvudduveeuvd evheegudelgeeigfejheduhedttdegudffjeeihffgnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E23B240065; Mon, 7 Dec 2020 12:33:34 -0500 (EST) From: Thomas Monjalon To: dev@dpdk.org Cc: david.marchand@redhat.com, bruce.richardson@intel.com Date: Mon, 7 Dec 2020 18:33:19 +0100 Message-Id: <20201207173319.1397740-1-thomas@monjalon.net> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH 1/1] devtools: avoid installing static binaries X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When testing compilation and checking ABI compatibility, there is no real need of static binaries eating disks. The static linkage of applications are tested with GCC and Clang, plus some examples are statically linked. The after-installation build test is limited to "helloworld" example. Note the meson static build test was already limited to "l3fwd" example. The ABI compatibility is checked on shared libraries, so no need running this test a second time on builds intended for static linking. However, limiting ABI check to "shared builds" means all test cases must have a "shared build" occurence. As a consequence the 32-bit build test is switched to shared linking. Signed-off-by: Thomas Monjalon --- devtools/test-meson-builds.sh | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 7280b7a93d..ed44d4ffb1 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -166,6 +166,9 @@ build () # config $srcdir $builds_dir/$targetdir $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" ]; then + if echo $* | grep -qw -- '--default-library=static' ; then + return # skip ABI check for static build + fi abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION if [ ! -d $abirefdir/$targetdir ]; then # clone current sources @@ -230,7 +233,7 @@ if check_cc_flags '-m32' ; then export PKG_CONFIG_LIBDIR='/usr/lib/pkgconfig' fi target_override='i386-pc-linux-gnu' - build build-32b cc -Dc_args='-m32' -Dc_link_args='-m32' + build build-32b cc -Dc_args='-m32' -Dc_link_args='-m32' $use_shared target_override= unset PKG_CONFIG_LIBDIR fi @@ -274,7 +277,8 @@ if pkg-config --define-prefix libdpdk >/dev/null 2>&1; then export PKGCONF="pkg-config --define-prefix" for example in $examples; do echo "## Building $example" + [ $example = helloworld ] && static=static || static= # save disk space $MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example \ - clean shared static >&$veryverbose + clean shared $static >&$veryverbose done fi -- 2.29.2