* [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
@ 2020-12-08 8:02 banxiaozhen, benhaz1024
0 siblings, 0 replies; 6+ messages in thread
From: banxiaozhen, benhaz1024 @ 2020-12-08 8:02 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, banxiaozhen
From: banxiaozhen <benhaz1024@gmail.com>
Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 647aa8d99..8695426c2 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
default:
PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
filter_type);
+ ret = -EINVAL;
break;
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
@ 2020-12-08 11:05 ` Wang, Haiyue
1 sibling, 0 replies; 6+ messages in thread
From: Wang, Haiyue @ 2020-12-08 11:05 UTC (permalink / raw)
To: haz ben; +Cc: Guo, Jia, dev
From: haz ben <benhaz1024@gmail.com>
Sent: Tuesday, December 8, 2020 17:58
To: Wang, Haiyue <haiyue.wang@intel.com>
Cc: ban, xiaozhen <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
my name is ban, xiaozhen.
the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add?
http://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line
1.
./devtools/checkpatches.sh -n1
### net/e1000: fix incorrect return value if filter type not supported.
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
total: 0 errors, 1 warnings, 0 checks, 7 lines checked
0/1 valid patch
2.
./devtools/check-git-log.sh -1
Wrong headline format:
net/e1000: fix incorrect return value if filter type not supported.
Headline too long:
net/e1000: fix incorrect return value if filter type not supported.
Missing 'Fixes' tag:
net/e1000: fix incorrect return value if filter type not supported.
Invalid patch(es) found - checked 1 patch
3. Please configure your mail system with plain text, not in rich text.
Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>> 于2020年12月8日周二 下午5:04写道：
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com> <banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com<mailto:jia.guo@intel.com>>; Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
The patch looks good.
The name format should be like "Banxiao Zhen", and the commit message is empty ?
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
> --
> 2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 9:58 ` haz ben
@ 2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
1 sibling, 0 replies; 6+ messages in thread
From: Wang, Haiyue @ 2020-12-08 10:40 UTC (permalink / raw)
To: haz ben; +Cc: Guo, Jia, dev
From: haz ben <benhaz1024@gmail.com>
Sent: Tuesday, December 8, 2020 17:58
To: Wang, Haiyue <haiyue.wang@intel.com>
Cc: ban, xiaozhen <benhaz1024@gmail.com>; Guo, Jia <jia.guo@intel.com>; dev@dpdk.org
Subject: Re: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
my name is ban, xiaozhen.
OK, ;-)
the commit message is "net/e1000: fix incorrect return value if filter type not supported." does additional details should be add?
It is not about additional, it is better for title + more descriptive message.
Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>> 于2020年12月8日周二 下午5:04写道：
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com> <banxiaozhen benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com<mailto:jia.guo@intel.com>>; Wang, Haiyue <haiyue.wang@intel.com<mailto:haiyue.wang@intel.com>>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com<mailto:benhaz1024@gmail.com>>
The patch looks good.
The name format should be like "Banxiao Zhen", and the commit message is empty ?
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
> --
> 2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 9:04 ` Wang, Haiyue
@ 2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
0 siblings, 2 replies; 6+ messages in thread
From: haz ben @ 2020-12-08 9:58 UTC (permalink / raw)
To: Wang, Haiyue; +Cc: ban, xiaozhen, Guo, Jia, dev
my name is ban, xiaozhen.
the commit message is "net/e1000: fix incorrect return value if filter type
not supported." does additional details should be add?
Wang, Haiyue <haiyue.wang@intel.com> 于2020年12月8日周二 下午5:04写道：
> > -----Original Message-----
> > From: banxiaozhen benhaz1024@gmail.com <banxiaozhen benhaz1024@gmail.com
> >
> > Sent: Tuesday, December 8, 2020 16:10
> > To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; banxiaozhen <benhaz1024@gmail.com>
> > Subject: [PATCH] net/e1000: fix incorrect return value if filter type
> not supported.
> >
> > From: banxiaozhen <benhaz1024@gmail.com>
> >
> > Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
>
> The patch looks good.
>
> The name format should be like "Banxiao Zhen", and the commit message is
> empty ?
>
> > ---
> > drivers/net/e1000/igb_ethdev.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/e1000/igb_ethdev.c
> b/drivers/net/e1000/igb_ethdev.c
> > index 647aa8d99..8695426c2 100644
> > --- a/drivers/net/e1000/igb_ethdev.c
> > +++ b/drivers/net/e1000/igb_ethdev.c
> > @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev
> __rte_unused,
> > default:
> > PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> > filter_type);
> > + ret = -EINVAL;
> > break;
> > }
> >
> > --
> > 2.24.3 (Apple Git-128)
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
2020-12-08 8:10 banxiaozhen, benhaz1024
@ 2020-12-08 9:04 ` Wang, Haiyue
2020-12-08 9:58 ` haz ben
0 siblings, 1 reply; 6+ messages in thread
From: Wang, Haiyue @ 2020-12-08 9:04 UTC (permalink / raw)
To: banxiaozhen benhaz1024@gmail.com, Guo, Jia; +Cc: dev, banxiaozhen
> -----Original Message-----
> From: banxiaozhen benhaz1024@gmail.com <banxiaozhen benhaz1024@gmail.com>
> Sent: Tuesday, December 8, 2020 16:10
> To: Guo, Jia <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; banxiaozhen <benhaz1024@gmail.com>
> Subject: [PATCH] net/e1000: fix incorrect return value if filter type not supported.
>
> From: banxiaozhen <benhaz1024@gmail.com>
>
> Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
The patch looks good.
The name format should be like "Banxiao Zhen", and the commit message is empty ?
> ---
> drivers/net/e1000/igb_ethdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
> index 647aa8d99..8695426c2 100644
> --- a/drivers/net/e1000/igb_ethdev.c
> +++ b/drivers/net/e1000/igb_ethdev.c
> @@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
> default:
> PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
> filter_type);
> + ret = -EINVAL;
> break;
> }
>
> --
> 2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported.
@ 2020-12-08 8:10 banxiaozhen, benhaz1024
2020-12-08 9:04 ` Wang, Haiyue
0 siblings, 1 reply; 6+ messages in thread
From: banxiaozhen, benhaz1024 @ 2020-12-08 8:10 UTC (permalink / raw)
To: jia.guo, haiyue.wang; +Cc: dev, banxiaozhen
From: banxiaozhen <benhaz1024@gmail.com>
Signed-off-by: banxiaozhen <benhaz1024@gmail.com>
---
drivers/net/e1000/igb_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 647aa8d99..8695426c2 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -4561,6 +4561,7 @@ eth_igb_filter_ctrl(struct rte_eth_dev *dev __rte_unused,
default:
PMD_DRV_LOG(WARNING, "Filter type (%d) not supported",
filter_type);
+ ret = -EINVAL;
break;
}
--
2.24.3 (Apple Git-128)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-12-08 11:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-08 8:02 [dpdk-dev] [PATCH] net/e1000: fix incorrect return value if filter type not supported banxiaozhen, benhaz1024
2020-12-08 8:10 banxiaozhen, benhaz1024
2020-12-08 9:04 ` Wang, Haiyue
2020-12-08 9:58 ` haz ben
2020-12-08 10:40 ` Wang, Haiyue
2020-12-08 11:05 ` Wang, Haiyue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).