From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5EE4CA09E5; Tue, 8 Dec 2020 09:17:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B862F72DE; Tue, 8 Dec 2020 09:17:34 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 43D8BA3 for ; Tue, 8 Dec 2020 09:17:33 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 08 Dec 2020 00:17:31 -0800 Received: from nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 8 Dec 2020 08:17:21 +0000 From: Gregory Etelson To: CC: , , , Viacheslav Ovsiienko , Shahaf Shuler , Bing Zhao , Xueming Li Date: Tue, 8 Dec 2020 10:17:05 +0200 Message-ID: <20201208081705.11751-1-getelson@nvidia.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201207142738.27945-1-getelson@nvidia.com> References: <20201207142738.27945-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1607415451; bh=MZFI1P7zAk4rV5uhFkXqIEQomSnmdeoZ99WXV9Zokzs=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=bJAEFNMG0wtm4/dfworzn3SQrwenR+LxxPsRO37IeVaXzRPocVcQfRrJI6QyuXC82 rJ5QKgsnnelIKAw15ScTQbwG0vH2j28LhQgPRFXRgyIGcn5UrNE1RsDHooKZdjJIqd HOxVv+7QTc/u7AgxSLqnT5Gng41BDAyRyPjKVXpaHEwYUPz+ZA+NMTKOtVGJiGCQb9 /XZmkD5ClnEZA4D0Gmfj5PM0BR2TYhDIVfnuIX+E58roZNrS2e3PO/csb/INHtoD/r 46AV0sQTpZRAY34h/i/uqadkFJNcfh20qgbvFx7pu6RbbdNr5+CXmrsPf6lCXuRMn7 LLMiHNbRr0A5w== Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix flow descriptor allocation in Direct Verbs mode. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Initialize flow descriptor tunnel member during flow creation. Prevent access to stale data and pointers when flow descriptor is reallocated after release. Fix flow index validation. Fixes: e7bfa3596a0a ("net/mlx5: separate the flow handle resource") Fixes: 8bb81f2649b1 ("net/mlx5: use thread specific flow workspace") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_d= v.c index aa21ff9613..8f7085c951 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -6232,8 +6232,9 @@ flow_dv_prepare(struct rte_eth_dev *dev, "not enough memory to create flow handle"); return NULL; } - MLX5_ASSERT(wks->flow_idx + 1 < RTE_DIM(wks->flows)); + MLX5_ASSERT(wks->flow_idx < RTE_DIM(wks->flows)); dev_flow =3D &wks->flows[wks->flow_idx++]; + memset(dev_flow, 0, sizeof(*dev_flow)); dev_flow->handle =3D dev_handle; dev_flow->handle_idx =3D handle_idx; /* @@ -6245,12 +6246,6 @@ flow_dv_prepare(struct rte_eth_dev *dev, */ dev_flow->dv.value.size =3D MLX5_ST_SZ_BYTES(fte_match_param) - MLX5_ST_SZ_BYTES(fte_match_set_misc4); - /* - * The matching value needs to be cleared to 0 before using. In the - * past, it will be automatically cleared when using rte_*alloc - * API. The time consumption will be almost the same as before. - */ - memset(dev_flow->dv.value.buf, 0, MLX5_ST_SZ_BYTES(fte_match_param)); dev_flow->ingress =3D attr->ingress; dev_flow->dv.transfer =3D attr->transfer; return dev_flow; --=20 2.29.2