From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 98410A09E9;
Wed, 9 Dec 2020 04:22:40 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id BA809C96E;
Wed, 9 Dec 2020 04:21:24 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 2435CBE77
for <dev@dpdk.org>; Wed, 9 Dec 2020 04:21:22 +0100 (CET)
IronPort-SDR: RDhz2p9Bt2eGdPv3pErN6nTttTMfzcpKPTnoiyJBiW1RgDkXmCZmoBbXXBtXRlxS/k3zMpuco5
6mRU9DsbkybA==
X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="192310598"
X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="192310598"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Dec 2020 19:21:21 -0800
IronPort-SDR: XcfbAsZQ3QjyQeYpsbKaitnQ2ON3PZVz3Ii0P2D4hQS6voBrmzOsWkW/0blDzuOqioNKACazoK
Wg1znGvTDDWg==
X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="363949160"
Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Dec 2020 19:21:09 -0800
From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com,
haiyue.wang@intel.com, xavier.huwei@huawei.com, humin29@huawei.com,
yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com,
jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com,
rosen.xu@intel.com, hkalra@marvell.com, jerinj@marvell.com,
ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com,
shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com,
wei.dai@intel.com, fengchunsong@huawei.com, lihuisong@huawei.com,
ferruh.yigit@intel.com, chenhao164@huawei.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com,
ting.xu@intel.com, xiaoyun.li@intel.com, wenzhuo.lu@intel.com,
andy.pei@intel.com, dan.wei@intel.com, skori@marvell.com,
vattunuru@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com,
ivan.malov@oktetlabs.ru, zyta.szpak@semihalf.com,
slawomir.rosek@semihalf.com, rad@semihalf.com,
Steve Yang <stevex.yang@intel.com>
Date: Wed, 9 Dec 2020 03:16:27 +0000
Message-Id: <20201209031628.29572-12-stevex.yang@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201209031628.29572-1-stevex.yang@intel.com>
References: <20201209031628.29572-1-stevex.yang@intel.com>
Subject: [dpdk-dev] [PATCH v1 11/12] net/sfc: fix the jumbo frame flag
condition for mtu set
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but
the Ether overhead is larger than 18 when it supports VLAN tag. That
will cause the jumbo flag rx offload is wrong when MTU size is
'RTE_ETHER_MTU'.
This fix will change the boundary condition with 'RTE_ETHER_MTU'.
Fixes: ff6a1197c3b1 ("net/sfc: convert to new Rx offload API")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/sfc/sfc_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c
index 93fc7baa0d..f2f5336435 100644
--- a/drivers/net/sfc/sfc_ethdev.c
+++ b/drivers/net/sfc/sfc_ethdev.c
@@ -1017,7 +1017,7 @@ sfc_dev_set_mtu(struct rte_eth_dev *dev, uint16_t mtu)
* The driver does not use it, but other PMDs update jumbo frame
* flag and max_rx_pkt_len when MTU is set.
*/
- if (mtu > RTE_ETHER_MAX_LEN) {
+ if (mtu > RTE_ETHER_MTU) {
struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode;
rxmode->offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME;
}
--
2.17.1