From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4963EA09E9;
Wed, 9 Dec 2020 04:21:30 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 3E304C9C8;
Wed, 9 Dec 2020 04:20:40 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id F0422C9C0
for <dev@dpdk.org>; Wed, 9 Dec 2020 04:20:37 +0100 (CET)
IronPort-SDR: YOog4O8fMV3bPJY0r9pxFk/haRvDsm8u7AUJkVcyr4BuukZ5M1vlIZchqBPJuKKHxVG3faIyUu
VYdYPzGnT8jw==
X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="173251935"
X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="173251935"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Dec 2020 19:20:35 -0800
IronPort-SDR: 1yOnJaSJSV6/r054kAfZpMJqaLJt3H8Qky2o1TXbETyybHKLgaDTOI4hn/jlPOe28Uj1F8y5AW
6OQ+ZM1MUAbg==
X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208";a="363948913"
Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136])
by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
08 Dec 2020 19:20:24 -0800
From: Steve Yang <stevex.yang@intel.com>
To: dev@dpdk.org
Cc: hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, jia.guo@intel.com,
haiyue.wang@intel.com, xavier.huwei@huawei.com, humin29@huawei.com,
yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com,
jingjing.wu@intel.com, qiming.yang@intel.com, qi.z.zhang@intel.com,
rosen.xu@intel.com, hkalra@marvell.com, jerinj@marvell.com,
ndabilpuram@marvell.com, kirankumark@marvell.com, rmody@marvell.com,
shshaikh@marvell.com, andrew.rybchenko@oktetlabs.ru, mczekaj@marvell.com,
wei.dai@intel.com, fengchunsong@huawei.com, lihuisong@huawei.com,
ferruh.yigit@intel.com, chenhao164@huawei.com, helin.zhang@intel.com,
konstantin.ananyev@intel.com, yanglong.wu@intel.com, xiaolong.ye@intel.com,
ting.xu@intel.com, xiaoyun.li@intel.com, wenzhuo.lu@intel.com,
andy.pei@intel.com, dan.wei@intel.com, skori@marvell.com,
vattunuru@marvell.com, sony.chacko@qlogic.com, bruce.richardson@intel.com,
ivan.malov@oktetlabs.ru, zyta.szpak@semihalf.com,
slawomir.rosek@semihalf.com, rad@semihalf.com,
Steve Yang <stevex.yang@intel.com>
Date: Wed, 9 Dec 2020 03:16:23 +0000
Message-Id: <20201209031628.29572-8-stevex.yang@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20201209031628.29572-1-stevex.yang@intel.com>
References: <20201209031628.29572-1-stevex.yang@intel.com>
Subject: [dpdk-dev] [PATCH v1 07/12] net/ipn3ke: fix the jumbo frame flag
condition for mtu set
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but
the Ether overhead is larger than 18 when it supports dual VLAN tags.
That will cause the jumbo flag rx offload is wrong when MTU size is
'RTE_ETHER_MTU'.
This fix will change the boundary condition with 'RTE_ETHER_MTU'.
Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor")
Signed-off-by: Steve Yang <stevex.yang@intel.com>
---
drivers/net/ipn3ke/ipn3ke_representor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c b/drivers/net/ipn3ke/ipn3ke_representor.c
index 8a53602576..c8ca58cc4b 100644
--- a/drivers/net/ipn3ke/ipn3ke_representor.c
+++ b/drivers/net/ipn3ke/ipn3ke_representor.c
@@ -2801,7 +2801,7 @@ ipn3ke_rpst_mtu_set(struct rte_eth_dev *ethdev, uint16_t mtu)
return -EBUSY;
}
- if (frame_size > RTE_ETHER_MAX_LEN)
+ if (mtu > RTE_ETHER_MTU)
dev_data->dev_conf.rxmode.offloads |=
(uint64_t)(DEV_RX_OFFLOAD_JUMBO_FRAME);
else
--
2.17.1