From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60A79A04DB; Wed, 9 Dec 2020 20:28:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F6CDCA58; Wed, 9 Dec 2020 20:23:09 +0100 (CET) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id 3808BCA16 for ; Wed, 9 Dec 2020 20:23:01 +0100 (CET) Received: by mail-pg1-f194.google.com with SMTP id v29so1806150pgk.12 for ; Wed, 09 Dec 2020 11:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=TT8YdPYWfbYkyBD8nbmy/X4Y1w8JNrQ9q5fapLAPC0c=; b=FQNYtvtCULgywuJH4mZDyAW2ogZhk4XdfTTKAICwDgqVdXykJESHDja9E8Dn8Vwzmm Kgri3igvp0z2mKDLbP3e5Yjz3YLF9ZSOwv+1UeXeAcrptSz8xgmPwBMTr6HEX1W6KTuf C3KW/dy8fde55cDIoqdFS618Lw0DUmw+ZVhd8JjpAp/OYrbtZI+tR2/MCuCVGZ/S0z5D sjUgASeV7Lm8QyXaxA996ReOPSmWrka00rc4aoUceVDKbzMbi/EPj+ub08Vwd/6Gqsqe +m0vAoIcg/nr/+yLplv4n5FqdcYwDCzBP7tnEeQnGcvDowXyr47o49+OUz9BzBjN8cGq LGOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TT8YdPYWfbYkyBD8nbmy/X4Y1w8JNrQ9q5fapLAPC0c=; b=FaVGOIP9a3HcmEiiAxkZ9vP1LakOFAMzsFD8MbYsRd1Kx3yBg6fMSThLKlv0GIhnFZ fMWI8BqTLp16P8eJppPQmiTInYpMcLVEsweGmJuXKtKnbRaInHUZA8wRqAd0CrtTYPvt sAm7PXibWJCf7yM6HaDM1IGBKlOsdvN/aRVD9QV/iuJCeYQri6qcR1RfDLjFMLxyf69Q 5PMXKifZlB79JjYpHde6LMrXCrb8TuEIf2w1rbUFTBHRyiqkYL9yGX7tPcy5g7zsDKIm BEJk8/3Lljmuviu7SLdYO9KHcUCjDGvazJYVbg8SHcOCSrT3FXfWyh0/FrPuspyHzVBM wRIA== X-Gm-Message-State: AOAM5329f5/KLAn4He7Rj0FuCmYLg0jJOL+6pynJd0zf/Wo/0tEDIw3O FMmH5Y+NWbeuRneXddkvippNiyAqJ3q83zXH X-Google-Smtp-Source: ABdhPJyMAUFKfEuyA+wa9OfookJcMQCw26AYntpA5kxwTuiEX7wMrr2s89cyZYe3Oa+p4PbDQjyaRQ== X-Received: by 2002:a62:b60b:0:b029:19d:96bd:1254 with SMTP id j11-20020a62b60b0000b029019d96bd1254mr3581485pff.24.1607541779166; Wed, 09 Dec 2020 11:22:59 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y1sm3342449pfe.80.2020.12.09.11.22.58 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 11:22:58 -0800 (PST) From: Ajit Khaparde X-Google-Original-From: Ajit Khaparde To: dev@dpdk.org Date: Wed, 9 Dec 2020 11:22:32 -0800 Message-Id: <20201209192233.6518-17-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201209192233.6518-1-ajit.khaparde@broadcom.com> References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 16/17] net/bnxt: add missing comments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add and update some missing comments in the code. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 6 ++++++ drivers/net/bnxt/tf_ulp/ulp_template_db_act.c | 5 +++++ drivers/net/bnxt/tf_ulp/ulp_template_db_class.c | 6 ++++++ 3 files changed, 17 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 556e99203..07d39ee93 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -724,7 +724,13 @@ struct bnxt { void *hwrm_short_cmd_req_addr; rte_iova_t hwrm_short_cmd_req_dma_addr; rte_spinlock_t hwrm_lock; + /* synchronize between dev_configure_op and int handler */ pthread_mutex_t def_cp_lock; + /* synchronize between dev_start_op and async evt handler + * Locking sequence in async evt handler will be + * def_cp_lock + * health_check_lock + */ pthread_mutex_t health_check_lock; uint16_t max_req_len; uint16_t max_resp_len; diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c index 00ada607a..509af7c58 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_act.c @@ -8,6 +8,10 @@ #include "ulp_template_struct.h" #include "ulp_rte_parser.h" +/* + * Action signature table: + * maps hash id to ulp_act_match_list[] index + */ uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = { [BNXT_ULP_ACT_HID_015a] = 1, [BNXT_ULP_ACT_HID_00eb] = 2, @@ -93,6 +97,7 @@ uint16_t ulp_act_sig_tbl[BNXT_ULP_ACT_SIG_TBL_MAX_SZ] = { [BNXT_ULP_ACT_HID_0b4e] = 82 }; +/* Array for the act matcher list */ struct bnxt_ulp_act_match_info ulp_act_match_list[] = { [1] = { .act_hid = BNXT_ULP_ACT_HID_015a, diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c index fdb26da3e..d904a04cb 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db_class.c @@ -8,6 +8,11 @@ #include "ulp_template_struct.h" #include "ulp_rte_parser.h" +/* Define the template structures */ +/* + * Classification signature table: + * maps hash id to ulp_class_match_list[] index + */ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = { [BNXT_ULP_CLASS_HID_0138] = 1, [BNXT_ULP_CLASS_HID_03f0] = 2, @@ -227,6 +232,7 @@ uint16_t ulp_class_sig_tbl[BNXT_ULP_CLASS_SIG_TBL_MAX_SZ] = { [BNXT_ULP_CLASS_HID_01b4] = 216 }; +/* Array for the proto matcher list */ struct bnxt_ulp_class_match_info ulp_class_match_list[] = { [1] = { .class_hid = BNXT_ULP_CLASS_HID_0138, -- 2.21.1 (Apple Git-122.3)