From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D7F8A04DB; Wed, 9 Dec 2020 20:25:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 59395C9E0; Wed, 9 Dec 2020 20:22:56 +0100 (CET) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 05422C9B4; Wed, 9 Dec 2020 20:22:50 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id u4so1459811plr.12; Wed, 09 Dec 2020 11:22:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BY0Xj7Y4S2VJLskFcw9jRnNDmSKR1gwF03p+Vuu5eYY=; b=MTk9iACnMtt4TZ2/ONBoxjF8FZG8n1V+OOF7y75pOGpPWG4IwFvN+/V5Mo2gmH5w7M wBLDutQXYo6jJ7D2pnq9lmu8t5DTsoRLGOmeB2HW+WDbhFQIqRHkQqKEgDfgWx+jJhLA 8p9Gr2SLRioRcBCciEpHMpkEeH77WGKK3y5ws17BX8AE1CfTaQMAbKSSQ0OYqhD2NVvd mQHQIBmoPVEdU2AfgvCokvS/c+CYcfXVg/Wp4pEuonqTdFVn4EkJvv1oD8/9Lri9u98i ITivhIxt/iI+Y0om2w0qEoGcsf6ddjpHJ0Eo2iexgCe1AyXKOHdzl4X8v2N4/z1YGlGh MIAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BY0Xj7Y4S2VJLskFcw9jRnNDmSKR1gwF03p+Vuu5eYY=; b=dXw3vCRzkbAKSEuuy8J+QaocHYID+/v/KtWlpJP0D2/PQ7Ayme+07Tn3xz8otGeCDG yjzr8HD93qufnRhyQhuAh2LuFsIIWS9H5D0M1ppagzMyetWI5xcX1bE359CJCWJzs2fc Pua+3L73Fv7Z8+cy7T80CcfGH4ZPQVEISGoAZ2ih8ifC8ybmgBSuUJzkWxqy+CueBOZO 8cIev/wSrbDhuJOP5RmAgGmwvIiM3KhKktEb0nd/oWpNhxCi9t2y9F+4CgnYl2VU/2ah BLX7A0PQHoUuyLWQwRW7puam+4z41kUP9MiRymOsJ9e6HIM0EHqKj+1SfxeNGEdcp7Iq +13g== X-Gm-Message-State: AOAM531oq0mP0mrZ0cbd44pcfhugbCVBabLHwgvkQaVev5JlTxincFOv JNjeXkVSCwiQhGkE09ix+ZrzPGnv4k1g3kv4 X-Google-Smtp-Source: ABdhPJxLz/SbBuAKugenKx7gnqUFlDphljqbYQgWBmJkYngQBNaY72uIiHDr6DarhYt7kEh81XoT9w== X-Received: by 2002:a17:902:c395:b029:da:9aca:c972 with SMTP id g21-20020a170902c395b02900da9acac972mr3646445plg.32.1607541766598; Wed, 09 Dec 2020 11:22:46 -0800 (PST) Received: from localhost.localdomain ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id y1sm3342449pfe.80.2020.12.09.11.22.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 11:22:46 -0800 (PST) From: Ajit Khaparde X-Google-Original-From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org, Somnath Kotur Date: Wed, 9 Dec 2020 11:22:22 -0800 Message-Id: <20201209192233.6518-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201209192233.6518-1-ajit.khaparde@broadcom.com> References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 06/17] net/bnxt: fix to return error when fw command fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 8047b0b5d..33358779b 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1843,8 +1843,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev, } } - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev, @@ -1949,8 +1949,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev, memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len); rss_config: - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev, -- 2.21.1 (Apple Git-122.3)