From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0E17A04DB; Thu, 10 Dec 2020 00:56:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D876C9E2; Thu, 10 Dec 2020 00:54:07 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id D74D2C9B2; Thu, 10 Dec 2020 00:54:02 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id d2so2298644pfq.5; Wed, 09 Dec 2020 15:54:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BY0Xj7Y4S2VJLskFcw9jRnNDmSKR1gwF03p+Vuu5eYY=; b=s/Cu2tgSG6G3oBmyRCP743jhIFsw8XWnv97T6aGTl6PvoRsCQOdV70jNLA9uqdvfTI Hez2yPpVy6XDtcGG8s8pWM15KHccq0HakNEr/gULghmtARCXsLAMURG6itYgwgKTTb8R t+MUlP3dQhpHChg3VlVmMEobSyiakkGKD9AhCVaYba8LQJkE1jSV4VAQIwvWj1vBVvqL lII3SLMZ2yhoCeNrwa3pSglW5cSJ6Rx1PDk5pYBP2yPxgns9bwsH5Mp/VBFpqXzSzTn9 uYHDCiQosMnb65kmdIVynXHq77+C0SiOOLrobgAV6Elk6hDBYResuhlK/wdhP2Z732XG tEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BY0Xj7Y4S2VJLskFcw9jRnNDmSKR1gwF03p+Vuu5eYY=; b=qdrCTOZ4bf7+5RuE7FwZGAftCoA1fsQkTsFbAhvliru4m/nhrssbr2Fj1Wpn9VBaFk jC3Gb15C0fUPIceMFnxzEQ1GpKXZL1Cnse9fJrpme5q/291vVqXLQPeenWfSMYl9Y7Nf USPV+HqjSFMXgHunmNqIYwcF70QxQXZm25Rr64uQJ6Fhav7NK1CtLz8Sy1eDDAeFI3WQ nDHiw9uYBncc6UTkUam4OKXgFgFr2028gOHmDYJCz7Ywj6K47rqKeoG7kQ8FGl2IAmTU n+K2mpgJmAwD+oG/r9PFQ+F26yf5pzRr2VS/T2weys6KfzIbqV61BHkPWbH8iWotMO6F tlPw== X-Gm-Message-State: AOAM531LCv11qbrcf8+bvMb4+fEz1LT1lIXfhEtwJsNLl4lNZNv3MJT2 cq/EFVUoxL4mjZ7UbZlIiPjQSPN6QzYlP02o X-Google-Smtp-Source: ABdhPJzqcOzbAxzaxO7uHXvZy1sSBRHBkvSvS6faYSbNJPRu1kHIIeGjULciqpYKXGJkHHf33LwG3g== X-Received: by 2002:a17:90a:6445:: with SMTP id y5mr4449758pjm.64.1607558040896; Wed, 09 Dec 2020 15:54:00 -0800 (PST) Received: from localhost.localdomain ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id s7sm4047693pfh.207.2020.12.09.15.53.59 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Dec 2020 15:54:00 -0800 (PST) From: Ajit Khaparde X-Google-Original-From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org, Somnath Kotur Date: Wed, 9 Dec 2020 15:53:36 -0800 Message-Id: <20201209235347.16180-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20201209235347.16180-1-ajit.khaparde@broadcom.com> References: <20201209192233.6518-1-ajit.khaparde@broadcom.com> <20201209235347.16180-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 06/17] net/bnxt: fix to return error when fw command fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP In bnxt_reta_update_op() and bnxt_rss_hash_update_op(), driver does not propagate the error back to the application when the fw command fails. Fixes: 378ab645bb0b ("net/bnxt: fix RSS RETA indirection table ops") Fixes: fcc0aa1edc10 ("net/bnxt: add RSS hash configuration") Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 8047b0b5d..33358779b 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1843,8 +1843,8 @@ static int bnxt_reta_update_op(struct rte_eth_dev *eth_dev, } } - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_reta_query_op(struct rte_eth_dev *eth_dev, @@ -1949,8 +1949,8 @@ static int bnxt_rss_hash_update_op(struct rte_eth_dev *eth_dev, memcpy(vnic->rss_hash_key, rss_conf->rss_key, rss_conf->rss_key_len); rss_config: - bnxt_hwrm_vnic_rss_cfg(bp, vnic); - return 0; + rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); + return rc; } static int bnxt_rss_hash_conf_get_op(struct rte_eth_dev *eth_dev, -- 2.21.1 (Apple Git-122.3)