From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BD1FA04DB; Thu, 10 Dec 2020 03:09:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A962C9C2; Thu, 10 Dec 2020 03:08:09 +0100 (CET) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 3B1CFC99C for ; Thu, 10 Dec 2020 03:08:04 +0100 (CET) Received: by mail-pg1-f196.google.com with SMTP id w5so1963557pgj.3 for ; Wed, 09 Dec 2020 18:08:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=qmxIh6cdNdLLa2XdNRfpBmQWwzN+8fOiAnW4//T+ShM=; b=GXKbbFdOnZJRtgtK6b995sr7VCXHrnydutPr2dPrkw94clAZOuQ3Fe7Tdzu8VGTkH4 putq0Z5vLfykJPZ+J5A2lE+Ye7Z9FPkVOhfZmfx6OecfX6sZN9QT6nKTYv/yaKRtKdG1 ABZ7UXG3q4O/4f0yYJUiukmWf+ZbdWLGzOFgLUu7bU2uR0qAUAfGNQXPDP0LxLcyi+jo ZhIj5mYRsx4zx/TT822kbdaoxugYZlXgpNsFp4ZwEHtGdsewKHH9drqavMJP62PaATpZ h/fn/27W50LIhSmmuQ17yJyFTipOIk3Upt8nLaOqF5OaDVgWsoYrNyohX73ulBbrY6uH pFFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=qmxIh6cdNdLLa2XdNRfpBmQWwzN+8fOiAnW4//T+ShM=; b=CekjeiuF3eFeD6caC0xtqjseFWq3AnaDxEUlWn0Lji5v8ce/3ow9QzG1fjlIxqg6wP sjUkFQCHeVxxAZIXK2X5Z/9Ua2NnE3R3mSsz6CyyEpQXlX+Kv9mSRNCFDFNTEdGJ3MxJ k2Clojvv+siM5YQxTLerBRCHgN0mN41IlLQSHNbi3BKRB8eSZCdKxv2hZjjtO2pBhleg JWEY1BxVjDtUNO95T1h1R49z6fFblteBEI1Adf9z5mRHgGggeTzbcRg2nv0Gks6VAqmb Ddm7s1GSixR1fypdCx6LNMZG58Rnw2OII20QoSNO0rgl/pJtnH4xe6hji+BkrJQ6PfOu cKtg== X-Gm-Message-State: AOAM533ZG8ZqUBnPhz1z7cGUq2seLp0KNkYmbPUj7n+AJe8Y9fJGP8VQ m3EGh6f+AMOCtMlT4lMgaX5RtiEbTM3IeQ== X-Google-Smtp-Source: ABdhPJwiWE2Xl4NIIY1Fawib+I7iwgNPcVtJ2pk37/R2dV85uscAH3KQQ5Wa9jhqLZwHg7Def0G00Q== X-Received: by 2002:a63:7f03:: with SMTP id a3mr4475824pgd.313.1607566082966; Wed, 09 Dec 2020 18:08:02 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id p185sm1344537pfb.165.2020.12.09.18.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Dec 2020 18:08:02 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Wed, 9 Dec 2020 18:07:40 -0800 Message-Id: <20201210020743.68927-7-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201210020743.68927-1-aboyer@pensando.io> References: <20201210020743.68927-1-aboyer@pensando.io> In-Reply-To: <20201204201646.51746-1-aboyer@pensando.io> References: <20201204201646.51746-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH v4 6/9] net/ionic: convert 'deferred' boolean to a flag bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This conserves resources. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 4 ++-- drivers/net/ionic/ionic_lif.h | 2 +- drivers/net/ionic/ionic_rxtx.c | 10 ++++++---- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index bc15d75fd..2e33fb8d9 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1590,7 +1590,7 @@ ionic_lif_start(struct ionic_lif *lif) for (i = 0; i < lif->nrxqcqs; i++) { struct ionic_qcq *rxq = lif->rxqcqs[i]; - if (!rxq->deferred_start) { + if (!(rxq->flags & IONIC_QCQ_F_DEFERRED)) { err = ionic_dev_rx_queue_start(lif->eth_dev, i); if (err) @@ -1600,7 +1600,7 @@ ionic_lif_start(struct ionic_lif *lif) for (i = 0; i < lif->ntxqcqs; i++) { struct ionic_qcq *txq = lif->txqcqs[i]; - if (!txq->deferred_start) { + if (!(txq->flags & IONIC_QCQ_F_DEFERRED)) { err = ionic_dev_tx_queue_start(lif->eth_dev, i); if (err) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/net/ionic/ionic_lif.h index 4e091719f..8e2b42443 100644 --- a/drivers/net/ionic/ionic_lif.h +++ b/drivers/net/ionic/ionic_lif.h @@ -50,6 +50,7 @@ struct ionic_rx_stats { #define IONIC_QCQ_F_SG BIT(1) #define IONIC_QCQ_F_INTR BIT(2) #define IONIC_QCQ_F_NOTIFYQ BIT(3) +#define IONIC_QCQ_F_DEFERRED BIT(4) /* Queue / Completion Queue */ struct ionic_qcq { @@ -68,7 +69,6 @@ struct ionic_qcq { uint32_t total_size; uint32_t flags; struct ionic_intr_info intr; - bool deferred_start; }; #define IONIC_Q_TO_QCQ(q) container_of(q, struct ionic_qcq, q) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 2592f5cab..b953aff49 100644 --- a/drivers/net/ionic/ionic_rxtx.c +++ b/drivers/net/ionic/ionic_rxtx.c @@ -64,7 +64,7 @@ ionic_txq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->nb_desc = q->num_descs; qinfo->conf.offloads = txq->offloads; - qinfo->conf.tx_deferred_start = txq->deferred_start; + qinfo->conf.tx_deferred_start = txq->flags & IONIC_QCQ_F_DEFERRED; } static inline void __rte_cold @@ -196,7 +196,8 @@ ionic_dev_tx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t tx_queue_id, } /* Do not start queue with rte_eth_dev_start() */ - txq->deferred_start = tx_conf->tx_deferred_start; + if (tx_conf->tx_deferred_start) + txq->flags |= IONIC_QCQ_F_DEFERRED; txq->offloads = offloads; @@ -605,7 +606,7 @@ ionic_rxq_info_get(struct rte_eth_dev *dev, uint16_t queue_id, qinfo->mp = rxq->mb_pool; qinfo->scattered_rx = dev->data->scattered_rx; qinfo->nb_desc = q->num_descs; - qinfo->conf.rx_deferred_start = rxq->deferred_start; + qinfo->conf.rx_deferred_start = rxq->flags & IONIC_QCQ_F_DEFERRED; qinfo->conf.offloads = rxq->offloads; } @@ -703,7 +704,8 @@ ionic_dev_rx_queue_setup(struct rte_eth_dev *eth_dev, */ /* Do not start queue with rte_eth_dev_start() */ - rxq->deferred_start = rx_conf->rx_deferred_start; + if (rx_conf->rx_deferred_start) + rxq->flags |= IONIC_QCQ_F_DEFERRED; rxq->offloads = offloads; -- 2.17.1