From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CAFD4A04DB; Thu, 10 Dec 2020 15:23:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90F45C96E; Thu, 10 Dec 2020 15:22:47 +0100 (CET) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id E0CF3C96A for ; Thu, 10 Dec 2020 15:22:44 +0100 (CET) Received: by mail-pg1-f193.google.com with SMTP id n7so4364716pgg.2 for ; Thu, 10 Dec 2020 06:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=g06wwYqmRVK2Em5LTinFCFJ/u7QltAGordzsSAQRCRQ=; b=a71GkQkZ8AEgaWC0RlNNxm8AP6ymztmk1tYVkRop7AugLvwyuCDiFkTmT3ffxDRaFS 2uh/Qmm1fBI7pjiPbbPXCVBegU6Jz72/pXGpRca/EA/x3pYzK9ZFIcyKaBW0TmjRouRo 41SqiR0uPEngDhMcnkEDkkCAn4r1cx35fE7YXAhutSHd3YiufuoqE2w/DdGKDkaPh3bk krVtSvkVA4j+O0E4DOk188CSG3Z/fIuSW1WoGNtwz9Ha+ciiHzjZi1pv3HIMvXBu2F3U o3acIMtrmUzX0pxvsgi6ETkjv2kH9MVXw0M6HRgvdpa+5ZgB+jRhE0aeNpbZLV1jHPaD jNrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=g06wwYqmRVK2Em5LTinFCFJ/u7QltAGordzsSAQRCRQ=; b=lgJQFJtfTgfPYu37YcO4igSJosqcZCPchdwsCNJ1N0RVP8c6QHeoWJXSF9IPufk21m Fel1ylgfJevqZIL4/PEc1hGK5Gg+2BYS/KkWZHDEWCFPG1+6mH6HgaxLggy1yMQR2hsg 12OzuVgZEo+Lv8e4K919N+nhvgKdTeBjRfJAxX433sHuWjML/+pRqcH8JyPHA8ZvTwJh Dqbh8AwPc6CnxOqRCY1F0+sehsagPs4lz7GpwYeswwEEIfc2jAIRcSGyZWreFr6WXVcE vMljG5y9N9CoXhUYi8lew4FAKlnVS9He9+DV3bGRS4RF6LH6f6O4guk6585svwISVKsm yzwg== X-Gm-Message-State: AOAM5311hDoWqSvWEeJEmXirMJpBZVIaEAPOXZ4UI2OB8By/M4DYARHj Czrttt5ccgZn5zqCqSF8vviPjceiDR1GhA== X-Google-Smtp-Source: ABdhPJz9hET5l7pV0uPdYSrdtOuiP7BavTnkVbu39edVvwpvkmFF39MyLLIsXy1CirVZe+j3G9DlLQ== X-Received: by 2002:a17:90a:ca93:: with SMTP id y19mr7972767pjt.71.1607610164040; Thu, 10 Dec 2020 06:22:44 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id n10sm6296983pge.92.2020.12.10.06.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 06:22:43 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Thu, 10 Dec 2020 06:22:27 -0800 Message-Id: <20201210142231.63209-3-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201210142231.63209-1-aboyer@pensando.io> References: <20201210142231.63209-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH 2/6] net/ionic: preserve RX mode across LIF stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Otherwise, non-default settings (like PROMISC) get reset. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 646c921b2..875c7e585 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1573,7 +1573,7 @@ ionic_lif_configure(struct ionic_lif *lif) int ionic_lif_start(struct ionic_lif *lif) { - uint32_t rx_mode = 0; + uint32_t rx_mode; uint32_t i; int err; @@ -1581,16 +1581,16 @@ ionic_lif_start(struct ionic_lif *lif) if (err) return err; - IONIC_PRINT(DEBUG, "Setting RX mode on port %u", - lif->port_id); - - rx_mode |= IONIC_RX_MODE_F_UNICAST; - rx_mode |= IONIC_RX_MODE_F_MULTICAST; - rx_mode |= IONIC_RX_MODE_F_BROADCAST; + if (!lif->rx_mode) { + IONIC_PRINT(DEBUG, "Setting RX mode on %s", + lif->name); - lif->rx_mode = 0; /* set by ionic_set_rx_mode */ + rx_mode = IONIC_RX_MODE_F_UNICAST; + rx_mode |= IONIC_RX_MODE_F_MULTICAST; + rx_mode |= IONIC_RX_MODE_F_BROADCAST; - ionic_set_rx_mode(lif, rx_mode); + ionic_set_rx_mode(lif, rx_mode); + } IONIC_PRINT(DEBUG, "Starting %u RX queues and %u TX queues " "on port %u", -- 2.17.1