From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0729A09EE; Fri, 11 Dec 2020 18:22:34 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D86FC940; Fri, 11 Dec 2020 18:22:33 +0100 (CET) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by dpdk.org (Postfix) with ESMTP id C20ECBC86 for ; Fri, 11 Dec 2020 18:22:31 +0100 (CET) Received: by mail-pj1-f68.google.com with SMTP id lb18so2512581pjb.5 for ; Fri, 11 Dec 2020 09:22:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cZthgTDF5yFFZ06mYTWmo9mLoZeNXQk032xG5VeELrk=; b=MB4g4uCgiE4v9nBcqKmA8QdhXHr0V4Z4pbryqU4ueYIHrapB3bOEnQ3bJOKOb31BZY XROqQO4G17I0mKk+7Onx/5vnMCwKIsGMYhBPIcxOcfUBn0NyaHyoT6ufJ/wHstida89R zdJvt5vMLxV502urUM5p+0LuE0NFVpya7WofFD/GeBywai6sGwOA+qKht4R/+kKHLeC/ tG9Clrz6QKaIfYriOrhLvSPiwoRU0G8ygW6gyw/4ftEJ0y4I+VCABIRnQWAz60gBRagl J4WLRY2D43z42fJ5zKf6RuQD07b70UfxOZx+FfxnolKh4CFMaTcErfBwPbIXARmp5J7u F93g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cZthgTDF5yFFZ06mYTWmo9mLoZeNXQk032xG5VeELrk=; b=IZA0+F7WKJw03P3SKV9thzs9zdQkp7SkTaOSATXpArXHk68ppCekARrVpV7+ckcLd3 ktruevWxAuweBB08HnRrarfqL6lsiFLCYUKPNTpWqiVEF2yXtwSktebMAjfDAZEQEdI9 RVyVsWbuLyHLLhGAz5VeEA5asWzUvgWB4LZMgdqho0dq13AB2eLzsbBV404VFCymj7Lc w86Gg0enGsPRI9LSoHqQsr/oKtQ53gOlZqw7j782DoIDZZD33gJdJUjtWTYVHAuwp+Cf EYFmr2Kxy1wuD9liWLsqWO1Dm/Q6K7SjDj51Jg7m+QutKlJyReZ8sb1u6WXBEQXMDm/5 y51w== X-Gm-Message-State: AOAM532gWS7CCjym0YxsbECEcrmPOgz8M1hk9MSWQFON5ol+II2tbAcK Jj2Qh+DzqP/nCFfyUEvxWV/B8w== X-Google-Smtp-Source: ABdhPJy5IjVggS0bvtiKFxzXRKmsxCg3t/Ac238Idb2Xtj5Lo5ZP+ljDI7i6t63unoZpMCaM8Fm28w== X-Received: by 2002:a17:90b:14d3:: with SMTP id jz19mr14120196pjb.196.1607707350759; Fri, 11 Dec 2020 09:22:30 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id gw21sm10620040pjb.28.2020.12.11.09.22.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Dec 2020 09:22:30 -0800 (PST) Date: Fri, 11 Dec 2020 09:21:36 -0800 From: Stephen Hemminger To: Long Li Cc: Stephen Hemminger , dev@dpdk.org, Long Li , stable@dpdk.org Message-ID: <20201211092136.4de4e248@hermes.local> In-Reply-To: <1607673164-3683-1-git-send-email-longli@linuxonhyperv.com> References: <1607673164-3683-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/netvsc: ignore NVS_TYPE_TXTBL_NOTE while executing a sync command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 10 Dec 2020 23:52:44 -0800 Long Li wrote: > From: Long Li > > On netvsc initialization, the host VSP may send a NVS_TYPE_TXTBL_NOTE packet > while executing a VSP command synchronously. > > Ignore this packet as we don't use it for DPDK. > > Cc: stable@dpdk.org > Signed-off-by: Long Li > --- > drivers/net/netvsc/hn_nvs.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/netvsc/hn_nvs.c b/drivers/net/netvsc/hn_nvs.c > index a0ee7d8bfa..b6aa07cc5f 100644 > --- a/drivers/net/netvsc/hn_nvs.c > +++ b/drivers/net/netvsc/hn_nvs.c > @@ -97,8 +97,13 @@ __hn_nvs_execute(struct hn_data *hv, > hdr = (struct hn_nvs_hdr *)buffer; > > /* Silently drop received packets while waiting for response */ > - if (hdr->type == NVS_TYPE_RNDIS) { > + switch (hdr->type) { > + case NVS_TYPE_RNDIS: > hn_nvs_ack_rxbuf(chan, xactid); > + /* fallthrough */ > + > + case NVS_TYPE_TXTBL_NOTE: > + PMD_DRV_LOG(NOTICE, "discard packet type %x", hdr->type); > goto retry; > } > Could you change that log message to DEBUG (or INFO) level? Users probably don't need to see it. Acked-by: Stephen Hemminger