* [dpdk-dev] [PATCH] eal: don't log uninitialized string
@ 2020-12-11 17:06 Andrew Boyer
2020-12-14 23:23 ` Mcnamara, John
2021-01-06 9:35 ` [dpdk-dev] [dpdk-stable] " David Marchand
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Boyer @ 2020-12-11 17:06 UTC (permalink / raw)
To: dev; +Cc: Andrew Boyer, anatoly.burakov, stable
Our Coverity scan pointed out that path[] is never initialized.
The official DPDK Coverity has not reported this so there is
no public CID for it.
Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
Cc: anatoly.burakov@intel.com
Cc: stable@dpdk.org
Signed-off-by: Andrew Boyer <aboyer@pensando.io>
---
lib/librte_eal/common/eal_common_fbarray.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
index 1220e2bae..6ce89af83 100644
--- a/lib/librte_eal/common/eal_common_fbarray.c
+++ b/lib/librte_eal/common/eal_common_fbarray.c
@@ -83,11 +83,10 @@ get_used_mask(void *data, unsigned int elt_sz, unsigned int len)
static int
resize_and_map(int fd, void *addr, size_t len)
{
- char path[PATH_MAX];
void *map_addr;
if (eal_file_truncate(fd, len)) {
- RTE_LOG(ERR, EAL, "Cannot truncate %s\n", path);
+ RTE_LOG(ERR, EAL, "Cannot truncate fd %d\n", fd);
return -1;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] eal: don't log uninitialized string
2020-12-11 17:06 [dpdk-dev] [PATCH] eal: don't log uninitialized string Andrew Boyer
@ 2020-12-14 23:23 ` Mcnamara, John
2021-01-06 9:35 ` [dpdk-dev] [dpdk-stable] " David Marchand
1 sibling, 0 replies; 4+ messages in thread
From: Mcnamara, John @ 2020-12-14 23:23 UTC (permalink / raw)
To: Andrew Boyer, dev; +Cc: Burakov, Anatoly, stable
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Boyer
> Sent: Friday, December 11, 2020 5:06 PM
> To: dev@dpdk.org
> Cc: Andrew Boyer <aboyer@pensando.io>; Burakov, Anatoly
> <anatoly.burakov@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] eal: don't log uninitialized string
>
> Our Coverity scan pointed out that path[] is never initialized.
> The official DPDK Coverity has not reported this so there is no public CID
> for it.
I double checked and I can confirm that this wasn't picked up by any of the public scans, even though 4 other issues in that file were. So thanks for the fix.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: don't log uninitialized string
2020-12-11 17:06 [dpdk-dev] [PATCH] eal: don't log uninitialized string Andrew Boyer
2020-12-14 23:23 ` Mcnamara, John
@ 2021-01-06 9:35 ` David Marchand
2021-02-09 14:35 ` Andrew Boyer
1 sibling, 1 reply; 4+ messages in thread
From: David Marchand @ 2021-01-06 9:35 UTC (permalink / raw)
To: Andrew Boyer, Burakov, Anatoly; +Cc: dev, dpdk stable
On Fri, Dec 11, 2020 at 6:07 PM Andrew Boyer <aboyer@pensando.io> wrote:
>
> Our Coverity scan pointed out that path[] is never initialized.
> The official DPDK Coverity has not reported this so there is
> no public CID for it.
>
> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
> Cc: anatoly.burakov@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
> ---
> lib/librte_eal/common/eal_common_fbarray.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
> index 1220e2bae..6ce89af83 100644
> --- a/lib/librte_eal/common/eal_common_fbarray.c
> +++ b/lib/librte_eal/common/eal_common_fbarray.c
> @@ -83,11 +83,10 @@ get_used_mask(void *data, unsigned int elt_sz, unsigned int len)
> static int
> resize_and_map(int fd, void *addr, size_t len)
> {
> - char path[PATH_MAX];
> void *map_addr;
>
> if (eal_file_truncate(fd, len)) {
> - RTE_LOG(ERR, EAL, "Cannot truncate %s\n", path);
> + RTE_LOG(ERR, EAL, "Cannot truncate fd %d\n", fd);
Logging a fd number won't help much, but I guess this was not really
helpful with path[] either :-).
If we keep this log, I would move it to the callers of the functions,
where the filename is available.
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: don't log uninitialized string
2021-01-06 9:35 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2021-02-09 14:35 ` Andrew Boyer
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Boyer @ 2021-02-09 14:35 UTC (permalink / raw)
To: David Marchand; +Cc: Burakov, Anatoly, dev, dpdk stable
> On Jan 6, 2021, at 4:35 AM, David Marchand <david.marchand@redhat.com> wrote:
>
> On Fri, Dec 11, 2020 at 6:07 PM Andrew Boyer <aboyer@pensando.io <mailto:aboyer@pensando.io>> wrote:
>>
>> Our Coverity scan pointed out that path[] is never initialized.
>> The official DPDK Coverity has not reported this so there is
>> no public CID for it.
>>
>> Fixes: c44d09811b40 ("eal: add shared indexed file-backed array")
>> Cc: anatoly.burakov@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
>> ---
>> lib/librte_eal/common/eal_common_fbarray.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c
>> index 1220e2bae..6ce89af83 100644
>> --- a/lib/librte_eal/common/eal_common_fbarray.c
>> +++ b/lib/librte_eal/common/eal_common_fbarray.c
>> @@ -83,11 +83,10 @@ get_used_mask(void *data, unsigned int elt_sz, unsigned int len)
>> static int
>> resize_and_map(int fd, void *addr, size_t len)
>> {
>> - char path[PATH_MAX];
>> void *map_addr;
>>
>> if (eal_file_truncate(fd, len)) {
>> - RTE_LOG(ERR, EAL, "Cannot truncate %s\n", path);
>> + RTE_LOG(ERR, EAL, "Cannot truncate fd %d\n", fd);
>
> Logging a fd number won't help much, but I guess this was not really
> helpful with path[] either :-).
> If we keep this log, I would move it to the callers of the functions,
> where the filename is available.
>
>
> --
> David Marchand
Can this be taken for 21.02? I realize the log isn’t that useful, but it doesn’t seem worth it (to me at least) to do much more work on it.
-Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-02-09 14:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-11 17:06 [dpdk-dev] [PATCH] eal: don't log uninitialized string Andrew Boyer
2020-12-14 23:23 ` Mcnamara, John
2021-01-06 9:35 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-02-09 14:35 ` Andrew Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).