From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8067A09EE; Sat, 12 Dec 2020 13:51:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DFA0BA550; Sat, 12 Dec 2020 13:51:47 +0100 (CET) Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [63.128.21.181]) by dpdk.org (Postfix) with ESMTP id DBC8BA54E for ; Sat, 12 Dec 2020 13:51:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1607777505; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=LILYteCGqC/CLZHDcz+HWC3M0Y35wUfYxTernLc9XCI=; b=WlI4mYpM9vp/trMMiFFgK6Pf7IjV13T8mpaA/coYaxQk4h++PX64m4syHLf8g+4kQYoS1j 6bCO/oiWTjqS1dNJgF8UcMSnWNbiP9b3SmtDHZ9l84o/6fQgYe6c53nGvBiDanHJm9DEG2 x1ZgJ54UjmOi0215Tc224Ki2ikzZs+A= Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2173.outbound.protection.outlook.com [104.47.55.173]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-130-am-LpKyOObqlV80ve5soHg-1; Sat, 12 Dec 2020 07:51:42 -0500 X-MC-Unique: am-LpKyOObqlV80ve5soHg-1 Received: from DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) by DM6PR03MB4361.namprd03.prod.outlook.com (2603:10b6:5:105::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.21; Sat, 12 Dec 2020 12:51:41 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4%6]) with mapi id 15.20.3654.019; Sat, 12 Dec 2020 12:51:41 +0000 From: Souvik Dey To: beilei.xing@intel.com, jia.guo@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, Souvik Dey Date: Sat, 12 Dec 2020 07:51:31 -0500 Message-Id: <20201212125131.15676-1-sodey@rbbn.com> X-Mailer: git-send-email 2.9.3.windows.1 X-Originating-IP: [72.70.55.110] X-ClientProxiedBy: BL0PR05CA0010.namprd05.prod.outlook.com (2603:10b6:208:91::20) To DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from SODEY-LMA.sonusnet.com (72.70.55.110) by BL0PR05CA0010.namprd05.prod.outlook.com (2603:10b6:208:91::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3676.12 via Frontend Transport; Sat, 12 Dec 2020 12:51:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35bd07c6-2fc0-48e1-5d37-08d89e9cac6f X-MS-TrafficTypeDiagnostic: DM6PR03MB4361: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: MJffq/aJLauFVqEqTn92cNbZc7JVVrRSSW8sdow6Eg7sR0Sw8Gq0uhHbcNKZQC7ny/kMLklSCpvWdaRuD1OMz3W3fABlJTWrivt3Vn4Jp3O2cUmxoyX5duhjUsKgbb4ZXj6VWmnpfKYJmCrT3qFLGCve2S3IYK/AYvirJiZPJEqDJCLkj8hm2xhLHkBHWVKjIRH5NyeZ7w6Hwr9OdGLcFqnU0sUAKHRcYK8pdqVXpaZPXhFErOKonqqaWMa3Z09VNl415LBd1NBjw6q7jxEt016hWFWmC64UZEWHNWsJOsxNiB5GUIGl0zQSfVH60gTnWbVpQSiqNZBqpQVMrE58e44M4qyZswCU97Hc1F0XH5jxYIb1P+o7D9CDOj6ujvew X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(376002)(36756003)(5660300002)(66946007)(956004)(8936002)(52116002)(26005)(6666004)(2616005)(34490700003)(107886003)(1076003)(66476007)(6506007)(83380400001)(186003)(4326008)(6486002)(8676002)(16526019)(66556008)(2906002)(508600001)(6512007)(86362001); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?L01g8YYtbNExLmQZM0H9i2M1YOZbJ98ZCBxYz/T/c+703wPo0M9/ZFb0wjfd?= =?us-ascii?Q?tSJGuQp9qbRwXMEvTlc22W7k4bzOvhnXKK3ksUqhTtuuTyto7F5FEjYi0wtT?= =?us-ascii?Q?fs3Nir84sxF0OHx0BoF+wS+nkHHyJmzahFYvlZ0fJ7sj8lGQCjZw+v8xwk+C?= =?us-ascii?Q?SWCVWK614DyaFnMLDFFNFGJbzKS5iI/TP5yJur5fO2ezLWCPUgwa0nO5Zmwi?= =?us-ascii?Q?yFQWmn6nD34Cp4PtyGyu0tLVrv2n+RBQxm/7XCzbiftdWV8+yxMzy2kAuAgO?= =?us-ascii?Q?txe1BnOwFFxxobJ6M3TTwRuY03BJRaMFrUIY1emiZYhBLw443/Smg9XiJPhy?= =?us-ascii?Q?TN4kHiLYLv7Gl6r2moQ4UP3lRelA498cmVq7IUXytvv6UBDaqSUC4xx1eySQ?= =?us-ascii?Q?VxzPAuXO6t06D80lGPCerfKC8EJrlmnHUhBxlA8T7dZcTjQf6EZn92zUQXYd?= =?us-ascii?Q?fAW5QK79WgaFv0pe9FK9N2XFh3M3SJKVZT7YEUDxMcpo15aYQeQ+5cJ0SsF+?= =?us-ascii?Q?XKPSuVRU3ks4eYSEQG0Drrkpl0WOsSzUB447zjVe0EYFlNKuRiO3rqgxRHea?= =?us-ascii?Q?yFYGlmhlhFcSWh/niACtgBt+oTlD642msTyrqHe0dPkvciP85C6+2fgzR0JD?= =?us-ascii?Q?SJtardHeEat9gC6ZyIPLjqpnXoq+HxO+S3Tw2frWisQl8wx5qONIbgZA7hDU?= =?us-ascii?Q?t7Ga+arLxyafu+CO/UxNRfBCRyM0mv38lLF5vn2650T9zrjZ5Ixos9Qw+Zi4?= =?us-ascii?Q?Mn2tgLsrSQQIdYajpJvoaem3UDsEUkmCtUkhIEHE/oIzUrrZ+2QdsjhOceYT?= =?us-ascii?Q?p/xjCv0SsGLr2o3ekwjjTqGLZTzIjco81ebSxl4yN8B7aMU/7Vimedt71t8g?= =?us-ascii?Q?Ks+or3p2a/gWLo49Psbr2c17+Q1tmaRq8dBmIpAV110vUwvaCdSisAUVAM5G?= =?us-ascii?Q?PhMWZteLs0C1BojlcKJG5RKWcZbt1bLYuP+QyzaNNVBoQNaW6zpPEgvKZt4j?= =?us-ascii?Q?rMqE?= X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4777.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2020 12:51:41.7221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-Network-Message-Id: 35bd07c6-2fc0-48e1-5d37-08d89e9cac6f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nEYrWgPh/L2c7Ji8iyBAhYGRAzr7xuLBhjFVcChQJKUccBFShOb3SLjYNxvFapUV X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4361 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA81A106 smtp.mailfrom=sodey@rbbn.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: rbbn.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2] net/i40e: issue with ADD VLAN from Guest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reset the configuration of vlan strip that would be change by the pf kernel driver when adding vlan from vf. Application cannot use rte_eth_dev_set_vlan_offload() to set the VLAN_STRIP, as this will only work for the first time when original and current config mismatch, but for all subsequent call it will be ignored. Signed-off-by: Souvik Dey --- v2: * Simplied the commit log. * goto err; is not required as it has only one more return path and there is no cleanup required apart from just return err. * Updated the comment start from /* -> /** * Changed the error log in case vlan strip command fails. --- drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethd= ev_vf.c index c26b036..a00e290 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -1078,8 +1078,19 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vl= anid) =09args.out_buffer =3D vf->aq_resp; =09args.out_size =3D I40E_AQ_BUF_SZ; =09err =3D i40evf_execute_vf_cmd(dev, &args); -=09if (err) +=09if (err) { =09=09PMD_DRV_LOG(ERR, "fail to execute command OP_ADD_VLAN"); +=09=09return err; +=09} +=09/** +=09 * In linux kernel driver on receiving ADD_VLAN it enables +=09 * VLAN_STRIP by default. So reconfigure the vlan_offload +=09 * as it was done by the app earlier. +=09 */ +=09err =3D i40evf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK) +=09if (err) +=09=09PMD_DRV_LOG(ERR, "fail to set vlan_strip " +=09=09=09"as a part of OP_ADD_VLAN"); =20 =09return err; } --=20 2.9.3.windows.1