From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 530B1A09EE; Sat, 12 Dec 2020 14:05:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A4EF2A54E; Sat, 12 Dec 2020 14:05:43 +0100 (CET) Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [216.205.24.181]) by dpdk.org (Postfix) with ESMTP id 7BE634C7B for ; Sat, 12 Dec 2020 14:05:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1607778338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5FUjydoryK6f+hwgb0P0T7N31elEWaQ9bRu+MSatXGI=; b=mfwNtmvSiSAYJT3IAAbTswDpUlnxny7NT0W61QCehEE+5JfJi0gPGmtNAdN4P2TD7l+DBL wjbNMMvI1bV4mdyq/EfJsehkIBpx8sNEOYFxKQdpJZraKcIZEkK8AKGRcQEeRr4YMW+Vwd S15LupmXP+XV4KkWTaCQrSEDdQDb4ac= Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2176.outbound.protection.outlook.com [104.47.59.176]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-I3AAB3_UPNyLxWaZG2viWw-1; Sat, 12 Dec 2020 08:05:37 -0500 X-MC-Unique: I3AAB3_UPNyLxWaZG2viWw-1 Received: from DM6PR03MB4777.namprd03.prod.outlook.com (20.179.106.218) by DM6PR03MB5098.namprd03.prod.outlook.com (10.141.161.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Sat, 12 Dec 2020 13:05:35 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4%6]) with mapi id 15.20.3654.019; Sat, 12 Dec 2020 13:05:34 +0000 From: Souvik Dey To: beilei.xing@intel.com, jia.guo@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, Souvik Dey Date: Sat, 12 Dec 2020 08:05:25 -0500 Message-Id: <20201212130525.14656-1-sodey@rbbn.com> X-Mailer: git-send-email 2.9.3.windows.1 In-Reply-To: <20201209175516.11844-1-sodey@rbbn.com> References: <20201209175516.11844-1-sodey@rbbn.com> X-Originating-IP: [72.70.55.110] X-ClientProxiedBy: BLAPR03CA0075.namprd03.prod.outlook.com (2603:10b6:208:329::20) To DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from SODEY-LMA.sonusnet.com (72.70.55.110) by BLAPR03CA0075.namprd03.prod.outlook.com (2603:10b6:208:329::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3654.12 via Frontend Transport; Sat, 12 Dec 2020 13:05:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47cca35f-a80f-4612-4c45-08d89e9e9d0f X-MS-TrafficTypeDiagnostic: DM6PR03MB5098: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: QY3xXvDQnFPe3fc7FXgw8FTkz/OqYNIM3rSjHxZmpIR/nw3EW9CETCcf9Uy3kLSnsgDQJJmdH5BFOt5onQ+egT3kIRCmsNRgOe8CVh0wM+pNPfZh8BOD8vabf5qLPkw50NzIFQHB+cFBpjM4qUN5h/ZOLJfSi3kHu4LVnJaZ79xe7SqHLB8zTtDQgNyDXqd5l3b6vG04Sh47sgoNWEKkoMRXKG5A7wXKqsV9yqq2nfOhHTlRszR0upU480D6RGibhe7842f0DQozZj0c++n7QhEdt7ipisQGpom3LaV5wpts4Ou0dnpFbY0IQf4CZvd19S+FVmSXzwCK2oleNbcm9rlEw8wpEItz5iTFxNLdNz0wlt2BMfh/YzXbD81eBYOG X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(136003)(186003)(1076003)(83380400001)(2906002)(66946007)(34490700003)(508600001)(6512007)(66476007)(8936002)(8676002)(26005)(956004)(5660300002)(66556008)(52116002)(2616005)(86362001)(36756003)(16526019)(6486002)(6666004)(6506007)(107886003)(4326008); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?qIyIeWPS72Bq07aeXFXXOEbRITGOBO2zyk7EDSnyemxxcP8tup649M0GWacK?= =?us-ascii?Q?luqTBgI7hgsZY8zskqqZr+4liOJOR6MDxuhgtrXb5uDwsIvm5v6YsyPFkXRl?= =?us-ascii?Q?ylkIG/u5I0Cn4Q0IgVq9SL39kLWZhfdx2Cmnn1IHkyWfzqWXPtS/c+Rzhrvk?= =?us-ascii?Q?LSuAQrjUMTx51c0y1lbgdqCr70RcIjU68TuPyzhgKDuQfA5dVd6W+0U7llUv?= =?us-ascii?Q?JexFnBIh7Pw9fs9tcaNQqHzuzRaesNsR/bt8JTByROzmlOXcjDpS3ZtzAb06?= =?us-ascii?Q?yNtHriasat7+4Vjzk3aBbmUj7H5AM8Jnn5z/9nFjMUH3ZRdmWAvfLFgHgIe5?= =?us-ascii?Q?feAPZkeUzMlOycWNvYVgjp1V3WvNn5H2UUEGt+ybUysPa+dFzRevoHhNeGN/?= =?us-ascii?Q?1m3eZb0N4CpguwlSAqGAdliNbSjPIeb9i5+VBSP/RjG+gRBf5/+EG6f5RY98?= =?us-ascii?Q?+7jkGiyptJMsG9n1ioRSrbBIdVfXWsp+36ebYxLYe3boQwMT4KythJQE2a0J?= =?us-ascii?Q?czBlCrvRTFHR4/0I4Rqsoy7KEfaqoPC6L+XsH2shsQDtfPPipxXimayetmmY?= =?us-ascii?Q?SR9ULfmKbsjNUjId7lv1eg4C9jVrD/cgnqFq1za8KL7OMG0xF33ciRsDoDeq?= =?us-ascii?Q?n89YG2MC2huNwnZr2SvB5Xo90VTIMRjgivmwUaGpJi5CBvpODkhFbsrmlyYt?= =?us-ascii?Q?XlfkK855OMAv+F1tWQs6xgmQ4ba8mDEUmPgFXJVsfCOS4A8Ew+qAETLoV2Vx?= =?us-ascii?Q?68CoGxjfc3AXGVQ7A4xQAJQB0+uhOyJP6JgSi4/Sunevp7FQX4wHnhgCMYvz?= =?us-ascii?Q?5bTF5bjdxVOCr00uzisoFerA5EQRgdlfKzHKno8HkgdBFxq2ELANYEfBDAYt?= =?us-ascii?Q?vPS5DTtxNddhC9lk5rHKAjUaZhqHmswMqmSKuoR6LV2R1ql7Ie8jsTWXMujq?= =?us-ascii?Q?4nc2UJ7FzuvfaTK0R6YEJGuYbUL3zW/MTpS+jkW1HXssPQ/EcLPMWYSofRBa?= =?us-ascii?Q?Lstn?= X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4777.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2020 13:05:34.8652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-Network-Message-Id: 47cca35f-a80f-4612-4c45-08d89e9e9d0f X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D+ctwwP3RTaSr6F6vf4/8zHXSfxQ5p/2RrfU1mm22xPpnJ4mEx+y4jVF0RVGSR2b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5098 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA81A106 smtp.mailfrom=sodey@rbbn.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: rbbn.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v2] net/i40e: issue with ADD VLAN from Guest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reset the configuration of vlan strip that would be change by the pf kernel driver when adding vlan from vf. Application cannot use rte_eth_dev_set_vlan_offload() to set the VLAN_STRIP, as this will only work for the first time when original and current config mismatch, but for all subsequent call it will be ignored. Signed-off-by: Souvik Dey --- v2: * Simplied the commit log. * goto err; is not required as it has only one more return path and there is no cleanup required apart from just return err. * Updated the comment start from /* -> /** * Changed the error log in case vlan strip command fails. --- drivers/net/i40e/i40e_ethdev_vf.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethd= ev_vf.c index c26b036..d3dbcb5 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -1078,8 +1078,19 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vl= anid) =09args.out_buffer =3D vf->aq_resp; =09args.out_size =3D I40E_AQ_BUF_SZ; =09err =3D i40evf_execute_vf_cmd(dev, &args); -=09if (err) +=09if (err) { =09=09PMD_DRV_LOG(ERR, "fail to execute command OP_ADD_VLAN"); +=09=09return err; +=09} +=09/** +=09 * In linux kernel driver on receiving ADD_VLAN it enables +=09 * VLAN_STRIP by default. So reconfigure the vlan_offload +=09 * as it was done by the app earlier. +=09 */ +=09err =3D i40evf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK); +=09if (err) +=09=09PMD_DRV_LOG(ERR, "fail to set vlan_strip " +=09=09=09"as a part of OP_ADD_VLAN"); =20 =09return err; } --=20 2.9.3.windows.1