From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7ECB2A09E9; Tue, 15 Dec 2020 07:15:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9631FC97C; Tue, 15 Dec 2020 07:15:01 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 16293C97C for ; Tue, 15 Dec 2020 07:14:58 +0100 (CET) IronPort-SDR: DaYrDvLK6hk38+WDZ3Qfa/H61hLhhDsF8vTEpLwgHwgBkDeYY9IrnRDOm20rQBqPWD48iKu/7B 8XuE1KXGnGew== X-IronPort-AV: E=McAfee;i="6000,8403,9835"; a="174941690" X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="174941690" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 22:14:56 -0800 IronPort-SDR: iolKH+MzQdTSdJJpeRtBlmWyiL/NkkywrOsNuZFHFEE5P1kF5qegfh+/55+ltDj4UaDIpqtTE1 MUyt/g+tAF5A== X-IronPort-AV: E=Sophos;i="5.78,420,1599548400"; d="scan'208";a="336617129" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.136]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2020 22:14:53 -0800 From: Steve Yang To: dev@dpdk.org Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, ferruh.yigit@intel.com, qi.z.zhang@intel.com, Steve Yang Date: Tue, 15 Dec 2020 06:12:34 +0000 Message-Id: <20201215061234.36276-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH v1] app/testpmd: fix default RSS hash not accurate X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When testpmd launched, the default RSS hash function will only activate 'ETH_RSS_IP', it isn't consistent with the command result of 'port config all rss default'. Removed the default 'rss_hf' limited in 'init_port_config', that will use the default supported RSS hash function for NIC. Fixes: 9089296206ce ("app/testpmd: fix config due to RSS offload check") Signed-off-by: Steve Yang --- app/test-pmd/testpmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 33fc0fddf5..ed6b438950 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3505,7 +3505,7 @@ init_port_config(void) if (nb_rxq > 1) { port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL; port->dev_conf.rx_adv_conf.rss_conf.rss_hf = - rss_hf & port->dev_info.flow_type_rss_offloads; + port->dev_info.flow_type_rss_offloads; } else { port->dev_conf.rx_adv_conf.rss_conf.rss_key = NULL; port->dev_conf.rx_adv_conf.rss_conf.rss_hf = 0; -- 2.17.1