From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 593F4A09EE; Tue, 15 Dec 2020 14:28:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4DB08CA2E; Tue, 15 Dec 2020 14:28:33 +0100 (CET) Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [63.128.21.181]) by dpdk.org (Postfix) with ESMTP id 3F181CA26 for ; Tue, 15 Dec 2020 14:28:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1608038910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SwtOkWgGqceV3V0taaJoGUgPdMM6qSEnsLOovwn92kA=; b=H2KwfHuDID9QYPFK87dJx7/xUHIRPFSxzEk+euL7aEgy6CbUzlCpTQQiyu3ah1oAIimI8t lv10YC7qF5DsWvJX4KIjb0z+07B4M+prdUZuhs2pFUVL991MvSMSwbivADdr/9EU0Rwhug 4JjS1TdgBP99Coq0WmnVO1LcC4nf4fg= Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam08lp2042.outbound.protection.outlook.com [104.47.73.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-tWWFzBE_PlS9DcHGnggNCQ-1; Tue, 15 Dec 2020 08:28:29 -0500 X-MC-Unique: tWWFzBE_PlS9DcHGnggNCQ-1 Received: from DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) by DM6PR03MB5306.namprd03.prod.outlook.com (2603:10b6:5:243::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.14; Tue, 15 Dec 2020 13:28:28 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::5cc0:8293:cf4f:44f4%6]) with mapi id 15.20.3654.025; Tue, 15 Dec 2020 13:28:28 +0000 From: Souvik Dey To: beilei.xing@intel.com, jia.guo@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, Souvik Dey Date: Tue, 15 Dec 2020 08:28:15 -0500 Message-Id: <20201215132815.15200-1-sodey@rbbn.com> X-Mailer: git-send-email 2.9.3.windows.1 In-Reply-To: <20201212130525.14656-1-sodey@rbbn.com> References: <20201212130525.14656-1-sodey@rbbn.com> X-Originating-IP: [72.70.55.110] X-ClientProxiedBy: BL0PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:91::23) To DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from SODEY-LMA.sonusnet.com (72.70.55.110) by BL0PR05CA0013.namprd05.prod.outlook.com (2603:10b6:208:91::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.3676.12 via Frontend Transport; Tue, 15 Dec 2020 13:28:26 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 251bd4a0-67ba-440e-4d08-08d8a0fd4eb6 X-MS-TrafficTypeDiagnostic: DM6PR03MB5306: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0 X-Microsoft-Antispam-Message-Info: CZatG51l03iuRmLw+VV/oAmyp9nj+7feB8m4R+IgzIALVv7U+DRt3pq8MOPT6XLGEBnhRl8sKxMsXl+7/V/YjOmV+h2PGXrl6dzgBfRnz/ZnMRY6FcPy40jEGtgDUv0stqmAWOthnvixkayqC7sInw1oIBTVaNUNVXlaT2w9U8llY3imlklDN+o8yr7bpDeX6HG2OwMvwphcNcSh/UFeHsjobW/x3LegBoWgoMhL+eYG2j5zu4D7yUvj+vL0A+dmXvVP/pY87nQrmSCjQ1FAeQ6PyiLTj7Kv04eY4Sftp4AdxKx3bgnkSR7yEPtIKlSXOyoN1fkZuBVljrb+Bzw5jIcBsj5bo9+pR5ibfsfrnKlnT3b7Eb5AE851ixVm8Bqv X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR03MB4777.namprd03.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(136003)(6666004)(6486002)(36756003)(956004)(34490700003)(66476007)(16526019)(186003)(52116002)(66946007)(6506007)(6512007)(8676002)(66556008)(107886003)(2616005)(8936002)(2906002)(83380400001)(4326008)(508600001)(26005)(86362001)(5660300002)(1076003); DIR:OUT; SFP:1101 X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?0O7tFCXN6a5mkxaUIwBPfHb/u33xfeO5/5GHHKbwFZQ0yXJzn7VlMX93mCml?= =?us-ascii?Q?ArhjutEN6g6TflgbP8035S6dbx4SvRNCyKiGfSOYRKVwvB6kLy+6b93H/z+L?= =?us-ascii?Q?61oy9CwGC2HHOJlsXhfsX0ZJlJQRKj6g5HQCZ4hAKWoQSY+Vep8ixxQO7bsa?= =?us-ascii?Q?OlwUw9CzZqWwpJcBxr+L/af6KOOdaba7hW/g+1NzO/3d7wZ7YgEOuip7oiBG?= =?us-ascii?Q?eVB8v9HtCVAD8uqNQ+9CfMs0gcwXt4aeLPDzUw7Lcdx63OgdC6EEGCYtzxNt?= =?us-ascii?Q?ygrNJlP9odXTR+BSwLzLqyfVUssRnAQoIqofZOQ+51/0tMlBcSM+8NeHyE9E?= =?us-ascii?Q?nxWGkOMwNoEOyc/vOzvG86uG4RNshj2rqBkC/BjRYetQS5ZZKdoRu/h0Ln/s?= =?us-ascii?Q?IL+eIzJx7FOVWLy7//yceR4MoNBAHRdih0XiNd6u1n5gLYiYM4rc2xNHZPOB?= =?us-ascii?Q?kNeQDx/A7T0fcQeIAhKglMJShy0AHS1/o4sMh0qiJoTOBuy/bzeRSxe1stRg?= =?us-ascii?Q?LYRONUDgTmegmLeJr9cJBib9ZAI8URWBgddtMA7h8biQY32b13WlE+z3vd3O?= =?us-ascii?Q?loaQ8m2NnDy+KaSwD4jELGmLTCB6gZb8IBnXhsu8eKZ9gEH4Xq0rV7bJp+Bx?= =?us-ascii?Q?kTyZkJQdsXae/9xOVnvX9x7kmOlo+debPLCvC4TLjamRjl6eLDivB2UaEyGU?= =?us-ascii?Q?OsfJnMCllD2bBg8y2+upRXPDKSSxsXi74JvtRfkASxfF7WD94F9MZUtFCJPr?= =?us-ascii?Q?ypoA5m9HFUYMCP5ZeRnImi0pCp64NQqKwPx6TY+Gu7NsACEqfFgEAFJJq0+C?= =?us-ascii?Q?5SNrQVBJ0lyBGdb52Wy6L6YKryVi0hwZmP7Xbp8PPgxG0j2D24QEgB5T0wGI?= =?us-ascii?Q?0R0EwPybxIcfMgX7VSIEby6kqJRdpdamZcrlqZWq2a25KA/R5/z/7pK+9jx0?= =?us-ascii?Q?qNh3NMILAXCAHNpPt0hZq34QgipXR8xUiidELVyZufb28o3I1BYwyczOMSmr?= =?us-ascii?Q?Sb+4?= X-OriginatorOrg: rbbn.com X-MS-Exchange-CrossTenant-AuthSource: DM6PR03MB4777.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2020 13:28:28.0015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 X-MS-Exchange-CrossTenant-Network-Message-Id: 251bd4a0-67ba-440e-4d08-08d8a0fd4eb6 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fJq6v9Vybwc2BJBzQIJBVMCvpwz2JOHxfzj/J8k1uw5zKj/UGQByE8/xLKRnr7Cd X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5306 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA81A106 smtp.mailfrom=sodey@rbbn.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: rbbn.com Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Subject: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reset the configuration of vlan strip that would be change by the pf kernel driver when adding vlan from vf. Application cannot use rte_eth_dev_set_vlan_offload() to set the VLAN_STRIP, as this will only work for the first time when original and current config mismatch, but for all subsequent call it will be ignored. Signed-off-by: Souvik Dey --- v3: * Changed the error log in case vlan strip command fails as per the latest comment. --- v2: * Simplied the commit log. * goto err; is not required as it has only one more return path and there is no cleanup required apart from just return err. * Updated the comment start from /* -> /** * Changed the error log in case vlan strip command fails. --- drivers/net/i40e/i40e_ethdev_vf.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethd= ev_vf.c index c26b036..2faee1d 100644 --- a/drivers/net/i40e/i40e_ethdev_vf.c +++ b/drivers/net/i40e/i40e_ethdev_vf.c @@ -1078,8 +1078,18 @@ i40evf_add_vlan(struct rte_eth_dev *dev, uint16_t vl= anid) =09args.out_buffer =3D vf->aq_resp; =09args.out_size =3D I40E_AQ_BUF_SZ; =09err =3D i40evf_execute_vf_cmd(dev, &args); -=09if (err) +=09if (err) { =09=09PMD_DRV_LOG(ERR, "fail to execute command OP_ADD_VLAN"); +=09=09return err; +=09} +=09/** +=09 * In linux kernel driver on receiving ADD_VLAN it enables +=09 * VLAN_STRIP by default. So reconfigure the vlan_offload +=09 * as it was done by the app earlier. +=09 */ +=09err =3D i40evf_vlan_offload_set(dev, ETH_VLAN_STRIP_MASK); +=09if (err) +=09=09PMD_DRV_LOG(ERR, "fail to set vlan_strip"); =20 =09return err; } --=20 2.9.3.windows.1