From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 2013CA09F0;
Wed, 16 Dec 2020 17:51:18 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 8506ACA02;
Wed, 16 Dec 2020 17:50:10 +0100 (CET)
Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])
by dpdk.org (Postfix) with ESMTP id B7853C9DC
for <dev@dpdk.org>; Wed, 16 Dec 2020 17:50:04 +0100 (CET)
Received: from Internal Mail-Server by MTLPINE1 (envelope-from
ophirmu@nvidia.com) with SMTP; 16 Dec 2020 18:49:58 +0200
Received: from nvidia.com (pegasus05.mtr.labs.mlnx [10.210.16.100])
by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 0BGGnvcx005924;
Wed, 16 Dec 2020 18:49:58 +0200
From: Ophir Munk <ophirmu@nvidia.com>
To: Ori Kam <orika@nvidia.com>, dev@dpdk.org,
Raslan Darawsheh <rasland@nvidia.com>
Cc: Ophir Munk <ophirmu@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>
Date: Wed, 16 Dec 2020 16:49:31 +0000
Message-Id: <20201216164931.1517-7-ophirmu@nvidia.com>
X-Mailer: git-send-email 2.8.4
In-Reply-To: <20201216164931.1517-1-ophirmu@nvidia.com>
References: <20201216164931.1517-1-ophirmu@nvidia.com>
Subject: [dpdk-dev] [PATCH v1 6/6] app/regex: replace Linux clock() API with
rdtsc
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Performance measurement (elapsed time and Gbps) are based on Linux
clock() API. The resolution is improved by replacing the clock() API
with rte_rdtsc_precise() API.
Signed-off-by: Ophir Munk <ophirmu@nvidia.com>
---
app/test-regex/main.c | 32 ++++++++++++++------------------
1 file changed, 14 insertions(+), 18 deletions(-)
diff --git a/app/test-regex/main.c b/app/test-regex/main.c
index f305186..ce0ede2 100644
--- a/app/test-regex/main.c
+++ b/app/test-regex/main.c
@@ -48,8 +48,8 @@ struct qp_params {
struct rte_regex_ops **ops;
struct job_ctx *jobs_ctx;
char *buf;
- time_t start;
- time_t end;
+ uint64_t start;
+ uint64_t cycles;
};
struct qps_per_lcore {
@@ -326,7 +326,7 @@ run_regex(void *args)
unsigned long d_ind = 0;
struct rte_mbuf_ext_shared_info shinfo;
int res = 0;
- double time;
+ long double time;
struct rte_mempool *mbuf_mp;
struct qp_params *qp;
struct qp_params *qps = NULL;
@@ -419,7 +419,7 @@ run_regex(void *args)
qp->buf = buf;
qp->total_matches = 0;
qp->start = 0;
- qp->end = 0;
+ qp->cycles = 0;
}
for (i = 0; i < nb_iterations; i++) {
@@ -432,9 +432,8 @@ run_regex(void *args)
update = false;
for (qp_id = 0; qp_id < nb_qps; qp_id++) {
qp = &qps[qp_id];
- if (!qp->start)
- qp->start = clock();
if (qp->total_dequeue < actual_jobs) {
+ qp->start = rte_rdtsc_precise();
struct rte_regex_ops **
cur_ops_to_enqueue = qp->ops +
qp->total_enqueue;
@@ -463,24 +462,21 @@ run_regex(void *args)
cur_ops_to_dequeue,
qp->total_enqueue -
qp->total_dequeue);
+ qp->cycles +=
+ (rte_rdtsc_precise() - qp->start);
update = true;
- } else {
- if (!qp->end)
- qp->end = clock();
}
-
}
} while (update);
}
for (qp_id = 0; qp_id < nb_qps; qp_id++) {
- time = ((double)qp->end - qp->start) / CLOCKS_PER_SEC;
- printf("Core=%u QP=%u\n", rte_lcore_id(), qp_id + qp_id_base);
- printf("Job len = %ld Bytes\n", job_len);
- printf("Time = %lf sec\n", time);
- printf("Perf = %lf Gbps\n\n",
- (((double)actual_jobs * job_len *
- nb_iterations * 8) / time) /
- 1000000000.0);
+ qp = &qps[qp_id];
+ time = (long double)qp->cycles / rte_get_timer_hz();
+ printf("Core=%u QP=%u Job=%ld Bytes Time=%Lf sec Perf=%Lf "
+ "Gbps\n", rte_lcore_id(), qp_id + qp_id_base,
+ job_len, time,
+ (((double)actual_jobs * job_len * nb_iterations * 8)
+ / time) / 1000000000.0);
}
if (rgxc->perf_mode)
--
2.8.4