From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D7B6A09F0; Wed, 16 Dec 2020 22:14:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7298EC9F8; Wed, 16 Dec 2020 22:13:28 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by dpdk.org (Postfix) with ESMTP id 58209C9F4 for ; Wed, 16 Dec 2020 22:13:26 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id lb18so2186803pjb.5 for ; Wed, 16 Dec 2020 13:13:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=gT6fDbNlBmyMYs8f4TN40mLmSI4OV6XjleSE48+xbG8=; b=A4mCMGzTpiMbVwKtnLvOuR6hqBW9drtqAFLGKjigCJBv1hWZYDj5ZJg0569VFhlNH0 X5yhfRTuHrinGdI1bWKQBXGEapul7XDAUfY3h+mDnw/P8MMLZqKJZYoS8JL9KsTjtD8t +wXYMyFw0u/cYSzkfp+37gbvO5UIH4qCSI0Ql5S21Qo+JfW5A9VZqvlsqcck542o4dYL wcaft174yWOFsNurk6hML/B7SCXOyg6yPjXFA8YmeSb/n6W0CqxMErarcvFouQSUp96P XAMnuuN7O4FCVzXe4jBXe+4E8PGgfuW/bnqByJQR6WhOlTieZqyDiPT8CDmsUqmoT8Ig YgQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=gT6fDbNlBmyMYs8f4TN40mLmSI4OV6XjleSE48+xbG8=; b=lp/H6FiVjtv/QPyc6FJB2hsLa8MYFXGMLwD2mGMQrMb86GxoMDVVghB9zkuqrpN1w2 4AuQ0mqNqpf5W43tnoU/u0uRIBpSCgBI/zv4WYyPCmhjMl5NkjaqFvUI2EV1h2iuMUa7 2patS4MVR3XUtzwW4OY7SeA1I8snTEBsP8eAqIM1eD4afiLK/Cw03NffCCrlGj2oirIx exuhHytCrW7g5Tcl7I9QbbA1LVwM0OHijBgpHGFnmRQpGY6fQQSMbahsTnsbogZgyaaN eEHhyWLRQyBYmmtWWomBK6k96j8cD4BzVYK62DWGO+CcnF4E0JiJHN0g3ik/QKSWmQ8y aa+g== X-Gm-Message-State: AOAM532eauerBG378Zdn8PTDMTUxKPNK3uURd4Kg5nDmLsO+KflAf507 CKy/WHrat/ZaUSFpGK1JpIcAEZx7eY9Thg== X-Google-Smtp-Source: ABdhPJxAsI04woqWkYCNwfMWgxbxQgtZJqBMjmK2RnrfhfrKFrX9knR6MNM2h4CgfFMnTvPcErxFCg== X-Received: by 2002:a17:90a:bb83:: with SMTP id v3mr4652082pjr.28.1608153204402; Wed, 16 Dec 2020 13:13:24 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id r67sm3345614pfc.82.2020.12.16.13.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Dec 2020 13:13:23 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Wed, 16 Dec 2020 13:12:52 -0800 Message-Id: <20201216211257.37195-3-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201216211257.37195-1-aboyer@pensando.io> References: <20201216211257.37195-1-aboyer@pensando.io> In-Reply-To: <20201210142231.63209-1-aboyer@pensando.io> References: <20201210142231.63209-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH v2 2/7] net/ionic: preserve Rx mode across LIF stop/start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Otherwise, non-default settings (like PROMISC) get reset. This will become important when link toggling is tied to LIF stop/start. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 646c921b2..875c7e585 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -1573,7 +1573,7 @@ ionic_lif_configure(struct ionic_lif *lif) int ionic_lif_start(struct ionic_lif *lif) { - uint32_t rx_mode = 0; + uint32_t rx_mode; uint32_t i; int err; @@ -1581,16 +1581,16 @@ ionic_lif_start(struct ionic_lif *lif) if (err) return err; - IONIC_PRINT(DEBUG, "Setting RX mode on port %u", - lif->port_id); - - rx_mode |= IONIC_RX_MODE_F_UNICAST; - rx_mode |= IONIC_RX_MODE_F_MULTICAST; - rx_mode |= IONIC_RX_MODE_F_BROADCAST; + if (!lif->rx_mode) { + IONIC_PRINT(DEBUG, "Setting RX mode on %s", + lif->name); - lif->rx_mode = 0; /* set by ionic_set_rx_mode */ + rx_mode = IONIC_RX_MODE_F_UNICAST; + rx_mode |= IONIC_RX_MODE_F_MULTICAST; + rx_mode |= IONIC_RX_MODE_F_BROADCAST; - ionic_set_rx_mode(lif, rx_mode); + ionic_set_rx_mode(lif, rx_mode); + } IONIC_PRINT(DEBUG, "Starting %u RX queues and %u TX queues " "on port %u", -- 2.17.1