From: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
To: dev@dpdk.org
Cc: viktorin@cesnet.cz
Subject: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying
Date: Fri, 18 Dec 2020 13:08:23 +0100 [thread overview]
Message-ID: <20201218120823.30907-1-xvojan00@stud.fit.vutbr.cz> (raw)
This patch fixes a bug where firmware version was not
copied from ibv_device_attr structure into mlx5_dev_attr
structure, resulting in inability to read firmware
version.
Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
---
drivers/net/mlx5/linux/mlx5_os.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index 4c863db1a..37d17fc05 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -147,6 +147,7 @@ mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr)
#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
device_attr->tunnel_offloads_caps = dv_attr.tunnel_offloads_caps;
#endif
+ strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(device_attr->fw_ver));
return err;
}
--
2.17.1
next reply other threads:[~2020-12-18 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 12:08 Kamil Vojanec [this message]
2021-02-05 9:00 Kamil Vojanec
2021-05-06 9:34 ` Matan Azrad
2021-05-10 12:26 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201218120823.30907-1-xvojan00@stud.fit.vutbr.cz \
--to=xvojan00@stud.fit.vutbr.cz \
--cc=dev@dpdk.org \
--cc=viktorin@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).