* [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying
@ 2020-12-18 12:08 Kamil Vojanec
0 siblings, 0 replies; 4+ messages in thread
From: Kamil Vojanec @ 2020-12-18 12:08 UTC (permalink / raw)
To: dev; +Cc: viktorin
This patch fixes a bug where firmware version was not
copied from ibv_device_attr structure into mlx5_dev_attr
structure, resulting in inability to read firmware
version.
Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
---
drivers/net/mlx5/linux/mlx5_os.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index 4c863db1a..37d17fc05 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -147,6 +147,7 @@ mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr)
#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
device_attr->tunnel_offloads_caps = dv_attr.tunnel_offloads_caps;
#endif
+ strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(device_attr->fw_ver));
return err;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying
@ 2021-02-05 9:00 Kamil Vojanec
2021-05-06 9:34 ` Matan Azrad
2021-05-10 12:26 ` Raslan Darawsheh
0 siblings, 2 replies; 4+ messages in thread
From: Kamil Vojanec @ 2021-02-05 9:00 UTC (permalink / raw)
To: dev; +Cc: viktorin, Matan Azrad, Shahaf Shuler, Viacheslav Ovsiienko
This patch fixes a bug where firmware version was not
copied from ibv_device_attr structure into mlx5_dev_attr
structure, resulting in inability to read firmware
version.
Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
---
drivers/net/mlx5/linux/mlx5_os.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c
index a8cc5f311..fa35c06e7 100644
--- a/drivers/net/mlx5/linux/mlx5_os.c
+++ b/drivers/net/mlx5/linux/mlx5_os.c
@@ -152,6 +152,7 @@ mlx5_os_get_dev_attr(void *ctx, struct mlx5_dev_attr *device_attr)
#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
device_attr->tunnel_offloads_caps = dv_attr.tunnel_offloads_caps;
#endif
+ strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver, sizeof(device_attr->fw_ver));
return err;
}
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying
2021-02-05 9:00 Kamil Vojanec
@ 2021-05-06 9:34 ` Matan Azrad
2021-05-10 12:26 ` Raslan Darawsheh
1 sibling, 0 replies; 4+ messages in thread
From: Matan Azrad @ 2021-05-06 9:34 UTC (permalink / raw)
To: Kamil Vojanec, dev; +Cc: viktorin, Shahaf Shuler, Slava Ovsiienko
From: Kamil Vojanec
> This patch fixes a bug where firmware version was not copied from
> ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability
> to read firmware version.
>
> Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/linux/mlx5_os.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index a8cc5f311..fa35c06e7 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -152,6 +152,7 @@ mlx5_os_get_dev_attr(void *ctx, struct
> mlx5_dev_attr *device_attr) #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT
> device_attr->tunnel_offloads_caps = dv_attr.tunnel_offloads_caps;
> #endif
> + strlcpy(device_attr->fw_ver, attr_ex.orig_attr.fw_ver,
> + sizeof(device_attr->fw_ver));
>
> return err;
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying
2021-02-05 9:00 Kamil Vojanec
2021-05-06 9:34 ` Matan Azrad
@ 2021-05-10 12:26 ` Raslan Darawsheh
1 sibling, 0 replies; 4+ messages in thread
From: Raslan Darawsheh @ 2021-05-10 12:26 UTC (permalink / raw)
To: Kamil Vojanec, dev
Cc: viktorin, Matan Azrad, Shahaf Shuler, Slava Ovsiienko, stable
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Kamil Vojanec
> Sent: Friday, February 5, 2021 11:01 AM
> To: dev@dpdk.org
> Cc: viktorin@cesnet.cz; Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version
> copying
>
> This patch fixes a bug where firmware version was not copied from
> ibv_device_attr structure into mlx5_dev_attr structure, resulting in inability
> to read firmware version.
>
Added missing:
Fixes: e85f623e13ea ("net/mlx5: remove attributes dependency on Verbs")
Cc: stable@dpdk.org
> Signed-off-by: Kamil Vojanec <xvojan00@stud.fit.vutbr.cz>
> ---
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-10 12:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-18 12:08 [dpdk-dev] [PATCH] net/mlx5/linux: fix missing firmware version copying Kamil Vojanec
2021-02-05 9:00 Kamil Vojanec
2021-05-06 9:34 ` Matan Azrad
2021-05-10 12:26 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).