From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80E11A09EF; Mon, 21 Dec 2020 16:05:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE693CA8B; Mon, 21 Dec 2020 16:05:01 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id EFDD3CA89 for ; Mon, 21 Dec 2020 16:05:00 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BLF0KKu009316; Mon, 21 Dec 2020 07:04:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=pfpt0220; bh=l/1A+wACk/HBKrSU29pKlj6f2myuIFT4eGPE1B5siK4=; b=C0gN8xW/YsiB55dxFC/UvOdoeqbcdsNsYaHJ8IdCqvaha7Kc48nTnVtduxEqfiM1XO7t 49Nwrsu+aSgIN7p57D6AnouTT4W1z0Y4KAgBQJzdVkQx93kifOHcdBxqecWQeyGVbsBG QfeEgzgvGaGsvKxEJ9oV4g5ZV/m2a3GNK4w7h7ARwepwOr45QFO6dUm4eehDl3iuujOI ATtHp8aai1Xf5Xn1CT+0l0DJCbdxYBCTUaYbUBSt3lyOfT12mZlOLr/ldCbnl/TObtw8 xd+5O03ylpmC0HLwR3bg5VZWiQIZ9opXL+aadnZ4hO58i0awuX/e9s1n4WUGy/4gD6g4 hQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 35j4wvjh7s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 21 Dec 2020 07:04:53 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Dec 2020 07:04:51 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Dec 2020 07:04:50 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 21 Dec 2020 07:04:49 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxgaT1/N0SJgoxeS/ML+/OZ4LJLeseehEW6UzuU0ib9gYQDfawYjfvxBpizxjPQ8NE4we9eE9xDbES3LcMzsltaQasDIGKpQ59ThQLnrVOus7KB3q8BoqKx8pc3ZTvwiC+1/EZo1HZs0gyV8G56gEZC6yNxcFX5JU+6bCdjhk31KaunrLbTVDAfHtaTF5J1WihXclAhG6e0AWWhG8noQ5QQ2ux9WnGRyEqe2/RbdHenoJpLfidzzw9p6yzCniRzOvyTjnbkdGA+Ck+FB/LUILOISlfwKL80NBWRXh9CALSHo4LYsXhevVj82YM7SetlsDShxnAMy7dUAc5KB5BzEeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/1A+wACk/HBKrSU29pKlj6f2myuIFT4eGPE1B5siK4=; b=nlC3hRC2vKLjiKG4cApfCAxCF6tIlaQ/ts4BSDA7nAhSevzKkGZ+hc5+KVHzLEyGj4nnPf9SeAUw/a7Hj3Ec3AU4JyE/TjbcB0ZmfYv/2YlyMqqn8USiy7gG1gRPzkgKAsr2zEv0OFg0MAoLhLiohcnLiuNDT3HEQkjwbJAAXFFh+lZo/6i86f1rbGvJaqoC0khRcYh60VVuXeHj59XarGkBk+7BEwsGHDLf79ps+Qcl//VNld+BNvyzw+NMU0kSS1aP4ffW0dt1+lxc2HKSGmDu26xzohNV2MbR6lYPqrkk7xCKcMavBd7oZM2FgETNjP2jbnmLSLQ+jazEtyBzQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/1A+wACk/HBKrSU29pKlj6f2myuIFT4eGPE1B5siK4=; b=lx5liPyuGxoGTGNZsV8OWxMZG9+SJRs/KoHlElqRHzj9785YV//8Km58tZ/NlS0Zx9lSu2TWrbzd5dOVU7xO4yMXDHIMajv3fsXVdC4yb5MmOszafHdVTe6lJRLPSwdqjJRDnBtSXSBgyUoYU4KurkyOEZmot8BgA9tyarr3dYc= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; Received: from CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) by MW3PR18MB3594.namprd18.prod.outlook.com (2603:10b6:303:5f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Mon, 21 Dec 2020 15:04:47 +0000 Received: from CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c]) by CO6PR18MB3842.namprd18.prod.outlook.com ([fe80::444a:e47f:bdc:370c%7]) with mapi id 15.20.3676.033; Mon, 21 Dec 2020 15:04:46 +0000 Date: Mon, 21 Dec 2020 20:34:17 +0530 From: Harman Kalra To: Steve Yang CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Message-ID: <20201221150416.GA1462@outlook.office365.com> References: <20201209031628.29572-1-stevex.yang@intel.com> <20201217092312.27033-1-stevex.yang@intel.com> <20201217092312.27033-12-stevex.yang@intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201217092312.27033-12-stevex.yang@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Originating-IP: [1.6.215.26] X-ClientProxiedBy: MAXPR0101CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::17) To CO6PR18MB3842.namprd18.prod.outlook.com (2603:10b6:5:341::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from outlook.office365.com (1.6.215.26) by MAXPR0101CA0007.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.29 via Frontend Transport; Mon, 21 Dec 2020 15:04:30 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ab908986-2743-4c45-d175-08d8a5c1c1b0 X-MS-TrafficTypeDiagnostic: MW3PR18MB3594: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1265; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZU8f0Po0rqI6INxEIMj/hkJUn1XAG+TihygBaGM2iifnDUeU4/NYS4S+cFfuueKWCmoI7AQSpwFP0JrThr6tSanc+deGz+pu+XAwItQA6bfkI9O4usB4vFXDwARC9v5cTSFoD8vBQEG7tibsr5njGyceV6Y6MG1bNHc5xEkiFCHHATSgic5DI6MT5DyVq4gFLInPbRvFHPUvlAESJ8FOt1wiJPOQdZp6NhCwA7caYI1/YAvxHcqiYdVD2NgP/KaSCyVNvyZ8s4VGif1JkPPhpQ7+igegO+ntHpfMSf+retJEs5nyzGvI/HWj7hbkZSwmxRYfFnG1v4+d9cOjlTqp9iwY1JGr1uHHZ6ZuH4eUub0Ex5IuA2wDKLbwCEwnMdw2U8+M7xfd9COrzRI6vggpAdRMMAID1JFxbpMGRUGjzsXHl3DkHJsv9reT1hLrQvCKeLscu/NPuLky4lp2/VIAIw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO6PR18MB3842.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(366004)(39860400002)(396003)(346002)(55016002)(52116002)(66556008)(8676002)(66946007)(66476007)(6916009)(16526019)(9686003)(316002)(7416002)(86362001)(6506007)(7366002)(4326008)(7696005)(83380400001)(956004)(8936002)(2906002)(1076003)(478600001)(33656002)(1006002)(6666004)(186003)(26005)(7406005)(5660300002)(36456004)(42976004); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?T0SH5bDawsWQiqm+/AUfHuAoKSohoTwq+2RF7Lcj4BccAM23gGZy/9yEOuc3?= =?us-ascii?Q?70s+26kgkC+XNJuIz013fz2a/MqZhO/uR60xttP6x4Pt9KyfQM73cd1QhM9R?= =?us-ascii?Q?hHfMhxvPd/lMjasOQM6aFzFKiiwxrEKl2Ib5cljNwK8cdreHDBg616TuPPzI?= =?us-ascii?Q?EwskRZc4BFUVjGsnBO/pveunCtT8jt2ofbh+72Qo4fjOtLw1kvrv7nFUH0Pf?= =?us-ascii?Q?nYlZTFcTBZxH8g52myiIcBeOHo3+LtxbeoAkdkRone/7zowxGdYS+ec6S3v1?= =?us-ascii?Q?THusDffWrs3ymT38TiraDrpNx1BWbbaRH49KjT2TAObm+QSu6qemf1cPo5zx?= =?us-ascii?Q?xaSd7yQamyMvd6iiJac5ndJdoRv421T/Zk9ExEWWgl7ZeiyuHxvLUIrtwnSn?= =?us-ascii?Q?lVVzKBKTfmtuJ7v24RF8XK93QZhgSgqCXh9fiJCmg0u26k2koVOvw7TjObw3?= =?us-ascii?Q?hLow9r1R6KfdmqFnq4P5D1151fu9JuJaP6fXyHcZXIqGrmazlqMeBty00Kt2?= =?us-ascii?Q?fLgSNtArCdDEmA/k7DBl2fkWo+GlublhrZQnSNTS3w+/5wjpX6GLmASJ74B4?= =?us-ascii?Q?zT3SJUXOrleBsFj6bu5HARVs344wa0ymIVwwD/1rvGhMNcaiRi2QisJr97h2?= =?us-ascii?Q?wEEuG8X7pP3Cbwq4A5M7QV6zZy0EkPokHg2w2vHliWfBMcYLUoSLyQmi2BJi?= =?us-ascii?Q?o2UqqyarrmYXspN2VKXW4bvAyITjiuqTSrCRo62zZ0j9LiQjZbw87+BaRamz?= =?us-ascii?Q?S5R0TdPWh4RHho/lsQupoR0wXfEFwxEEQdvOOEHSoK6VkU/OahMKJ+V7NNrb?= =?us-ascii?Q?fdfqT7U3D4Vu56KAylmMBsL2VpFVW9b8oE3j4eN6W6fdhDHWqUywD6PSl91b?= =?us-ascii?Q?PgbOptmj02gTl36n0lkKzXKppOrbRjh9KHqlzgOg6D6hrgMTGnTMDFTcbqR2?= =?us-ascii?Q?da+SNU/6z8rHo8mQceqk3povWjt0qnbbQBvWRCmgH48=3D?= X-MS-Exchange-CrossTenant-AuthSource: CO6PR18MB3842.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2020 15:04:46.6670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-Network-Message-Id: ab908986-2743-4c45-d175-08d8a5c1c1b0 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T4UITg3xWbWX2LYXCs4GvBynwnEoCp/aBvGcgh+vZXlOBPluNa2R7odmlmkxugC49OxaZHUWGfJ6lB78gBy7Cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3594 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-21_08:2020-12-21, 2020-12-21 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH v2 11/22] net/octeontx: fix the jumbo frame flag condition for mtu set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Dec 17, 2020 at 09:23:01AM +0000, Steve Yang wrote: > External Email > > ---------------------------------------------------------------------- > The jumbo frame uses the 'RTE_ETHER_MAX_LEN' as boundary condition, but > the Ether overhead is larger than 18 when it supports dual VLAN tags. > That will cause the jumbo flag rx offload is wrong when MTU size is > 'RTE_ETHER_MTU'. > > This fix will change the boundary condition with 'RTE_ETHER_MTU' and > overhead. > > Fixes: 3151e6a687a3 ("net/octeontx: support MTU") > > Signed-off-by: Steve Yang Acked-by: Harman Kalra > --- > drivers/net/octeontx/octeontx_ethdev.c | 2 +- > drivers/net/octeontx/octeontx_ethdev.h | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c > index 3ee7b043fd..81779885d5 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.c > +++ b/drivers/net/octeontx/octeontx_ethdev.c > @@ -552,7 +552,7 @@ octeontx_dev_mtu_set(struct rte_eth_dev *eth_dev, uint16_t mtu) > if (rc) > return rc; > > - if (frame_size > RTE_ETHER_MAX_LEN) > + if (frame_size > OCCTX_L2_MAX_LEN) > nic->rx_offloads |= DEV_RX_OFFLOAD_JUMBO_FRAME; > else > nic->rx_offloads &= ~DEV_RX_OFFLOAD_JUMBO_FRAME; > diff --git a/drivers/net/octeontx/octeontx_ethdev.h b/drivers/net/octeontx/octeontx_ethdev.h > index 7246fb6d1d..780a094ffa 100644 > --- a/drivers/net/octeontx/octeontx_ethdev.h > +++ b/drivers/net/octeontx/octeontx_ethdev.h > @@ -44,6 +44,7 @@ > /* ETH_HLEN+ETH_FCS+2*VLAN_HLEN */ > #define OCCTX_L2_OVERHEAD (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + \ > OCCTX_MAX_VTAG_ACT_SIZE) > +#define OCCTX_L2_MAX_LEN (RTE_ETHER_MTU + OCCTX_L2_OVERHEAD) > > /* Since HW FRS includes NPC VTAG insertion space, user has reduced FRS */ > #define OCCTX_MAX_FRS \ > -- > 2.17.1 >