From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D406A09EF; Tue, 22 Dec 2020 04:24:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9F7A7CCC7; Tue, 22 Dec 2020 04:23:06 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 727B5CCAD for ; Tue, 22 Dec 2020 04:23:03 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E980E30E; Mon, 21 Dec 2020 19:23:02 -0800 (PST) Received: from net-x86-dell-8268.shanghai.arm.com (net-x86-dell-8268.shanghai.arm.com [10.169.210.131]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 542D43F718; Mon, 21 Dec 2020 19:23:01 -0800 (PST) From: Feifei Wang To: Jerin Jacob Cc: dev@dpdk.org, nd@arm.com, Feifei Wang Date: Tue, 22 Dec 2020 11:22:37 +0800 Message-Id: <20201222032237.36046-7-feifei.wang2@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201222032237.36046-1-feifei.wang2@arm.com> References: <20201222032237.36046-1-feifei.wang2@arm.com> Subject: [dpdk-dev] [RFC PATCH v1 6/6] app/eventdev: remove unnecessary barriers for order test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" For the wmb in order_process_stage_1 and order_process_stage_invalid in the order test, they can be removed. This is because when the test results are wrong, the worker core writes 'true' to t->err. Then other worker cores, producer cores and the main core will load the 'error' index and stop testing. So, for the worker cores, no other storing operation needs to be guaranteed after this when errors happen. Signed-off-by: Feifei Wang Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- app/test-eventdev/test_order_common.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h index 5ef840493..cd9d6009e 100644 --- a/app/test-eventdev/test_order_common.h +++ b/app/test-eventdev/test_order_common.h @@ -104,7 +104,6 @@ order_process_stage_1(struct test_order *const t, flow, *order_mbuf_seqn(t, ev->mbuf), expected_flow_seq[flow]); t->err = true; - rte_smp_wmb(); } /* * Events from an atomic flow of an event queue can be scheduled only to @@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order *const t, { evt_err("invalid queue %d", ev->queue_id); t->err = true; - rte_smp_wmb(); } #define ORDER_WORKER_INIT\ -- 2.17.1