DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array
Date: Wed, 23 Dec 2020 18:01:02 +0530
Message-ID: <20201223123100.GA1776@chelsio.com> (raw)
In-Reply-To: <dd937157-b1f4-be98-bd93-ba001cc4babc@huawei.com>

On Monday, December 12/21/20, 2020 at 17:07:21 +0800, Min Hu (Connor) wrote:
> 
> 
> 在 2020/12/21 6:47, Rahul Lakkireddy 写道:
> >From: Karra Satwik <kaara.satwik@chelsio.com>
> >
> >Start from index 0 when going through the FEC array. This will allow
> >"off" to get printed for RTE_ETH_FEC_NOFEC mode.
> >
> >Fixes: b19da32e3151 ("app/testpmd: add FEC command")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
> >Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
> >---
> >  app/test-pmd/config.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> >index 3f6c8642b..a6a5baa4e 100644
> >--- a/app/test-pmd/config.c
> >+++ b/app/test-pmd/config.c
> >@@ -3701,7 +3701,7 @@ show_fec_capability(unsigned int num, struct rte_eth_fec_capa *speed_fec_capa)
> >  		printf("%s : ",
> >  			rte_eth_link_speed_to_str(speed_fec_capa[i].speed));
> >-		for (j = RTE_ETH_FEC_AUTO; j < RTE_DIM(fec_mode_name); j++) {
> >+		for (j = 0; j < RTE_DIM(fec_mode_name); j++) {
> 
> As RTE_ETH_FEC_NOFEC is mode which every device  has, so we think it
> should not be regarged as "capabilities".
> Thanks.
> 

We had gotten several requests asking if device supported turning
FEC "off" because it was not listed in capabilities. Hence, the
motiviation for this patch to explicitly show that "off" is
supported.


> >  			if (RTE_ETH_FEC_MODE_TO_CAPA(j) &
> >  						speed_fec_capa[i].capa)
> >  				printf("%s ", fec_mode_name[j].name);
> >

  reply	other threads:[~2020-12-23 12:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-20 22:47 Rahul Lakkireddy
2020-12-20 22:47 ` [dpdk-dev] [PATCH] app/testpmd: increase array for fetching supported FEC caps Rahul Lakkireddy
2020-12-23  6:02   ` Li, Xiaoyun
2020-12-23 12:25   ` [dpdk-dev] [PATCH v2] " Rahul Lakkireddy
2020-12-24 11:18     ` [dpdk-dev] [PATCH v3] " Rahul Lakkireddy
2020-12-25  1:06       ` Min Hu (Connor)
2021-01-15 15:27         ` Ferruh Yigit
2020-12-24  7:53   ` [dpdk-dev] [PATCH] " Min Hu (Connor)
2020-12-21  9:07 ` [dpdk-dev] [PATCH] app/testpmd: fix start index for showing FEC array Min Hu (Connor)
2020-12-23 12:31   ` Rahul Lakkireddy [this message]
2020-12-25 13:49     ` Rahul Lakkireddy
2020-12-23  6:07 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2021-01-15 13:53   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201223123100.GA1776@chelsio.com \
    --to=rahul.lakkireddy@chelsio.com \
    --cc=dev@dpdk.org \
    --cc=humin29@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git