From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F89BA09FF; Thu, 24 Dec 2020 07:33:51 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 40079C9C4; Thu, 24 Dec 2020 07:33:49 +0100 (CET) Received: from dish-sg.nttdocomo.co.jp (dish-sg.nttdocomo.co.jp [202.19.227.74]) by dpdk.org (Postfix) with ESMTP id 87AA8C9C0 for ; Thu, 24 Dec 2020 07:33:47 +0100 (CET) X-dD-Source: Outbound Received: from zssg-mailmd101.ddreams.local (zssg-mailmd900.ddreams.local [10.160.172.63]) by zssg-mailou104.ddreams.local (Postfix) with ESMTP id A15ED1200E6; Thu, 24 Dec 2020 15:33:44 +0900 (JST) Received: from t131sg-mailcc111.ddreams.local (t131sg-mailcc111.ddreams.local [100.66.31.221]) by zssg-mailmd101.ddreams.local (dDREAMS) with ESMTP id <0QLT00NJVZK8OUE0@dDREAMS>; Thu, 24 Dec 2020 15:33:44 +0900 (JST) Received: from t131sg-mailcc112.ddreams.local (localhost [127.0.0.1]) by t131sg-mailcc111.ddreams.local (unknown) with SMTP id 0BO6Xi63047370; Thu, 24 Dec 2020 15:33:44 +0900 Received: from zssg-mailmf101.ddreams.local (unknown [127.0.0.1]) by zssg-mailmf101.ddreams.local (Postfix) with ESMTP id 0877E7E6036; Thu, 24 Dec 2020 15:33:20 +0900 (JST) Received: from zssg-mailmf101.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0130E8E6054; Thu, 24 Dec 2020 15:33:20 +0900 (JST) Received: from localhost (unknown [127.0.0.1]) by IMSVA (Postfix) with SMTP id F30658E6055; Thu, 24 Dec 2020 15:33:19 +0900 (JST) X-IMSS-HAND-OFF-DIRECTIVE: localhost:10026 Received: from zssg-mailmf101.ddreams.local (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 51D7B8E6055; Thu, 24 Dec 2020 15:33:19 +0900 (JST) Received: from zssg-mailua105.ddreams.local (unknown [10.160.172.62]) by zssg-mailmf101.ddreams.local (Postfix) with ESMTP; Thu, 24 Dec 2020 15:33:19 +0900 (JST) Received: from [10.87.198.18] (unknown [10.160.183.129]) by zssg-mailua105.ddreams.local (dDREAMS) with ESMTPA id <0QLT009EDZJB4683@dDREAMS>; Thu, 24 Dec 2020 15:33:12 +0900 (JST) Date: Thu, 24 Dec 2020 15:33:11 +0900 From: Hideyuki Yamashita In-reply-to: <20201206094711.67109aad@hermes.local> References: <20201204075109.14694-6-yamashita.hideyuki@ntt-tx.co.jp> <20201206094711.67109aad@hermes.local> Message-id: <20201224153311.9D91.17218CA3@ntt-tx.co.jp> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Becky! ver. 2.75.01 [ja] X-TM-AS-GCONF: 00 To: Stephen Hemminger Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Ray Kinsella , Neil Horman , Anatoly Burakov , dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 5/5] librte_ethdev: add to use apistats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, Thanks for your feedback. > On Fri, 04 Dec 2020 16:51:09 +0900 > Hideyuki Yamashita wrote: > > > + > > +/* Macros for printing using RTE_LOG */ > > +#define RTE_LOGTYPE_APISTATS RTE_LOGTYPE_USER1 > > + > > Please don't use static logtypes. > Better to allocate a dynamic logtype value and use that. I understand you are saying to use the following. I will incorporate your comments in upcoming revised patch set. #define RTE_LOG_REGISTER ( type, name, level ) https://doc.dpdk.org/api/rte__log_8h.html Thanks! BR, Hideyuki Yamahista NTT TechnoCross