From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 506A6A09FF; Fri, 25 Dec 2020 04:04:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8530BCA5C; Fri, 25 Dec 2020 04:04:37 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by dpdk.org (Postfix) with ESMTP id 9F019CA1A for ; Fri, 25 Dec 2020 04:04:35 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id lb18so1886566pjb.5 for ; Thu, 24 Dec 2020 19:04:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pJxQKPbZVtUqZ9KtoF5aQuNSJhi4D5QsL7RGZuZv554=; b=LJT0wTOnslqCMeUqIlPoKv3T5Ki1R4ZGDMJBwyznVfgMRdqxJz/QbN7xP0MdGYhgCy 3uMwlQw4i2/uKgH2j/b7DNImrPUXMhF6j3J8isB1Tq3SHqEUSNRjbX5Mf8jOFo3B0avD DJzQkM9ZmI3IeaDzzKmgGNsT728sGYseB/X0u+Iwto1E/h/46Id7EnVl+8IGd8KwXUQg tfeOSj9mJWEvIUalH8CvMAkH3Az3kccIfK3h9fBUCP3z/RVzuofKMeVnuy0vK8EWRLxD R4tRCsIsFAjlG0IeLjN3QkdZNSB0JZbkjdg+eaqgOHaN4Xhcd07JJXssnys/qUrpw1LS qmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pJxQKPbZVtUqZ9KtoF5aQuNSJhi4D5QsL7RGZuZv554=; b=tj71boKSbS6gPSu4FlCn2mbyubozBZTYxxuCNiZYO6EMGMXBVDrVnm925wK2Gj9f34 TH1Ge7NHAy9JyWKXA6t62QlEhviJH6HfvHgQsTQmJctjmNDWRZxOVxO8USAlaOITxpp3 ewo5H9Y1B7hcd9ZOa5oyJqkQkGWFaNcRb36D7fGD0ElV38GqOfrXOc7wt5yAcb9X/ptY g9dCcE8FuWzQsquECADTrZsA7zqzLyMV74kMbD3OzIqK9hJVRq3U8A4Rp+I7DwrKFmBW 0Wgq+XB6kH66kzkluhVsQNBR6m+gR92J61n+xpXpJlHVq0Ctnt4oeIPbWCsuFrOvFbwZ Y6MQ== X-Gm-Message-State: AOAM533sJsuQEtmokwAt5CTsC/snQZWjUF3Tgwm/CvujHSueZZwZstOb Ouv6dPvAssNQv/eacKdjJ8+r/w== X-Google-Smtp-Source: ABdhPJw7fOcwcx043Wt90tRMtpSxUyd99D4Gh4C3woZxEs+TRNaI0M8Z/bYbFsDhxa/7XputJQBnmA== X-Received: by 2002:a17:90a:fe8:: with SMTP id 95mr6758722pjz.114.1608865473678; Thu, 24 Dec 2020 19:04:33 -0800 (PST) Received: from hermes.local (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id f67sm21147410pfg.159.2020.12.24.19.04.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Dec 2020 19:04:33 -0800 (PST) Date: Thu, 24 Dec 2020 19:03:17 -0800 From: Stephen Hemminger To: dapengx.yu@intel.com Cc: wenzhuo.lu@intel.com, beilei.xing@intel.com, bernard.iremonger@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20201224190317.4bac8b59@hermes.local> In-Reply-To: <20201224035748.67012-1-dapengx.yu@intel.com> References: <20201224035748.67012-1-dapengx.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 24 Dec 2020 11:57:48 +0800 dapengx.yu@intel.com wrote: > From: YU DAPENG > > In interactive mode, if testpmd exit by calling rte_exit without cmdline > resource release, terminal will not echo keyboard input. So add code to > just show error message, but not exit testpmd when unexpected happens > on starting packet forwarding in interactive mode. User can type "quit" > to exit testpmd later. > > Fixes: 5a8fb55c48ab ("app/testpmd: support unidirectional configuration") > Cc: stable@dpdk.org > > Signed-off-by: YU DAPENG Sounds like a more generic problem with rte_exit and librte_cmdline. Would it better to fix it in librte_cmdline by adding an atexit() handler.