From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id BCA3F3F9 for ; Mon, 11 Jul 2016 17:30:02 +0200 (CEST) Received: by mail-wm0-f50.google.com with SMTP id i5so22557520wmg.0 for ; Mon, 11 Jul 2016 08:30:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=aJQ5VJihSWRjfD6tH2YAlvzzTBuCA3+ZTfbYor7x/pQ=; b=gkKPdY8SstaxM3AwOkRv7ksEgRkekNH9hZqFnKsTC1r7bpPaBkHiN8+JTX2iuq0jbe HtigvHWO9CB0JRmUkIV5ctIQaINTrfYM4qKlMunkff0JX+qCWz/CmBcBjz5N6FpMAY81 dbgCYChHhIG0C/cIus217VHd9Hc1iuGBSyyUVGDB+r9/m3Ojk87e3kxOC/W/cRPu1CHa D6GiLeU3KKrQZEpKHg2sAEgsT7UFqYKzQ/yJ8NOSqhcggp5k6aeowSOAyynBFKuaLvL2 K40mQuZqYEF3O79MCc/4XR2PiFM0/IklGX31igKD2SRIKqTHIpvKBKp9Vcry5HB+mjMm V2dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=aJQ5VJihSWRjfD6tH2YAlvzzTBuCA3+ZTfbYor7x/pQ=; b=XJTTQdl5DSVaUj804sP3bkYt8YUbDoG5qaKM4r4+GNeeGwnJVHzMFqaBgtt2i5Ptfi 3ii0f5JLjSBB5lOHwYH1kiYPp+9HdKnVye7XH5hiFkhMmr83yVF8mDHfA2EDPIE0o49T 3S1q/0fr65/k9MdWq9l1miAOZTRIOas08tdu6ObYZ2mJGE9BCxKf/NRXkhSHy3MCrzxC c6dgDhW/qqrUTXZkGsa4ozDiMi87oA65TyjnOEaOhPM9LvIivT9bUPN7aAsqvdEDjVJz OJteRb1dRs71Qw/ggahd2Eu8gPYsM6sjJVmKIzKHfmjaXJoazIHSuxYJmNJAe6gZMQ8X WzPQ== X-Gm-Message-State: ALyK8tKKND8RzzZnzgS5sR4lvJvnJeFXv5xKe1LRJj13HGJIKq/BvWQT0RZ7DUFYSmC4xtgA X-Received: by 10.194.156.166 with SMTP id wf6mr389200wjb.142.1468251002475; Mon, 11 Jul 2016 08:30:02 -0700 (PDT) Received: from xps13.localnet (guy78-3-82-239-227-177.fbx.proxad.net. [82.239.227.177]) by smtp.gmail.com with ESMTPSA id w7sm368162wjh.35.2016.07.11.08.30.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jul 2016 08:30:01 -0700 (PDT) From: Thomas Monjalon To: "Singh, Jasvinder" Cc: dev@dpdk.org, "Mcnamara, John" , "Dumitrescu, Cristian" Date: Mon, 11 Jul 2016 17:29:57 +0200 Message-ID: <2020300.RGHe2OjfZK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1466704213-127847-1-git-send-email-jasvinder.singh@intel.com> <1467130945-130512-1-git-send-email-jasvinder.singh@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2016 15:30:02 -0000 > > This commit adds Python script for generating diagram of the application > > configuration file. This script requires graphviz package to be installed > > on the machine. The input config file is translated to an output file in > > DOT syntax, which is then used to create the image file using graphviz. > > > > To run the script, following command is used; > > > > ./diagram-generator.py -f > > > > Some optional arguments are as follows: > > -h, --help show this help message and exit > > > > Signed-off-by: Jasvinder Singh > > Signed-off-by: Cristian Dumitrescu > > Acked-by: Cristian Dumitrescu > > > The subject line is too long: > > $ scripts/check-git-log.sh > Headline too long: > ip_pipeline: add Python script file for creating visual diagram of IP pipeline config file > > I would suggest something like: > > ip_pipeline: add script for creating config diagrams or examples/ip_pipeline: add config diagram generator > The code looks good though, so: > > Acked-by: John McNamara Applied, thanks This example become more and more complex...