From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4476BA09FF;
Wed, 6 Jan 2021 14:21:36 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 2F421160970;
Wed, 6 Jan 2021 14:21:36 +0100 (CET)
Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com
[209.85.221.48])
by mails.dpdk.org (Postfix) with ESMTP id 9E7BC16096D
for <dev@dpdk.org>; Wed, 6 Jan 2021 14:21:34 +0100 (CET)
Received: by mail-wr1-f48.google.com with SMTP id i9so2435204wrc.4
for <dev@dpdk.org>; Wed, 06 Jan 2021 05:21:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;
h=date:from:to:cc:subject:message-id:references:mime-version
:content-disposition:in-reply-to:user-agent;
bh=ZT/oeSe3DGy91busGdLDiBGdoHRuEERNeKY19C51Wts=;
b=WgCWHvydCBwdtGot2MDZCYG4/kFY/Xk2nExHP+CVlZhcOkxaB8dTooB3h6AW0gkhL1
bWKO1mR+V3GGW/fHa/NjgQE4aZeF/e2CjCFlNnaGlupH0mzkXtrBMrDyuW7DvTBcl5e4
6ZDwROWvr+fBFP9XmHW1Ki79irDxDog3fEc/DEL1d2UNQMaaev2AHhUZPSjex32NXH9n
YPoZmOwIepVv0S34SjefYy/edo6mO3qtSg/dfj7dZ4aupoPNFVcfE9SLGSPQBfqbqPGG
B/9q+dcwLaH1S3lllSC5RpaHphNpewArncL/28ye82On3O8t7JWcBP8XJRWLQ4kyaL4e
YXEg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:references
:mime-version:content-disposition:in-reply-to:user-agent;
bh=ZT/oeSe3DGy91busGdLDiBGdoHRuEERNeKY19C51Wts=;
b=U87FltbELcLB4y1hljsIKOZxgZwRWmykhR1xjn8ewtEhTQoD8Css+YravdEJTQfzlU
Pu0EAo1AamoP2oqa4mIh23vL4fZEVwOaoQ2fBr8ylmoIpiTtPiTWNnu6EOK6rwRCMKzp
oMhftvLn6+JI8iIYtp8nvN9p3x13oEJ/YOwsoDI8KpLso874ks6WXZui8hl3GvjMdNS7
AoOKKzEghwrlauPTSj33rwSBEOmYc6YpC9h1WLbpHOWMz+iaH3JLOXLrGlc5xEGrexaX
yJ/l1sdsnvxQksMz4mg/7db+NCHcE9Z6dXschrrfLCfCO6gymnXnvxzaFVejfKTP6NOz
RopA==
X-Gm-Message-State: AOAM533BlwlEd+Bua47bscdxWkLaFDabjJlIpjXut1U5Q4m9H/xfuZeH
J9bMyS4TI9xsu069PwFwpfEthg==
X-Google-Smtp-Source: ABdhPJzAAJaJH2x1wEGzye5i9olsBARd5TelWYpEc649N8wYZtYyC7uW60dpfv3qHgIFjJh9dMfctQ==
X-Received: by 2002:a5d:54cc:: with SMTP id x12mr4361925wrv.132.1609939294411;
Wed, 06 Jan 2021 05:21:34 -0800 (PST)
Received: from 6wind.com ([2a01:e0a:5ac:6460:c065:401d:87eb:9b25])
by smtp.gmail.com with ESMTPSA id s13sm2887500wmj.28.2021.01.06.05.21.33
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 06 Jan 2021 05:21:33 -0800 (PST)
Date: Wed, 6 Jan 2021 14:21:32 +0100
From: Olivier Matz <olivier.matz@6wind.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: stephen@networkplumber.org, dev@dpdk.org
Message-ID: <20210106132132.GK2631@platinum>
References: <20201229194144.17824-1-ashish.sadanandan@gmail.com>
<20201229121008.3644fed4@hermes.local>
<CAN44U23ao-Cc1h5eWhOuhr=2r6BP1nv9CUxxoz-O=-exi3W_Xg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAN44U23ao-Cc1h5eWhOuhr=2r6BP1nv9CUxxoz-O=-exi3W_Xg@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Ashish,
On Tue, Dec 29, 2020 at 01:22:04PM -0700, Ashish Sadanandan wrote:
> Hi Stephen,
> Should I reference the commit that created rte_mbuf_dyn.h for the Fixes tag?
Yes, it should reference the patch that introduced the issue. In this case,
it should be:
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Can you please also change the title to start with "fix", for
instance like this:
mbuf: fix inclusion from c++
You can also add "Cc: stable@dpdk.org" in the commit log.
Some documentation can be found in doc/guides/contributing/patches.rst
Thanks,
Olivier
> PS: this is my first time submitting a patch to DPDK, so forgive me if this
> is covered in the contributing doc, but I couldn't find anything that
> applied to this situation
>
> On Tue, Dec 29, 2020 at 1:10 PM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
> > On Tue, 29 Dec 2020 12:41:44 -0700
> > Ashish Sadanandan <ashish.sadanandan@gmail.com> wrote:
> >
> > > The header was missing the extern "C" directive which causes name
> > > mangling of functions by C++ compilers, leading to linker errors
> > > complaining of undefined references to these functions.
> > >
> > > Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
> >
> > Could you add a Fixes tag please?
> >