From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6BE6A09FF; Wed, 6 Jan 2021 14:40:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 65572160976; Wed, 6 Jan 2021 14:40:31 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id CE3F7160973 for ; Wed, 6 Jan 2021 14:40:29 +0100 (CET) IronPort-SDR: WHTyrGoQ7xSdbYakYvElTlNlCTFPtdWJX/vfvOHQsdJLMpclNwXmzGZF9zTC5+aW6Lvtgqk3P8 fnT97jS2pWjQ== X-IronPort-AV: E=McAfee;i="6000,8403,9855"; a="164975498" X-IronPort-AV: E=Sophos;i="5.78,480,1599548400"; d="scan'208";a="164975498" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jan 2021 05:40:28 -0800 IronPort-SDR: j/TRhsLkxGz0sXZZbWWhwMyCFeZjHE02I97VZbvoxmZOnGKkX0DxkQ06noy7mV0mjm3TWixf1p eoeoOTPBL4sQ== X-IronPort-AV: E=Sophos;i="5.78,480,1599548400"; d="scan'208";a="379288318" Received: from eoinbuck-mobl1.ger.corp.intel.com (HELO bricha3-MOBL.ger.corp.intel.com) ([10.252.3.245]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 06 Jan 2021 05:40:25 -0800 Date: Wed, 6 Jan 2021 13:40:21 +0000 From: Bruce Richardson To: Andrew Boyer Cc: Honnappa Nagarahalli , "thomas@monjalon.net" , Juraj =?utf-8?Q?Linke=C5=A1?= , Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , nd Message-ID: <20210106134021.GA1867@bricha3-MOBL.ger.corp.intel.com> References: <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech> <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <36181A92-BE14-4E30-8F26-915AA109BB2F@pensando.io> <50293579.Yt1MtOie5U@thomas> <2B294ECB-F553-4E90-ADF3-A48692195390@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2B294ECB-F553-4E90-ADF3-A48692195390@pensando.io> Subject: Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 04, 2021 at 05:46:20PM -0500, Andrew Boyer wrote: > > > On Jan 1, 2021, at 12:19 PM, Honnappa Nagarahalli wrote: > >> > >> 30/12/2020 20:09, Andrew Boyer: > >>> > >>>> On Dec 23, 2020, at 6:47 AM, Juraj Linkeš > >> wrote: > >>>> > >>>> The current way of specifying Arm configuration options is > >>>> insufficient since we can't identify the SoC we're building for from > >>>> the MIDR information. For example, we can't distinguish between > >>>> N1SDP, Graviton2 or Ampere Altra. > >>>> > >>>> Add a way to specify the cpu count and numa node count for cross > >>>> builds and aarch64 -> aarch64 (SoC) builds. > >>>> > >>> > >>> Hello Juraj, > >>> This is great, you have solved a problem for me before I even knew > >>> there was one. (We have two SoCs with the same id and pn, but > >>> different core counts etc.) > >>> > >>> Can anyone fill me in on how and when this patchset is going to be taken? > >> Will it go to dpdk-next-net, or to some other branch? > >> > >> It should go in the main branch. > >> I cannot commit on any date, but for sure it would help if you can do a > >> detailed review, thanks. > > Testing on your SoC would be of great help. > > > > Hello Honnappa, Juraj, and Bruce, > > I've got most of the build working under meson. A few questions: > > 1) Bruce - when the “-Ddefault_library=both” flag is passed in, the build fails with this error. It’s been broken for a long time; maybe this option isn’t supported and should be blocked earlier? > Yes, we should catch this earlier. > ../../dpdk/app/meson.build:48:3: ERROR: Tried to get unknown variable "both_rte_ethdev". > > 2) Is there a way to disable specific libraries? I’ve pruned down the list of drivers, which is great. This feature existed under make but I don’t see anything about it in meson yet. > > 3) We need to build kni against the aarch64 kernel headers, but it fails. It appears that kernel/linux/kni/meson.build doesn’t pass any cross-compile flags in the make command it creates. The diff below shows how I hardcoded it to get it to work for now. Thoughts on how to do this right? meson has the path (in $PATH) and the binary prefixs (in ‘[binaries]’ in the cross file). It must know the arch, too. > I'll try and investigate a little on these. Patches welcome, especially for issue #3 which is new to me. For #2, there has been some previous discussion about this on list before. /Bruce > --- a/kernel/linux/kni/meson.build > +++ b/kernel/linux/kni/meson.build > @@ -14,6 +14,8 @@ custom_target('rte_kni', > input: kni_sources, > output: 'rte_kni.ko', > command: ['make', '-j4', '-C', kernel_dir + '/build', > + 'CROSS_COMPILE=/tool/toolchain/aarch64-1.1/bin/aarch64-linux-gnu-', > + 'ARCH=aarch64', > 'M=' + meson.current_build_dir(), > 'src=' + meson.current_source_dir(), > 'MODULE_CFLAGS=-include ' + meson.source_root() + '/config/rte_config.h' + > > I will try to get to a full review soon. > > Thank you, > Andrew