From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C7E8AA09FF;
	Thu,  7 Jan 2021 07:17:14 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 94E36140E91;
	Thu,  7 Jan 2021 07:17:14 +0100 (CET)
Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com
 [209.85.210.174])
 by mails.dpdk.org (Postfix) with ESMTP id CBB2C140E8D;
 Thu,  7 Jan 2021 07:17:12 +0100 (CET)
Received: by mail-pf1-f174.google.com with SMTP id d2so3236928pfq.5;
 Wed, 06 Jan 2021 22:17:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:in-reply-to:references;
 bh=CToP7w6LablYqYJ0jFMsJ6wAtcTtADTDyuWQZrLoMAQ=;
 b=lqPahUv5hjpO5mOS7HF4FRJ9HVycfy+bbl4+BUUPIlWlx1uXY85ky53fji7+jQIhX2
 vFock6x4T6fScwwXONW76eZVCDX6WS0RnC85kpdOkGTofpXemTWSPgwIzxi19yBo9XVx
 YiNVtefxHUf+0hR2vjL2bqH8wtJbT+shWbgYmsJDHzV1Z8QG4IEVb+a3RWXFIX+cQgQA
 frduI2yqfsPq65d+ImpOxPRb8Rm6cIKwaTR4LnxP6t4SMh9cWwulthBhGQxWK0QTiT6B
 8DPnS0qzwbw15tP1jv138WGUkdCehT/SQJOmwVfVyywyT2ZnVxsRqQUcb/vBWRWHNsRr
 7HYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references;
 bh=CToP7w6LablYqYJ0jFMsJ6wAtcTtADTDyuWQZrLoMAQ=;
 b=gtOJotMOmASWi7tdHA1ByWByMD966wkEC2iYRJOOw//F5juYeYnzsiHV1g2zcQrRy6
 9TtZ+jvSabrPN+V9x234iAioI9Ae/UcQXNyI1TKFZX6sE4ojaOLHfu5vi5fNMGbz1oC8
 z5ER68DojZlvylZNl1Rzddq4zelTbbYoBSLft4Qzad5qP9hUeY+/8wS4JyJbHROB3aBZ
 tfBc/5xeJEAzOwsR11lOq3EKgcvuhRttsf0VeRBgUsALVLYdSvRIA5ejVl82T6vLZi/2
 TT90vif3bQ+3JAVScBpOUGM8aok5b5BCtGynL9AufYUXVI+qbeu1FpzX42+NVnCX2MBS
 0DJg==
X-Gm-Message-State: AOAM533eYEYkoYvISte4KE22FvBGE80SClPtyksVfubYFlWZ+FIIdxDf
 LzgNdKrufy58r+FPpTBEHOk=
X-Google-Smtp-Source: ABdhPJzfQgM0bSU1dUxxJpG7p2avYaZCprPe1CNz1zEIGYEzUXyIDSXcDnMjFH9Qtm7qfkkRJ7itJQ==
X-Received: by 2002:aa7:9388:0:b029:19e:648:6480 with SMTP id
 t8-20020aa793880000b029019e06486480mr805676pfe.21.1610000231991; 
 Wed, 06 Jan 2021 22:17:11 -0800 (PST)
Received: from asadanan-lnx.qualcomm.com (i-global254.qualcomm.com.
 [199.106.103.254])
 by smtp.googlemail.com with ESMTPSA id x6sm4402371pfq.57.2021.01.06.22.17.10
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Wed, 06 Jan 2021 22:17:11 -0800 (PST)
From: Ashish Sadanandan <ashish.sadanandan@gmail.com>
To: olivier.matz@6wind.com
Cc: dev@dpdk.org, Ashish Sadanandan <ashish.sadanandan@gmail.com>,
 stable@dpdk.org
Date: Wed,  6 Jan 2021 23:16:42 -0700
Message-Id: <20210107061642.17362-1-ashish.sadanandan@gmail.com>
X-Mailer: git-send-email 2.9.3
In-Reply-To: <20201229194144.17824-1-ashish.sadanandan@gmail.com>
References: <20201229194144.17824-1-ashish.sadanandan@gmail.com>
Subject: [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from
 C++
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.

Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org

Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
v2:
* No functional change
* Add fixes tag with reference to commit that introduced the header
* CC stable@dpdk.org

 lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
  */
 
 #include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
 /**
  * Maximum length of the dynamic field or flag string.
  */
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
 __rte_experimental
 int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
 
+#ifdef __cplusplus
+}
 #endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
-- 
2.9.3