* [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
@ 2021-01-07 1:31 Ashish Sadanandan
2021-01-07 7:49 ` Olivier Matz
0 siblings, 1 reply; 6+ messages in thread
From: Ashish Sadanandan @ 2021-01-07 1:31 UTC (permalink / raw)
To: olivier.matz; +Cc: dev, Ashish Sadanandan, stable
The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org
Change-Id: I9a92ada0278ff8455cc2718f8231597b0a7c6b48
Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
v2:
* No functional change
* Add fixes tag with reference to commit that introduced the header
* CC stable@dpdk.org
lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
*/
#include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/**
* Maximum length of the dynamic field or flag string.
*/
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
__rte_experimental
int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
+#ifdef __cplusplus
+}
#endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
2021-01-07 1:31 [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
@ 2021-01-07 7:49 ` Olivier Matz
2021-01-11 14:41 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Olivier Matz @ 2021-01-07 7:49 UTC (permalink / raw)
To: Ashish Sadanandan; +Cc: dev, stable, David Marchand
On Wed, Jan 06, 2021 at 06:31:14PM -0700, Ashish Sadanandan wrote:
> The header was missing the extern "C" directive which causes name
> mangling of functions by C++ compilers, leading to linker errors
> complaining of undefined references to these functions.
>
> Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> Cc: olivier.matz@6wind.com
> Cc: stable@dpdk.org
>
> Change-Id: I9a92ada0278ff8455cc2718f8231597b0a7c6b48
I think this line can be dropped (it comes from gerrit).
David, can you do it when pushing the patch?
> Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
Thanks!
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
2021-01-07 7:49 ` Olivier Matz
@ 2021-01-11 14:41 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2021-01-11 14:41 UTC (permalink / raw)
To: Ashish Sadanandan; +Cc: dev, dpdk stable, Olivier Matz
On Thu, Jan 7, 2021 at 8:49 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Wed, Jan 06, 2021 at 06:31:14PM -0700, Ashish Sadanandan wrote:
> > The header was missing the extern "C" directive which causes name
> > mangling of functions by C++ compilers, leading to linker errors
> > complaining of undefined references to these functions.
> >
> > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
> Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h
@ 2020-12-29 19:41 Ashish Sadanandan
2021-01-07 1:38 ` [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Ashish Sadanandan @ 2020-12-29 19:41 UTC (permalink / raw)
To: olivier.matz; +Cc: dev, Ashish Sadanandan
The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.
Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
*/
#include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/**
* Maximum length of the dynamic field or flag string.
*/
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
__rte_experimental
int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
+#ifdef __cplusplus
+}
#endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
2020-12-29 19:41 [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h Ashish Sadanandan
@ 2021-01-07 1:38 ` Ashish Sadanandan
2021-01-07 6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan
2 siblings, 0 replies; 6+ messages in thread
From: Ashish Sadanandan @ 2021-01-07 1:38 UTC (permalink / raw)
To: olivier.matz; +Cc: dev, Ashish Sadanandan, stable
The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
v2:
* No functional change
* Add fixes tag with reference to commit that introduced the header
* CC stable@dpdk.org
lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
*/
#include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/**
* Maximum length of the dynamic field or flag string.
*/
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
__rte_experimental
int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
+#ifdef __cplusplus
+}
#endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
2020-12-29 19:41 [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h Ashish Sadanandan
2021-01-07 1:38 ` [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
@ 2021-01-07 6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan
2 siblings, 0 replies; 6+ messages in thread
From: Ashish Sadanandan @ 2021-01-07 6:16 UTC (permalink / raw)
To: olivier.matz; +Cc: dev, Ashish Sadanandan, stable
The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
v2:
* No functional change
* Add fixes tag with reference to commit that introduced the header
* CC stable@dpdk.org
lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
*/
#include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/**
* Maximum length of the dynamic field or flag string.
*/
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
__rte_experimental
int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
+#ifdef __cplusplus
+}
#endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++
2020-12-29 19:41 [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h Ashish Sadanandan
2021-01-07 1:38 ` [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
2021-01-07 6:16 ` Ashish Sadanandan
@ 2021-01-07 17:15 ` Ashish Sadanandan
2 siblings, 0 replies; 6+ messages in thread
From: Ashish Sadanandan @ 2021-01-07 17:15 UTC (permalink / raw)
To: dev; +Cc: olivier.matz, Ashish Sadanandan, stable
The header was missing the extern "C" directive which causes name
mangling of functions by C++ compilers, leading to linker errors
complaining of undefined references to these functions.
Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags")
Cc: olivier.matz@6wind.com
Cc: stable@dpdk.org
Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
---
v2:
* No functional change
* Add fixes tag with reference to commit that introduced the header
* CC stable@dpdk.org
lib/librte_mbuf/rte_mbuf_dyn.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/librte_mbuf/rte_mbuf_dyn.h b/lib/librte_mbuf/rte_mbuf_dyn.h
index d88e7ba..fc4eee7 100644
--- a/lib/librte_mbuf/rte_mbuf_dyn.h
+++ b/lib/librte_mbuf/rte_mbuf_dyn.h
@@ -67,6 +67,11 @@
*/
#include <sys/types.h>
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
/**
* Maximum length of the dynamic field or flag string.
*/
@@ -326,4 +331,8 @@ int rte_mbuf_dyn_rx_timestamp_register(int *field_offset, uint64_t *rx_flag);
__rte_experimental
int rte_mbuf_dyn_tx_timestamp_register(int *field_offset, uint64_t *tx_flag);
+#ifdef __cplusplus
+}
#endif
+
+#endif /* _RTE_MBUF_DYN_H_ */
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-11 14:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-07 1:31 [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
2021-01-07 7:49 ` Olivier Matz
2021-01-11 14:41 ` David Marchand
-- strict thread matches above, loose matches on Subject: below --
2020-12-29 19:41 [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h Ashish Sadanandan
2021-01-07 1:38 ` [dpdk-dev] [PATCH v2 1/1] mbuf: fix rte_mbuf_dyn.h inclusion from C++ Ashish Sadanandan
2021-01-07 6:16 ` Ashish Sadanandan
2021-01-07 17:15 ` Ashish Sadanandan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).