From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17F6FA0524; Fri, 8 Jan 2021 08:29:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 047B0140E1A; Fri, 8 Jan 2021 08:29:23 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id BD736140E0F; Fri, 8 Jan 2021 08:29:20 +0100 (CET) IronPort-SDR: 8oe4SczVGFrkUGLfOlQPcJ2RaMjLmqeEuqWkov516v6Yj59TKyZ4vx7KZA6t9VVZ5Y+lyig3tc zt5Z39L5NbZA== X-IronPort-AV: E=McAfee;i="6000,8403,9857"; a="177704923" X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="177704923" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 23:29:19 -0800 IronPort-SDR: xi1lWLzdMINzEIfywQ7LiOgFCn1fJN9ozPdyiKOnxRdC/uv/lB/rgWDIzTcbTV8xHtwsMZjGp9 yrawrGmQqdyQ== X-IronPort-AV: E=Sophos;i="5.79,330,1602572400"; d="scan'208";a="398901909" Received: from shwdenpg235.ccr.corp.intel.com ([10.240.182.60]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2021 23:29:16 -0800 From: "Zhang,Alvin" To: qi.z.zhang@intel.com Cc: dev@dpdk.org, Alvin Zhang , stable@dpdk.org Date: Fri, 8 Jan 2021 15:29:10 +0800 Message-Id: <20210108072910.11184-1-alvinx.zhang@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/ice: fix initialization of RSS look-up table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Alvin Zhang RSS look-up table initialization is done incorrectly due to divide-by-zero error. Add a check to rx-queue count. Fixes: 50370662b727 ("net/ice: support device and queue ops") Cc: stable@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index 9a5d6a5..9cef73e 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -3268,10 +3268,12 @@ static int ice_init_rss(struct ice_pf *pf) if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; - ret = ice_init_rss(pf); - if (ret) { - PMD_DRV_LOG(ERR, "Failed to enable rss for PF"); - return ret; + if (dev->data->nb_rx_queues) { + ret = ice_init_rss(pf); + if (ret) { + PMD_DRV_LOG(ERR, "Failed to enable rss for PF"); + return ret; + } } return 0; -- 1.8.3.1