From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64301A09FF; Mon, 11 Jan 2021 17:59:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 348AE140F5A; Mon, 11 Jan 2021 17:59:34 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 63786140F59 for ; Mon, 11 Jan 2021 17:59:32 +0100 (CET) IronPort-SDR: crIjs8EEQtuIwoZdigPIER9j1Hy8YyIx4dwSCJiBNXME+2jE4rpXbTl/69aN17ZhUNt5+5D0eQ A3L7FNqMQkNA== X-IronPort-AV: E=McAfee;i="6000,8403,9861"; a="177120757" X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="177120757" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2021 08:59:31 -0800 IronPort-SDR: 8MAPInW7geUdQ+Ip+56RmJeKK2ukIyDcZtiuDQ2G0RWRzH+ZcgerPYP5xqIaXcW6jLJ+4hWIzS 4OT+oMZWFYLQ== X-IronPort-AV: E=Sophos;i="5.79,339,1602572400"; d="scan'208";a="464219845" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.28.133]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 11 Jan 2021 08:59:26 -0800 Date: Mon, 11 Jan 2021 16:59:22 +0000 From: Bruce Richardson To: Andrew Boyer Cc: Thomas Monjalon , Honnappa Nagarahalli , Juraj =?utf-8?Q?Linke=C5=A1?= , Ruifeng Wang , Phil Yang , "vcchunga@amazon.com" , Dharmik Thakkar , "jerinjacobk@gmail.com" , "hemant.agrawal@nxp.com" , "Ajit Khaparde (ajit.khaparde@broadcom.com)" , "ferruh.yigit@intel.com" , "dev@dpdk.org" , "bluca@debian.org" , "david.marchand@redhat.com" , "kevin.traynor@redhat.com" Message-ID: <20210111165922.GB1083@bricha3-MOBL.ger.corp.intel.com> References: <1605874101-30893-1-git-send-email-juraj.linkes@pantheon.tech> <20210108173645.GD1823@bricha3-MOBL.ger.corp.intel.com> <26840311.mCdcc087Xs@thomas> <20210111100104.GA1046@bricha3-MOBL.ger.corp.intel.com> <7C5CEFBD-469F-4AFB-AE8A-0ACF207FB5F4@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7C5CEFBD-469F-4AFB-AE8A-0ACF207FB5F4@pensando.io> Subject: Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jan 11, 2021 at 11:16:38AM -0500, Andrew Boyer wrote: > On Jan 11, 2021, at 5:01 AM, Bruce Richardson > <[1]bruce.richardson@intel.com> wrote: > > On Mon, Jan 11, 2021 at 10:38:09AM +0100, Thomas Monjalon wrote: > > 08/01/2021 21:20, Honnappa Nagarahalli: > > On Mon, Jan 04, 2021 at 05:46:20PM -0500, Andrew Boyer wrote: > > 1) Bruce - when the “-Ddefault_library=both” flag is passed in, the > build > > fails with this error. It’s been broken for a long time; maybe this > option isn’t > supported and should be blocked earlier? > > ../../dpdk/app/meson.build:48:3: ERROR: Tried to get unknown > > variable "both_rte_ethdev". > > Revisiting this point, since there are a number of possible > approaches we can > take here, and I'd like feedback on them before we do anything. Of > these > approaches, 2 are simple, and 1 is more complicated. > 1. We can just detect this as an invalid/unsupported setting and > error out > earlier with a suitable errors message 2. Since we already support > in all cases > > I would prefer option 1 here (detect and error out). IMO, the option > "both" does not seem to solve a compelling problem. I would prefer > to avoid the additional code and complications. Mostly, everyone > would do the development with either 'static' or 'shared' and test > the other at the end when the development is completed. > > +1 for not supporting linking with both. > > Ok, thanks for the clear consensus. Will do patch to check and error > out > appropriately. > /Bruce > > It would be great if the error message for “both” pointed out that both > sets of libraries are built in the “shared” case. > > e.g. > > ‘Error: ‘both’ unsupported. ‘shared’ will build both static and shared > libraries and dynamically-linked binaries. ‘static’ will build only > static libraries and statically-linked binaries.’ > Actually "static" builds both libraries also, so default_library only affects the linking of apps/examples in the DPDK build itself. I've put that info in the patch error message as you suggested. /Bruce