From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B966AA04B5; Mon, 11 Jan 2021 20:03:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6407C14102B; Mon, 11 Jan 2021 20:02:41 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 2DCF3141031 for ; Mon, 11 Jan 2021 20:02:40 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id q4so335101plr.7 for ; Mon, 11 Jan 2021 11:02:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4A2XR7Lvc/O1iv2ByaZLiIt9DUnlARzCWCer+32JKe4=; b=kCOFVpJa7dhpHvhxQkHUBnbUh1B5pWnNsmO+s/wDf2NgJyaAmEARacP0mjhlPLN6aM FeCnOYqCky+Tu6x13BPN1E0CpuT76n2twuibsmOzCCJSELLdwDYP+g14qIPdSzacX6us Ts4bJnmd/DiZavH5bj954bxxtuwgyih+ALX/oYH3ov1V+ZtTWSafofN/I9JG/ou9/eyw 2kWVBRnHjVmNaiZQoFSe2zvj02+uvdGhkBZU7uju55jlK4xBoMNo6BdDI0loEhFttV9W L66Xtf0P+mp3TmOvLVOmkZr+gFSe3rJq6TdnDJCr4s7Dxgc3T8J8FvCyjw/IHE4Iw6mj MgLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4A2XR7Lvc/O1iv2ByaZLiIt9DUnlARzCWCer+32JKe4=; b=AY22rCrOU37G9TSKAu9x49NBp2+PYt3tqgF7/EtYhKpLB6pJ3qH5t0ROVUcLf1vSZc /fDs01eCYW4N1U+HVS9EEOmDjBz3wcyOfl7yLTxfS0GUgWT1oa0wvwgcdAkfSMMkXU1x uX7BRE/XtCcXodjF4fBJZTqCpHxApHpa3dPsmvjajUbu8Trhqxqg8DK6iiMZaGHWRSxg fB0ghGFpciW0a3GPrYV0p/WiYZTFrDospit24meEm42iqCWLTCBeMu7ViTzbvb489kIQ u/S8X5Bwq6qL9A1NvJCOPAgqe1GeMfGm7KbwFtPANTtYmZLwyuPWGqG+sxUBLjLOZEBH 1ixg== X-Gm-Message-State: AOAM533oEatpoBjV+S+rHAfsQ00o/I2tHIJPidStVrPWFMj50qag02n7 ChF4GjioIm+CrZy8yDwAT3OJ6XD3BSDyRw== X-Google-Smtp-Source: ABdhPJzOVrWwNVkRXLGvne675o/BejIgcTaXj8Wnrl3er6NIjXj/5gS+LkOuFTJh6/GkPqdp6B91eQ== X-Received: by 2002:a17:902:7489:b029:dc:bbf:d70 with SMTP id h9-20020a1709027489b02900dc0bbf0d70mr754249pll.8.1610391759178; Mon, 11 Jan 2021 11:02:39 -0800 (PST) Received: from driver-dev1.pensando.io ([12.226.153.42]) by smtp.gmail.com with ESMTPSA id x1sm361858pfc.112.2021.01.11.11.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 11:02:38 -0800 (PST) From: Andrew Boyer To: dev@dpdk.org Cc: Alfredo Cardigliano , Andrew Boyer Date: Mon, 11 Jan 2021 11:02:08 -0800 Message-Id: <20210111190209.70928-6-aboyer@pensando.io> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210111190209.70928-1-aboyer@pensando.io> References: <20210111190209.70928-1-aboyer@pensando.io> Subject: [dpdk-dev] [PATCH 5/6] net/ionic: clear up confusion around FC autoneg X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" IONIC does not support Flow-Control autonegotiation. Always wait for completion after each dev cmd. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/drivers/net/ionic/ionic_ethdev.c index 5ff155f85..838e93ef7 100644 --- a/drivers/net/ionic/ionic_ethdev.c +++ b/drivers/net/ionic/ionic_ethdev.c @@ -463,7 +463,8 @@ ionic_flow_ctrl_get(struct rte_eth_dev *eth_dev, struct ionic_dev *idev = &adapter->idev; if (idev->port_info) { - fc_conf->autoneg = idev->port_info->config.an_enable; + /* Flow control autoneg not supported */ + fc_conf->autoneg = 0; if (idev->port_info->config.pause_type) fc_conf->mode = RTE_FC_FULL; @@ -482,7 +483,12 @@ ionic_flow_ctrl_set(struct rte_eth_dev *eth_dev, struct ionic_adapter *adapter = lif->adapter; struct ionic_dev *idev = &adapter->idev; uint8_t pause_type = IONIC_PORT_PAUSE_TYPE_NONE; - uint8_t an_enable; + int err; + + if (fc_conf->autoneg) { + IONIC_PRINT(WARNING, "Flow control autoneg not supported"); + return -ENOTSUP; + } switch (fc_conf->mode) { case RTE_FC_NONE: @@ -496,12 +502,12 @@ ionic_flow_ctrl_set(struct rte_eth_dev *eth_dev, return -ENOTSUP; } - an_enable = fc_conf->autoneg; - ionic_dev_cmd_port_pause(idev, pause_type); - ionic_dev_cmd_port_autoneg(idev, an_enable); + err = ionic_dev_cmd_wait_check(idev, IONIC_DEVCMD_TIMEOUT); + if (err) + IONIC_PRINT(WARNING, "Failed to configure flow control"); - return 0; + return err; } static int -- 2.17.1