DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: thomas@monjalon.net, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
Date: Mon, 11 Jan 2021 23:29:24 +0300	[thread overview]
Message-ID: <20210111232924.0d2fb228@sovereign> (raw)
In-Reply-To: <1610391337-24080-2-git-send-email-roretzla@linux.microsoft.com>

Subject line is too long and doesn't follow the guidelines:

https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line

It could be: "eal/windows: build rte_reciprocal functions" or better.

> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 4597eb8cd..ba1443dc2 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -326,3 +326,4 @@ EXPORTS
>  	rte_mem_map
>  	rte_mem_page_size
>  	rte_mem_unmap
> +	rte_reciprocal_value_u64

+ rte_reciprocal_value

Please keep the order in .def same as in .map.


  reply	other threads:[~2021-01-11 20:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20        210111183640.CE1D7106B@dpdk.org>
     [not found] ` <1610391337-24080-1-git-send-email-roretzla@linux.microsoft.com>
2021-01-11 18:55   ` Tyler Retzlaff
2021-01-11 20:29     ` Dmitry Kozlyuk [this message]
2021-01-11 18:36 Tyler Retzlaff
2021-01-12  8:14 ` David Marchand
2021-01-12  8:17   ` David Marchand
2021-01-12 16:08     ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111232924.0d2fb228@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).