From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B29A9A04B5; Mon, 11 Jan 2021 21:29:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B358140CDE; Mon, 11 Jan 2021 21:29:28 +0100 (CET) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by mails.dpdk.org (Postfix) with ESMTP id B8D27140CD7 for ; Mon, 11 Jan 2021 21:29:26 +0100 (CET) Received: by mail-lf1-f46.google.com with SMTP id m12so1439544lfo.7 for ; Mon, 11 Jan 2021 12:29:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hCT99Lyz2A9ow2gBE5vhfurtmy64y6ouEmnUH7Nb7Cw=; b=h9ro8TpTjdCirK8yOFdINAzb6SNyO/SyWuxhDJt2CsKjXilIj5Y27N3J+yzF1lCzs2 MG+VmlbLF+WRQAiMycKH7tiVbKM7OJAg+9GnjNR7Ebm/Olks9zTVhH2STk3a9RyimA1e ABNtKJLpPaIgBz+i9HIcjlefb1e6FGAaiWZplKFlc5SOG2p402CQTQYSzmCPMtTk1Q8p Tl81j9hEsC2H3mUzHe8wPCwA1c6pVI/rPl+68z0Y6lMX/Nw1OzC4RuWRbz0SvfQ7M/F7 tonwo1A+7NlCVXiPcFXI9Uku9VCEdZIWvRBraWD0REt9DdC4HGKjm4TBZv2yWowJCpn5 wE3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hCT99Lyz2A9ow2gBE5vhfurtmy64y6ouEmnUH7Nb7Cw=; b=dwEj5Ce6F1ry+UkJwq92u40vTS24kEo+t12758YIttxYuQPb2BorURqrjR3qTKytDN Nb17wY2ZUtLRBdAcn3otAdVbp4PlQgKxoxsO4shdrAT5rShWfzc64mi5c33IvpawvDvw 3ImsbJihgFVaP7X27JXSyIfVt8kEzIECyLOUC3m0Pv6dmSAvrm0sCbOL26Ge6tfB8p2z Rx3qk7GOx92OCLJQk8PQRV8qUujVNca0DnVkUt5Q834qYxUUypYR8KWUa7y2xsTiPQ/p 5im0pOxUa29milIcZ9Xnz76Bn9AaKe2vi3DLDeMvFnKda6ljBMZRrGKNlwql8KdnFJdL IT5A== X-Gm-Message-State: AOAM532I6H3Q8noaodlc2Cnuv3ba3Iivi9y+80tfC7/wi1yabdMVm7mQ hYYje8LJIo6xfcYBuuimAT0= X-Google-Smtp-Source: ABdhPJz2uHbY7x/LnitJWH74NeAAvcIHqN+g/0O1NUsq11MIWSl4MC1aeSm57SslBpXcTR27T1aXHw== X-Received: by 2002:a19:3c5:: with SMTP id 188mr554292lfd.202.1610396966228; Mon, 11 Jan 2021 12:29:26 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id z9sm101216lfb.287.2021.01.11.12.29.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 12:29:25 -0800 (PST) Date: Mon, 11 Jan 2021 23:29:24 +0300 From: Dmitry Kozlyuk To: Tyler Retzlaff Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20210111232924.0d2fb228@sovereign> In-Reply-To: <1610391337-24080-2-git-send-email-roretzla@linux.microsoft.com> References: <20 210111183640.CE1D7106B@dpdk.org> <1610391337-24080-1-git-send-email-roretzla@linux.microsoft.com> <1610391337-24080-2-git-send-email-roretzla@linux.microsoft.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Subject line is too long and doesn't follow the guidelines: https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line It could be: "eal/windows: build rte_reciprocal functions" or better. > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 4597eb8cd..ba1443dc2 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -326,3 +326,4 @@ EXPORTS > rte_mem_map > rte_mem_page_size > rte_mem_unmap > + rte_reciprocal_value_u64 + rte_reciprocal_value Please keep the order in .def same as in .map.