* [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
[not found] ` <1610391337-24080-1-git-send-email-roretzla@linux.microsoft.com>
@ 2021-01-11 18:55 ` Tyler Retzlaff
2021-01-11 20:29 ` Dmitry Kozlyuk
0 siblings, 1 reply; 6+ messages in thread
From: Tyler Retzlaff @ 2021-01-11 18:55 UTC (permalink / raw)
To: thomas; +Cc: dev
From: Tyler Retzlaff <roretzla@microsoft.com>
Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/rte_eal_exports.def | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 39abf7a0a..9c6f18eb8 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -34,6 +34,7 @@ if is_windows
'rte_malloc.c',
'eal_common_timer.c',
'rte_service.c',
+ 'rte_reciprocal.c',
)
subdir_done()
endif
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 4597eb8cd..ba1443dc2 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -326,3 +326,4 @@ EXPORTS
rte_mem_map
rte_mem_page_size
rte_mem_unmap
+ rte_reciprocal_value_u64
--
2.29.0.vfs.0.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
@ 2021-01-11 18:36 Tyler Retzlaff
2021-01-12 8:14 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Tyler Retzlaff @ 2021-01-11 18:36 UTC (permalink / raw)
To: thomas; +Cc: dev
From: Tyler Retzlaff <roretzla@microsoft.com>
---
lib/librte_eal/common/meson.build | 1 +
lib/librte_eal/rte_eal_exports.def | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 39abf7a0a..9c6f18eb8 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -34,6 +34,7 @@ if is_windows
'rte_malloc.c',
'eal_common_timer.c',
'rte_service.c',
+ 'rte_reciprocal.c',
)
subdir_done()
endif
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 4597eb8cd..ba1443dc2 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -326,3 +326,4 @@ EXPORTS
rte_mem_map
rte_mem_page_size
rte_mem_unmap
+ rte_reciprocal_value_u64
--
2.29.0.vfs.0.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
2021-01-11 18:36 Tyler Retzlaff
@ 2021-01-12 8:14 ` David Marchand
2021-01-12 8:17 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2021-01-12 8:14 UTC (permalink / raw)
To: Tyler Retzlaff; +Cc: Thomas Monjalon, dev
On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
Commitlog please.
>
> From: Tyler Retzlaff <roretzla@microsoft.com>
>
> ---
> lib/librte_eal/common/meson.build | 1 +
> lib/librte_eal/rte_eal_exports.def | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
> index 39abf7a0a..9c6f18eb8 100644
> --- a/lib/librte_eal/common/meson.build
> +++ b/lib/librte_eal/common/meson.build
> @@ -34,6 +34,7 @@ if is_windows
> 'rte_malloc.c',
> 'eal_common_timer.c',
> 'rte_service.c',
> + 'rte_reciprocal.c',
> )
> subdir_done()
> endif
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 4597eb8cd..ba1443dc2 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -326,3 +326,4 @@ EXPORTS
> rte_mem_map
> rte_mem_page_size
> rte_mem_unmap
> + rte_reciprocal_value_u64
Looking at rte_reciprocal.c/.h and EAL version.map, this API exports
two symbols.
If there is no reason why the other symbol has been skipped, please add both:
rte_reciprocal_value
rte_reciprocal_value_u64
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
2021-01-12 8:14 ` David Marchand
@ 2021-01-12 8:17 ` David Marchand
2021-01-12 16:08 ` Tyler Retzlaff
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2021-01-12 8:17 UTC (permalink / raw)
To: Tyler Retzlaff; +Cc: Thomas Monjalon, dev
On Tue, Jan 12, 2021 at 9:14 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
>
> Commitlog please.
>
> >
> > From: Tyler Retzlaff <roretzla@microsoft.com>
> >
> > ---
> > lib/librte_eal/common/meson.build | 1 +
> > lib/librte_eal/rte_eal_exports.def | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
> > index 39abf7a0a..9c6f18eb8 100644
> > --- a/lib/librte_eal/common/meson.build
> > +++ b/lib/librte_eal/common/meson.build
> > @@ -34,6 +34,7 @@ if is_windows
> > 'rte_malloc.c',
> > 'eal_common_timer.c',
> > 'rte_service.c',
> > + 'rte_reciprocal.c',
> > )
> > subdir_done()
> > endif
> > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> > index 4597eb8cd..ba1443dc2 100644
> > --- a/lib/librte_eal/rte_eal_exports.def
> > +++ b/lib/librte_eal/rte_eal_exports.def
> > @@ -326,3 +326,4 @@ EXPORTS
> > rte_mem_map
> > rte_mem_page_size
> > rte_mem_unmap
> > + rte_reciprocal_value_u64
>
> Looking at rte_reciprocal.c/.h and EAL version.map, this API exports
> two symbols.
> If there is no reason why the other symbol has been skipped, please add both:
> rte_reciprocal_value
> rte_reciprocal_value_u64
Dmitry made the same comments on another (unthreaded) version of this
patch, so we are good.
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64
2021-01-12 8:17 ` David Marchand
@ 2021-01-12 16:08 ` Tyler Retzlaff
0 siblings, 0 replies; 6+ messages in thread
From: Tyler Retzlaff @ 2021-01-12 16:08 UTC (permalink / raw)
To: David Marchand; +Cc: dev
hi,
On Tue, Jan 12, 2021 at 09:17:40AM +0100, David Marchand wrote:
>
> Dmitry made the same comments on another (unthreaded) version of this
> patch, so we are good.
apologies for this, I fat fingered the submission of v2 of the patch
and split the thread unintentionally.
readers should regard this thread as dead.
>
> --
> David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-12 16:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20 210111183640.CE1D7106B@dpdk.org>
[not found] ` <1610391337-24080-1-git-send-email-roretzla@linux.microsoft.com>
2021-01-11 18:55 ` [dpdk-dev] [PATCH] build rte_reciprocal.c on windows and export rte_reciprocal_value_u64 Tyler Retzlaff
2021-01-11 20:29 ` Dmitry Kozlyuk
2021-01-11 18:36 Tyler Retzlaff
2021-01-12 8:14 ` David Marchand
2021-01-12 8:17 ` David Marchand
2021-01-12 16:08 ` Tyler Retzlaff
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).