From: Tyler Retzlaff <roretzla@microsoft.com> --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index 39abf7a0a..9c6f18eb8 100644 --- a/lib/librte_eal/common/meson.build +++ b/lib/librte_eal/common/meson.build @@ -34,6 +34,7 @@ if is_windows 'rte_malloc.c', 'eal_common_timer.c', 'rte_service.c', + 'rte_reciprocal.c', ) subdir_done() endif diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 4597eb8cd..ba1443dc2 100644 --- a/lib/librte_eal/rte_eal_exports.def +++ b/lib/librte_eal/rte_eal_exports.def @@ -326,3 +326,4 @@ EXPORTS rte_mem_map rte_mem_page_size rte_mem_unmap + rte_reciprocal_value_u64 -- 2.29.0.vfs.0.0
From: Tyler Retzlaff <roretzla@microsoft.com> Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com> --- lib/librte_eal/common/meson.build | 1 + lib/librte_eal/rte_eal_exports.def | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build index 39abf7a0a..9c6f18eb8 100644 --- a/lib/librte_eal/common/meson.build +++ b/lib/librte_eal/common/meson.build @@ -34,6 +34,7 @@ if is_windows 'rte_malloc.c', 'eal_common_timer.c', 'rte_service.c', + 'rte_reciprocal.c', ) subdir_done() endif diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def index 4597eb8cd..ba1443dc2 100644 --- a/lib/librte_eal/rte_eal_exports.def +++ b/lib/librte_eal/rte_eal_exports.def @@ -326,3 +326,4 @@ EXPORTS rte_mem_map rte_mem_page_size rte_mem_unmap + rte_reciprocal_value_u64 -- 2.29.0.vfs.0.0
Subject line is too long and doesn't follow the guidelines: https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line It could be: "eal/windows: build rte_reciprocal functions" or better. > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def > index 4597eb8cd..ba1443dc2 100644 > --- a/lib/librte_eal/rte_eal_exports.def > +++ b/lib/librte_eal/rte_eal_exports.def > @@ -326,3 +326,4 @@ EXPORTS > rte_mem_map > rte_mem_page_size > rte_mem_unmap > + rte_reciprocal_value_u64 + rte_reciprocal_value Please keep the order in .def same as in .map.
On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
<roretzla@linux.microsoft.com> wrote:
Commitlog please.
>
> From: Tyler Retzlaff <roretzla@microsoft.com>
>
> ---
> lib/librte_eal/common/meson.build | 1 +
> lib/librte_eal/rte_eal_exports.def | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
> index 39abf7a0a..9c6f18eb8 100644
> --- a/lib/librte_eal/common/meson.build
> +++ b/lib/librte_eal/common/meson.build
> @@ -34,6 +34,7 @@ if is_windows
> 'rte_malloc.c',
> 'eal_common_timer.c',
> 'rte_service.c',
> + 'rte_reciprocal.c',
> )
> subdir_done()
> endif
> diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> index 4597eb8cd..ba1443dc2 100644
> --- a/lib/librte_eal/rte_eal_exports.def
> +++ b/lib/librte_eal/rte_eal_exports.def
> @@ -326,3 +326,4 @@ EXPORTS
> rte_mem_map
> rte_mem_page_size
> rte_mem_unmap
> + rte_reciprocal_value_u64
Looking at rte_reciprocal.c/.h and EAL version.map, this API exports
two symbols.
If there is no reason why the other symbol has been skipped, please add both:
rte_reciprocal_value
rte_reciprocal_value_u64
--
David Marchand
On Tue, Jan 12, 2021 at 9:14 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Jan 11, 2021 at 7:36 PM Tyler Retzlaff
> <roretzla@linux.microsoft.com> wrote:
>
> Commitlog please.
>
> >
> > From: Tyler Retzlaff <roretzla@microsoft.com>
> >
> > ---
> > lib/librte_eal/common/meson.build | 1 +
> > lib/librte_eal/rte_eal_exports.def | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
> > index 39abf7a0a..9c6f18eb8 100644
> > --- a/lib/librte_eal/common/meson.build
> > +++ b/lib/librte_eal/common/meson.build
> > @@ -34,6 +34,7 @@ if is_windows
> > 'rte_malloc.c',
> > 'eal_common_timer.c',
> > 'rte_service.c',
> > + 'rte_reciprocal.c',
> > )
> > subdir_done()
> > endif
> > diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
> > index 4597eb8cd..ba1443dc2 100644
> > --- a/lib/librte_eal/rte_eal_exports.def
> > +++ b/lib/librte_eal/rte_eal_exports.def
> > @@ -326,3 +326,4 @@ EXPORTS
> > rte_mem_map
> > rte_mem_page_size
> > rte_mem_unmap
> > + rte_reciprocal_value_u64
>
> Looking at rte_reciprocal.c/.h and EAL version.map, this API exports
> two symbols.
> If there is no reason why the other symbol has been skipped, please add both:
> rte_reciprocal_value
> rte_reciprocal_value_u64
Dmitry made the same comments on another (unthreaded) version of this
patch, so we are good.
--
David Marchand
hi, On Tue, Jan 12, 2021 at 09:17:40AM +0100, David Marchand wrote: > > Dmitry made the same comments on another (unthreaded) version of this > patch, so we are good. apologies for this, I fat fingered the submission of v2 of the patch and split the thread unintentionally. readers should regard this thread as dead. > > -- > David Marchand