DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions
@ 2021-01-11 23:16 Tyler Retzlaff
  2021-01-11 23:16 ` Tyler Retzlaff
  0 siblings, 1 reply; 4+ messages in thread
From: Tyler Retzlaff @ 2021-01-11 23:16 UTC (permalink / raw)
  To: dev; +Cc: thomas, dmitry.kozliuk


v2 of the patch corrects the following feedback.
  * reduce subject line length, take that recommended by Dmitry Kozlyuk
  * mirror export function order in .def to that of .map
  * add export of rte_reciprocal_value

thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions
  2021-01-11 23:16 [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions Tyler Retzlaff
@ 2021-01-11 23:16 ` Tyler Retzlaff
  2021-01-11 23:49   ` Dmitry Kozlyuk
  0 siblings, 1 reply; 4+ messages in thread
From: Tyler Retzlaff @ 2021-01-11 23:16 UTC (permalink / raw)
  To: dev; +Cc: thomas, dmitry.kozliuk

From: Tyler Retzlaff <roretzla@microsoft.com>

build rte_reciprocal.c and export the following functions on windows
  * rte_reciprocal_value
  * rte_reciprocal_value_u64

Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
---
 lib/librte_eal/common/meson.build  | 1 +
 lib/librte_eal/rte_eal_exports.def | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index 39abf7a0a..9c6f18eb8 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -34,6 +34,7 @@ if is_windows
 		'rte_malloc.c',
 		'eal_common_timer.c',
 		'rte_service.c',
+		'rte_reciprocal.c',
 	)
 	subdir_done()
 endif
diff --git a/lib/librte_eal/rte_eal_exports.def b/lib/librte_eal/rte_eal_exports.def
index 4597eb8cd..99f64194d 100644
--- a/lib/librte_eal/rte_eal_exports.def
+++ b/lib/librte_eal/rte_eal_exports.def
@@ -128,6 +128,8 @@ EXPORTS
 	rte_memzone_walk
 	rte_openlog_stream
 	rte_realloc
+	rte_reciprocal_value
+	rte_reciprocal_value_u64
 	rte_rtm_supported
 	rte_service_attr_get
 	rte_service_attr_reset_all
-- 
2.29.0.vfs.0.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions
  2021-01-11 23:16 ` Tyler Retzlaff
@ 2021-01-11 23:49   ` Dmitry Kozlyuk
  2021-01-15 13:56     ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Kozlyuk @ 2021-01-11 23:49 UTC (permalink / raw)
  To: Tyler Retzlaff; +Cc: dev, thomas

On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote:
> From: Tyler Retzlaff <roretzla@microsoft.com>
> 
> build rte_reciprocal.c and export the following functions on windows
>   * rte_reciprocal_value
>   * rte_reciprocal_value_u64
> 
> Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
> ---

FYI, this is the place you could put description of changes in v2 for
single-item patch sets.

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions
  2021-01-11 23:49   ` Dmitry Kozlyuk
@ 2021-01-15 13:56     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-01-15 13:56 UTC (permalink / raw)
  To: Tyler Retzlaff; +Cc: dev, Dmitry Kozlyuk

12/01/2021 00:49, Dmitry Kozlyuk:
> On Mon, 11 Jan 2021 15:16:36 -0800, Tyler Retzlaff wrote:
> > From: Tyler Retzlaff <roretzla@microsoft.com>
> > 
> > build rte_reciprocal.c and export the following functions on windows
> >   * rte_reciprocal_value
> >   * rte_reciprocal_value_u64
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
> > ---
> 
> FYI, this is the place you could put description of changes in v2 for
> single-item patch sets.
> 
> Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-01-15 13:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-11 23:16 [dpdk-dev] [PATCH v2] eal/windows: build rte_reciprocal functions Tyler Retzlaff
2021-01-11 23:16 ` Tyler Retzlaff
2021-01-11 23:49   ` Dmitry Kozlyuk
2021-01-15 13:56     ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git